-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ot-cli shell commissioning issue #15165
Merged
jepenven-silabs
merged 4 commits into
project-chip:master
from
mkardous-silabs:fix/matter_shell
Feb 23, 2022
Merged
fix ot-cli shell commissioning issue #15165
jepenven-silabs
merged 4 commits into
project-chip:master
from
mkardous-silabs:fix/matter_shell
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #15165: Size comparison from 7721423 to 5902d27 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
approved these changes
Feb 14, 2022
jmartinez-silabs
approved these changes
Feb 14, 2022
eb10d2d
to
8e4b073
Compare
PR #15165: Size comparison from 3f68c3c to 8e4b073 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 21, 2022
jmeg-sfy
approved these changes
Feb 22, 2022
8e4b073
to
44873af
Compare
mrjerryjohns
approved these changes
Feb 22, 2022
PR #15165: Size comparison from 36564e0 to 44873af Full report (20 builds for efr32, linux, p6, qpg)
|
97520bc
to
b073df6
Compare
PR #15165: Size comparison from 22fb6c3 to b073df6 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
b073df6
to
7444161
Compare
PR #15165: Size comparison from 1b4bbaa to 7444161 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the ot-cli was enabled within the matter shell, devices would not register their SRP service with the OTBR and the commisionning woudl fail
Change overview
For non zephyr devices, enable the ot-cli inside the openthread init function
Testing
Manual tests with efr32 MG12 and MG24 to validate the commissioning works with and without the matter shell