Address items in 14279

[chrisdecenzo]

Problem

• Address Issue 14279

Change overview

• removed unneeded includes
• changed CatalogVendorApp function arguments from object to const pointers
• fix recent regression that broke commissioning from tv-app
• remove CreateBindingWithCallback from CHIPDeviceController

Testing

• performed tv-app and tv-casting-app commissioning
• assorted tv-app and chip-tool cluster commands

[andy31415]

@chrisdecenzo - is this still a draft as the title says? the issue is not marked as draft anymore, but title says it is.

[chrisdecenzo]

@chrisdecenzo - is this still a draft as the title says? the issue is not marked as draft anymore, but title says it is.

This is no longer a draft. Working now to get CI to succeed.

[github-actions]

PR #14666: Size comparison from 62e37a2 to a09acfa

Full report (5 builds for efr32, linux)

platform	target	config	section	62e37a2	a09acfa	change	% change
efr32	lighting-app	BRD4161A	(read only)	856920	856920	0	0.0
			(read/write)	125888	125888	0	0.0
			.bss	123960	123960	0	0.0
			.data	1924	1924	0	0.0
			.text	856912	856912	0	0.0
	window-app	BRD4161A	(read only)	829140	829140	0	0.0
			(read/write)	124528	124528	0	0.0
			.bss	122648	122648	0	0.0
			.data	1880	1880	0	0.0
			.text	829132	829132	0	0.0
	lighting-app	BRD4161A+rpc	(read only)	844272	844272	0	0.0
			(read/write)	142544	142544	0	0.0
			.bss	140520	140520	0	0.0
			.data	2024	2024	0	0.0
			.text	844264	844264	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	7237972	7237972	0	0.0
			(read/write)	287873	287873	0	0.0
			.bss	50641	50641	0	0.0
			.data	1176	1176	0	0.0
			.data.rel.ro	186488	186488	0	0.0
			.dynamic	560	560	0	0.0
			.got	45776	45776	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	392572	392572	0	0.0
			.text	6240660	6240660	0	0.0
	thermostat-no-ble	arm64	(read only)	2125188	2125188	0	0.0
			(read/write)	140705	140705	0	0.0
			.bss	57745	57745	0	0.0
			.data	968	968	0	0.0
			.data.rel.ro	74872	74872	0	0.0
			.dynamic	560	560	0	0.0
			.got	4152	4152	0	0.0
			.init	24	24	0	0.0
			.init_array	328	328	0	0.0
			.rodata	131236	131236	0	0.0
			.text	1776000	1776000	0	0.0

[github-actions]

PR #14666: Size comparison from e94c9a9 to 4f25f01

Full report (21 builds for cyw30739, linux, nrfconnect, p6, qpg)

platform	target	config	section	e94c9a9	4f25f01	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	587670	587670	0	0.0
			.app_xip_area	494404	494404	0	0.0
			.bss	75988	75988	0	0.0
			.data	624	624	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	545586	545586	0	0.0
			.app_xip_area	453880	453880	0	0.0
			.bss	74460	74460	0	0.0
			.data	588	588	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor	cyw930739m2evb_01	(read/write)	570010	570010	0	0.0
			.app_xip_area	468984	468984	0	0.0
			.bss	83452	83452	0	0.0
			.data	532	532	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	7238916	7238916	0	0.0
			(read/write)	287921	287921	0	0.0
			.bss	50641	50641	0	0.0
			.data	1176	1176	0	0.0
			.data.rel.ro	186528	186528	0	0.0
			.dynamic	560	560	0	0.0
			.got	45784	45784	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	392812	392812	0	0.0
			.text	6241268	6241268	0	0.0
	thermostat-no-ble	arm64	(read only)	2127092	2127092	0	0.0
			(read/write)	140561	140561	0	0.0
			.bss	57601	57601	0	0.0
			.data	968	968	0	0.0
			.data.rel.ro	74872	74872	0	0.0
			.dynamic	560	560	0	0.0
			.got	4152	4152	0	0.0
			.init	24	24	0	0.0
			.init_array	328	328	0	0.0
			.rodata	131348	131348	0	0.0
			.text	1777792	1777792	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	998095	998095	0	0.0
			bss	120404	120404	0	0.0
			rodata	117308	117308	0	0.0
			text	681464	681464	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	969451	969451	0	0.0
			bss	116260	116260	0	0.0
			rodata	108696	108696	0	0.0
			text	666020	666020	0	0.0
		nrf52840dongle_nrf52840	(read/write)	1014783	1014783	0	0.0
			bss	121768	121768	0	0.0
			rodata	116144	116144	0	0.0
			text	686956	686956	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	904786	904786	0	0.0
			bss	116964	116964	0	0.0
			rodata	110564	110564	0	0.0
			text	596472	596472	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	930235	930235	0	0.0
			bss	118740	118740	0	0.0
			rodata	105656	105656	0	0.0
			text	627324	627324	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	837762	837762	0	0.0
			bss	115336	115336	0	0.0
			rodata	98828	98828	0	0.0
			text	543108	543108	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	541779	541779	0	0.0
			bss	52588	52588	0	0.0
			rodata	50048	50048	0	0.0
			text	376940	376940	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	932867	932867	0	0.0
			bss	118492	118492	0	0.0
			rodata	106128	106128	0	0.0
			text	629660	629660	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	927807	927807	0	0.0
			bss	118496	118496	0	0.0
			rodata	105132	105132	0	0.0
			text	625600	625600	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	802811	802811	0	0.0
			bss	110968	110968	0	0.0
			rodata	78480	78480	0	0.0
			text	535792	535792	0	0.0
p6	all-clusters-app	default	(read/write)	2450304	2450304	0	0.0
			.bss	117128	117128	0	0.0
			.data	2584	2584	0	0.0
			.text	1408568	1408568	0	0.0
	light-app	default	(read/write)	2353736	2353736	0	0.0
			.bss	106128	106128	0	0.0
			.data	2432	2432	0	0.0
			.text	1312000	1312000	0	0.0
	lock-app	default	(read/write)	2318944	2318944	0	0.0
			.bss	105848	105848	0	0.0
			.data	2392	2392	0	0.0
			.text	1277208	1277208	0	0.0
qpg	lighting-app	qpg6105+debug	(read only)	580468	580468	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	87976	87976	0	0.0
			.data	1088	1088	0	0.0
			.text	575148	575148	0	0.0
	lock-app	qpg6105+debug	(read only)	526548	526548	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	87424	87424	0	0.0
			.data	1024	1024	0	0.0
			.text	521228	521228	0	0.0
	persistent-storage-app	qpg6105+debug	(read only)	107140	107140	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	38504	38504	0	0.0
			.data	288	288	0	0.0
			.text	101820	101820	0	0.0