Python REPL: Persistent Storage, Multi Fabric, JupyterLab Support, #13715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
controller
documentation
|
PR #13715: Size comparison from aa00176 to 896187f Increases above 0.2%:
Increases (13 builds for efr32, k32w, linux, p6, qpg, telink)
Decreases (2 builds for linux, qpg)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
mrjerryjohns
force-pushed
the
python/persistent-storage
branch
from
896187f to
44f2f55
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02 and
msandstedt
andy31415
reviewed
Jan 19, 2022
andy31415
reviewed
Jan 19, 2022
andy31415
reviewed
Jan 19, 2022
andy31415
reviewed
Jan 19, 2022
andy31415
reviewed
Jan 19, 2022
|
PR #13715: Size comparison from ffd25d8 to 36b7a6f Increases above 0.2%:
Increases (14 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
Decreases (2 builds for linux, qpg)
Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
bzbarsky-apple
requested changes
Jan 19, 2022
Yes, there are. This PR is just put out to get reviews started, but it has bits from #13569 as well. I'm trying to get that merged today. |
|
PR #13715: Size comparison from d6b2a6b to 37115be Increases (3 builds for k32w, linux, qpg)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
get implicitly shutdown when users of the REPL manually shutdown controllers completely or if they call ChipReplStartup.LoadFabricAdmins() multiple times (as they would in a Jupyter Notebook).
erjiaqing
reviewed
Jan 26, 2022
|
Fast tracking, given > 3 business days for review. |
|
PR #13715: Size comparison from 92f8343 to c257790 Increases (1 build for linux)
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
|
PR #13715: Size comparison from 92f8343 to 399f99e Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the following features in the Python REPL:
FabricAdminclass that manages the fabric, whileChipDeviceControllershifts away from being a singleton to encapsulating a controller instance on that fabric. We can now instantiate multiple fabrics in the REPL as well as commission a device onto multiple such fabrics.Testing:
functionality work well. This includes commissioning a target onto
multiple fabrics and ensuring IM interactions work.