Fix ReadEvent for issue #11951

[yunhanw-google]

Problem

Fix ReadEvent for issue #11951

Change overview

See above

Testing

Add unit test to validate this API, still waiting for #12059, so cannot validate the actual event data

[todo]

Need to add check when IM event server integration completes

connectedhomeip/src/controller/tests/data_model/TestRead.cpp

Lines 184 to 194 in 01c8078

	// TODO: Need to add check when IM event server integration completes
	IgnoreUnusedVariable(apSuite);
	onSuccessCbInvoked = true;
	};
	// Passing of stack variables by reference is only safe because of synchronous completion of the interaction. Otherwise, it's
	// not safe to do so.
	auto onFailureCb = [&onFailureCbInvoked](const app::EventHeader * eventHeader, Protocols::InteractionModel::Status aIMStatus,
	CHIP_ERROR aError) { onFailureCbInvoked = true; };
	chip::Controller::ReadEvent<TestCluster::Events::TestEvent::DecodableType>(&ctx.GetExchangeManager(), sessionHandle,

---

This comment was generated by todo based on a TODO comment in 01c8078 in #12626. cc @yunhanw-google.

[github-actions]

PR #12626: Size comparison from 00df3cf to 722425d

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	00df3cf	722425d	change	% change
efr32	lighting-app	BRD4161A	(read only)	796932	796932	0	0.0
			(read/write)	120724	120724	0	0.0
			.bss	118896	118896	0	0.0
			.data	1828	1828	0	0.0
			.text	796924	796924	0	0.0
		BRD4161A+rpc	(read only)	824908	824908	0	0.0
			(read/write)	139032	139032	0	0.0
			.bss	137096	137096	0	0.0
			.data	1936	1936	0	0.0
			.text	824900	824900	0	0.0
	lock-app	BRD4161A	(read only)	771960	771960	0	0.0
			(read/write)	118664	118664	0	0.0
			.bss	116872	116872	0	0.0
			.data	1788	1788	0	0.0
			.text	771952	771952	0	0.0
	window-app	BRD4161A	(read only)	774264	774264	0	0.0
			(read/write)	118864	118864	0	0.0
			.bss	117072	117072	0	0.0
			.data	1792	1792	0	0.0
			.text	774256	774256	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	853608	853608	0	0.0
			(read/write)	1293690	1293690	0	0.0
			.dram0.bss	56296	56296	0	0.0
			.dram0.data	14084	14084	0	0.0
			.flash.rodata	170264	170264	0	0.0
			.flash.text	853608	853608	0	0.0
			.iram0.text	62076	62076	0	0.0
		m5stack	(read only)	924223	924223	0	0.0
			(read/write)	424944	424944	0	0.0
			.dram0.bss	61672	61672	0	0.0
			.dram0.data	34016	34016	0	0.0
			.flash.rodata	197748	197748	0	0.0
			.flash.text	918839	918839	0	0.0
			.iram0.text	123171	123171	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	731860	731860	0	0.0
			.bss	79392	79392	0	0.0
			.data	1860	1860	0	0.0
			.text	644808	644808	0	0.0
	lock-app	k32w061+debug	(read/write)	622080	622080	0	0.0
			.bss	70056	70056	0	0.0
			.data	1828	1828	0	0.0
			.text	544396	544396	0	0.0
	shell	k32w061+debug	(read/write)	687972	687972	0	0.0
			.bss	81704	81704	0	0.0
			.data	1800	1800	0	0.0
			.text	598668	598668	0	0.0
linux	all-clusters-app	debug	(read only)	1871297	1871297	0	0.0
			(read/write)	124560	124560	0	0.0
			.bss	50832	50832	0	0.0
			.data	1120	1120	0	0.0
			.data.rel.ro	67184	67184	0	0.0
			.dynamic	592	592	0	0.0
			.got	4120	4120	0	0.0
			.init	27	27	0	0.0
			.init_array	696	696	0	0.0
			.rodata	152245	152245	0	0.0
			.text	1575778	1575778	0	0.0
	bridge-app	debug+rpc	(read only)	1443293	1443293	0	0.0
			(read/write)	74872	74872	0	0.0
			.bss	36432	36432	0	0.0
			.data	1728	1728	0	0.0
			.data.rel.ro	31632	31632	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	480	480	0	0.0
			.rodata	121628	121628	0	0.0
			.text	1216597	1216597	0	0.0
	chip-tool	debug	(read only)	6638509	6638509	0	0.0
			(read/write)	200008	200008	0	0.0
			.bss	34696	34696	0	0.0
			.data	1024	1024	0	0.0
			.data.rel.ro	158600	158600	0	0.0
			.dynamic	592	592	0	0.0
			.got	4496	4496	0	0.0
			.init	27	27	0	0.0
			.init_array	568	568	0	0.0
			.rodata	311512	311512	0	0.0
			.text	5922101	5922101	0	0.0
	lighting-app	debug+rpc	(read only)	1728377	1728377	0	0.0
			(read/write)	107936	107936	0	0.0
			.bss	42128	42128	0	0.0
			.data	1280	1280	0	0.0
			.data.rel.ro	59136	59136	0	0.0
			.dynamic	608	608	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	142257	142257	0	0.0
			.text	1443282	1443282	0	0.0
	ota-provider-app	debug	(read only)	1400833	1400833	0	0.0
			(read/write)	73072	73072	0	0.0
			.bss	39008	39008	0	0.0
			.data	928	928	0	0.0
			.data.rel.ro	27944	27944	0	0.0
			.dynamic	592	592	0	0.0
			.got	4056	4056	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	122984	122984	0	0.0
			.text	1172994	1172994	0	0.0
	ota-requestor-app	debug	(read only)	1510089	1510089	0	0.0
			(read/write)	78120	78120	0	0.0
			.bss	42176	42176	0	0.0
			.data	992	992	0	0.0
			.data.rel.ro	29720	29720	0	0.0
			.dynamic	592	592	0	0.0
			.got	4064	4064	0	0.0
			.init	27	27	0	0.0
			.init_array	544	544	0	0.0
			.rodata	135728	135728	0	0.0
			.text	1265554	1265554	0	0.0
	shell	debug	(read only)	823449	823449	0	0.0
			(read/write)	60616	60616	0	0.0
			.bss	16936	16936	0	0.0
			.data	256	256	0	0.0
			.data.rel.ro	38936	38936	0	0.0
			.dynamic	592	592	0	0.0
			.got	3520	3520	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	84658	84658	0	0.0
			.text	631954	631954	0	0.0
	tv-app	debug	(read only)	2045137	2045137	0	0.0
			(read/write)	320288	320288	0	0.0
			.bss	247448	247448	0	0.0
			.data	2768	2768	0	0.0
			.data.rel.ro	64240	64240	0	0.0
			.dynamic	592	592	0	0.0
			.got	4456	4456	0	0.0
			.init	27	27	0	0.0
			.init_array	736	736	0	0.0
			.rodata	174480	174480	0	0.0
			.text	1715746	1715746	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2312672	2312672	0	0.0
			.bss	179484	179484	0	0.0
			.data	5184	5184	0	0.0
			.heap	851776	851776	0	0.0
			.text	1275248	1275248	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2298808	2298808	0	0.0
			.bss	173384	173384	0	0.0
			.data	5496	5496	0	0.0
			.heap	857568	857568	0	0.0
			.text	1261408	1261408	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2272872	2272872	0	0.0
			.bss	172424	172424	0	0.0
			.data	5496	5496	0	0.0
			.heap	858528	858528	0	0.0
			.text	1235472	1235472	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1140008	1140008	0	0.0
			.bss	11756	11756	0	0.0
			.data	4376	4376	0	0.0
			.heap	1020312	1020312	0	0.0
			.text	103392	103392	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2047472	2047472	0	0.0
			.bss	156732	156732	0	0.0
			.data	4872	4872	0	0.0
			.heap	874840	874840	0	0.0
			.text	1010072	1010072	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	894879	894879	0	0.0
			bss	113836	113836	0	0.0
			rodata	99664	99664	0	0.0
			text	605816	605816	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	858255	858255	0	0.0
			bss	110184	110184	0	0.0
			rodata	91024	91024	0	0.0
			text	580812	580812	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	820778	820778	0	0.0
			bss	115208	115208	0	0.0
			rodata	94924	94924	0	0.0
			text	536148	536148	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	866935	866935	0	0.0
			bss	111096	111096	0	0.0
			rodata	95784	95784	0	0.0
			text	584688	584688	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	793086	793086	0	0.0
			bss	112508	112508	0	0.0
			rodata	91072	91072	0	0.0
			text	515112	515112	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497463	497463	0	0.0
			bss	51820	51820	0	0.0
			rodata	45852	45852	0	0.0
			text	339492	339492	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	871671	871671	0	0.0
			bss	111008	111008	0	0.0
			rodata	97136	97136	0	0.0
			text	588088	588088	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	864943	864943	0	0.0
			bss	110888	110888	0	0.0
			rodata	95272	95272	0	0.0
			text	583316	583316	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	779939	779939	0	0.0
			bss	109696	109696	0	0.0
			rodata	73792	73792	0	0.0
			text	521948	521948	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	694966	694966	0	0.0
			bss	110680	110680	0	0.0
			rodata	68432	68432	0	0.0
			text	442548	442548	0	0.0
p6	all-clusters-app	default	(read/write)	2348048	2348048	0	0.0
			.bss	107676	107676	0	0.0
			.data	2464	2464	0	0.0
			.heap	923200	923200	0	0.0
			.text	1306312	1306312	0	0.0
	light-app	default	(read/write)	2283224	2283224	0	0.0
			.bss	98616	98616	0	0.0
			.data	2336	2336	0	0.0
			.heap	932392	932392	0	0.0
			.text	1241488	1241488	0	0.0
	lock-app	default	(read/write)	2259720	2259720	0	0.0
			.bss	97496	97496	0	0.0
			.data	2296	2296	0	0.0
			.heap	933552	933552	0	0.0
			.text	1217984	1217984	0	0.0
qpg	lighting-app	qpg6100+debug	(read only)	513576	513576	0	0.0
			(read/write)	122332	122332	0	0.0
			.bss	80352	80352	0	0.0
			.data	964	964	0	0.0
			.text	508256	508256	0	0.0
	lock-app	qpg6100+debug	(read only)	487384	487384	0	0.0
			(read/write)	122336	122336	0	0.0
			.bss	79488	79488	0	0.0
			.data	920	920	0	0.0
			.text	482064	482064	0	0.0
	persistent-storage-app	qpg6100+debug	(read only)	108224	108224	0	0.0
			(read/write)	122332	122332	0	0.0
			.bss	36696	36696	0	0.0
			.data	292	292	0	0.0
			.text	102904	102904	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	798414	798414	0	0.0
			bss	80412	80412	0	0.0
			noinit	37160	37160	0	0.0
			text	558044	558044	0	0.0