[IM] Wildcard read and chunking #11304

erjiaqing · 2021-11-02T05:08:07Z

Problem

We need support wildcard read and chunking

Change overview

Update Report::Engine to use PathIterator for emitting chunking messages.

Testing

Adds TestReadWildcard and TestReadChunking for test these features
TestReadChunking reads several large mocked attributes to trigger chunking features.

src/app/AttributePathParams.h

src/app/PathIterator.h

src/app/PathIterator.cpp

src/app/PathIterator.h

src/app/ReadClient.cpp

src/app/reporting/Engine.cpp

github-actions · 2021-11-04T10:55:59Z

PR #11304: Size comparison from ee7682d to fd26a3f

Increases above 0.2%:

platform	target	config	section	`ee7682d`	`fd26a3f`	change	% change
k32w	lock-app	k32w061+debug	.bss	68340	68516	176	0.3
linux	bridge-app	debug+rpc	.bss	35024	35120	96	0.3
			.text	1084805	1087733	2928	0.3
	chip-tool	debug	.bss	18224	18320	96	0.5
	ota-provider-app	debug	.bss	37088	37184	96	0.3
			.text	`1042626`	1046034	3408	0.3
	ota-requestor-app	debug	.text	1106978	1110402	3424	0.3
nrfconnect	lighting-app	nrf52840dk_nrf52840+rpc	rodata	87988	88172	184	0.2
		nrf5340dk_nrf5340_cpuapp	rodata	92064	92256	192	0.2
	lock-app	nrf52840dk_nrf52840	rodata	93180	93368	188	0.2
		nrf5340dk_nrf5340_cpuapp	rodata	88484	88672	188	0.2
	pump-controller-app	nrf52840dk_nrf52840	rodata	93176	93368	192	0.2
telink	lighting-app	tlsr9518adk80d	bss	69100	69276	176	0.3
			text	458206	459440	1234	0.3

Increases (27 builds for efr32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`ee7682d`	`fd26a3f`	change	% change
efr32	lighting-app	BRD4161A	(read only)	737432	737688	256	0.0
			(read/write)	114588	114764	176	0.2
			.bss	112828	113004	176	0.2
			.text	737424	737680	256	0.0
		BRD4161A+rpc	(read only)	726628	726884	256	0.0
			(read/write)	131204	131380	176	0.1
			.bss	129332	129508	176	0.1
			.text	726620	726876	256	0.0
	lock-app	BRD4161A	(read only)	716696	716972	276	0.0
			(read/write)	112404	112576	172	0.2
			.bss	110684	110860	176	0.2
			.text	716688	716964	276	0.0
	window-app	BRD4161A	(read only)	717612	717868	256	0.0
			(read/write)	112724	112900	176	0.2
			.bss	111004	111180	176	0.2
			.text	717604	717860	256	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699648	700856	1208	0.2
			.bss	77824	78000	176	0.2
			.text	614120	615152	1032	0.2
	lock-app	k32w061+debug	(read/write)	591956	593164	1208	0.2
			.bss	68340	68516	176	0.3
			.text	515948	516980	1032	0.2
	shell	k32w061+debug	(read/write)	657904	659100	1196	0.2
			.bss	78992	79168	176	0.2
			.text	571272	572292	1020	0.2
linux	all-clusters-app	debug	(read only)	1697761	1699985	2224	0.1
			(read/write)	119696	119792	96	0.1
			.bss	51120	51216	96	0.2
			.text	1423874	`1426802`	2928	0.2
	bridge-app	debug+rpc	(read only)	1292477	`1294701`	2224	0.2
			(read/write)	69320	69416	96	0.1
			.bss	35024	35120	96	0.3
			.text	1084805	1087733	2928	0.3
	chip-tool	debug	(read/write)	125888	125984	96	0.1
			.bss	18224	18320	96	0.5
	lighting-app	debug+rpc	(read only)	`1553505`	`1555729`	2224	0.1
			(read/write)	102288	102384	96	0.1
			.bss	40664	40760	96	0.2
			.text	1289474	1292402	2928	0.2
	ota-provider-app	debug	(read only)	1251761	1254465	2704	0.2
			(read/write)	67488	67584	96	0.1
			.bss	37088	37184	96	0.3
			.text	`1042626`	1046034	3408	0.3
	ota-requestor-app	debug	(read only)	`1329497`	1332185	2688	0.2
			(read/write)	76744	76840	96	0.1
			.bss	45216	45312	96	0.2
			.text	1106978	1110402	3424	0.3
	shell	debug	(read only)	786641	786657	16	0.0
			.text	607314	607330	16	0.0
	tv-app	debug	(read only)	`1817113`	1819337	2224	0.1
			(read/write)	289912	290008	96	0.0
			.bss	222736	222832	96	0.0
			.text	1518786	1521714	2928	0.2
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861623	862851	1228	0.1
			bss	111288	111464	176	0.2
			rodata	96808	96996	188	0.2
			text	577912	578768	856	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	824003	825227	1224	0.1
			bss	107640	107816	176	0.2
			rodata	87988	88172	184	0.2
			text	552100	552952	852	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	786662	787894	1232	0.2
			bss	112664	112840	176	0.2
			rodata	92064	92256	192	0.2
			text	507372	508220	848	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	838331	839559	1228	0.1
			bss	110324	110500	176	0.2
			rodata	93180	93368	188	0.2
			text	559388	560244	856	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	763626	764854	1228	0.2
			bss	111732	111908	176	0.2
			rodata	88484	88672	188	0.2
			text	488940	489788	848	0.2
	pump-app	nrf52840dk_nrf52840	(read/write)	844439	845667	1228	0.1
			bss	110460	110636	176	0.2
			rodata	94888	95076	188	0.2
			text	563568	564424	856	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838183	839431	1248	0.1
			bss	110360	110536	176	0.2
			rodata	93176	93368	192	0.2
			text	559124	559980	856	0.2
p6	all-clusters-app	default	(read/write)	2301080	2301336	256	0.0
			.bss	107880	108056	176	0.2
			.text	1259344	1259600	256	0.0
	lock-app	default	(read/write)	2213928	2214208	280	0.0
			.bss	95680	95856	176	0.2
			.text	1172192	`1172472`	280	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490932	491688	756	0.2
			.bss	50968	51088	120	0.2
			.text	485612	486368	756	0.2
	lock-app	qpg6100+debug	(read only)	467280	468012	732	0.2
			.bss	49912	50032	120	0.2
			.text	461960	462692	732	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	663086	664694	1608	0.2
			bss	69100	69276	176	0.3
			text	458206	459440	1234	0.3

Decreases (9 builds for linux, p6)

platform	target	config	section	`ee7682d`	`fd26a3f`	change	% change
linux	all-clusters-app	debug	.rodata	140469	139765	-704	-0.5
	bridge-app	debug+rpc	.rodata	111780	111076	-704	-0.6
	chip-tool	debug	(read only)	4429253	4420053	-9200	-0.2
			.rodata	226992	226288	-704	-0.3
			.text	3933941	`3925445`	-8496	-0.2
	lighting-app	debug+rpc	.rodata	130449	129745	-704	-0.5
	ota-provider-app	debug	.rodata	113032	112328	-704	-0.6
	ota-requestor-app	debug	.rodata	124464	123728	-736	-0.6
	tv-app	debug	.rodata	156040	155336	-704	-0.5
p6	all-clusters-app	default	.heap	922944	922768	-176	-0.0
	lock-app	default	.heap	935272	935096	-176	-0.0

Full report (31 builds for efr32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`ee7682d`	`fd26a3f`	change	% change
efr32	lighting-app	BRD4161A	(read only)	737432	737688	256	0.0
			(read/write)	114588	114764	176	0.2
			.bss	112828	113004	176	0.2
			.data	1756	1756	0	0.0
			.text	737424	737680	256	0.0
		BRD4161A+rpc	(read only)	726628	726884	256	0.0
			(read/write)	131204	131380	176	0.1
			.bss	129332	129508	176	0.1
			.data	1872	1872	0	0.0
			.text	726620	726876	256	0.0
	lock-app	BRD4161A	(read only)	716696	716972	276	0.0
			(read/write)	112404	112576	172	0.2
			.bss	110684	110860	176	0.2
			.data	1716	1716	0	0.0
			.text	716688	716964	276	0.0
	window-app	BRD4161A	(read only)	717612	717868	256	0.0
			(read/write)	112724	112900	176	0.2
			.bss	111004	111180	176	0.2
			.data	1720	1720	0	0.0
			.text	717604	717860	256	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699648	700856	1208	0.2
			.bss	77824	78000	176	0.2
			.data	1904	1904	0	0.0
			.text	614120	615152	1032	0.2
	lock-app	k32w061+debug	(read/write)	591956	593164	1208	0.2
			.bss	68340	68516	176	0.3
			.data	1868	1868	0	0.0
			.text	515948	516980	1032	0.2
	shell	k32w061+debug	(read/write)	657904	659100	1196	0.2
			.bss	78992	79168	176	0.2
			.data	1840	1840	0	0.0
			.text	571272	572292	1020	0.2
linux	all-clusters-app	debug	(read only)	1697761	1699985	2224	0.1
			(read/write)	119696	119792	96	0.1
			.bss	51120	51216	96	0.2
			.data	1042	1042	0	0.0
			.data.rel.ro	62272	62272	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	140469	139765	-704	-0.5
			.text	1423874	`1426802`	2928	0.2
	bridge-app	debug+rpc	(read only)	1292477	`1294701`	2224	0.2
			(read/write)	69320	69416	96	0.1
			.bss	35024	35120	96	0.3
			.data	1568	1568	0	0.0
			.data.rel.ro	27768	27768	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	111780	111076	-704	-0.6
			.text	1084805	1087733	2928	0.3
	chip-tool	debug	(read only)	4429253	4420053	-9200	-0.2
			(read/write)	125888	125984	96	0.1
			.bss	18224	18320	96	0.5
			.data	2224	2224	0	0.0
			.data.rel.ro	100032	100032	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	226992	226288	-704	-0.3
			.text	3933941	`3925445`	-8496	-0.2
	lighting-app	debug+rpc	(read only)	`1553505`	`1555729`	2224	0.1
			(read/write)	102288	102384	96	0.1
			.bss	40664	40760	96	0.2
			.data	1170	1170	0	0.0
			.data.rel.ro	55168	55168	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	130449	129745	-704	-0.5
			.text	1289474	1292402	2928	0.2
	ota-provider-app	debug	(read only)	1251761	1254465	2704	0.2
			(read/write)	67488	67584	96	0.1
			.bss	37088	37184	96	0.3
			.data	752	752	0	0.0
			.data.rel.ro	24568	24568	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	113032	112328	-704	-0.6
			.text	`1042626`	1046034	3408	0.3
	ota-requestor-app	debug	(read only)	`1329497`	1332185	2688	0.2
			(read/write)	76744	76840	96	0.1
			.bss	45216	45312	96	0.2
			.data	816	816	0	0.0
			.data.rel.ro	25576	25576	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	124464	123728	-736	-0.6
			.text	1106978	1110402	3424	0.3
	shell	debug	(read only)	786641	786657	16	0.0
			(read/write)	57600	57600	0	0.0
			.bss	16040	16040	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36816	36816	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	77839	77839	0	0.0
			.text	607314	607330	16	0.0
	tv-app	debug	(read only)	`1817113`	1819337	2224	0.1
			(read/write)	289912	290008	96	0.0
			.bss	222736	222832	96	0.0
			.data	2704	2704	0	0.0
			.data.rel.ro	58824	58824	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	156040	155336	-704	-0.5
			.text	1518786	1521714	2928	0.2
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861623	862851	1228	0.1
			bss	111288	111464	176	0.2
			rodata	96808	96996	188	0.2
			text	577912	578768	856	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	824003	825227	1224	0.1
			bss	107640	107816	176	0.2
			rodata	87988	88172	184	0.2
			text	552100	552952	852	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	786662	787894	1232	0.2
			bss	112664	112840	176	0.2
			rodata	92064	92256	192	0.2
			text	507372	508220	848	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	838331	839559	1228	0.1
			bss	110324	110500	176	0.2
			rodata	93180	93368	188	0.2
			text	559388	560244	856	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	763626	764854	1228	0.2
			bss	111732	111908	176	0.2
			rodata	88484	88672	188	0.2
			text	488940	489788	848	0.2
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844439	845667	1228	0.1
			bss	110460	110636	176	0.2
			rodata	94888	95076	188	0.2
			text	563568	564424	856	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838183	839431	1248	0.1
			bss	110360	110536	176	0.2
			rodata	93176	93368	192	0.2
			text	559124	559980	856	0.2
	shell	nrf52840dk_nrf52840	(read/write)	775975	775975	0	0.0
			bss	109080	109080	0	0.0
			rodata	72412	72412	0	0.0
			text	519904	519904	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691010	691010	0	0.0
			bss	110060	110060	0	0.0
			rodata	67052	67052	0	0.0
			text	440496	440496	0	0.0
p6	all-clusters-app	default	(read/write)	2301080	2301336	256	0.0
			.bss	107880	108056	176	0.2
			.data	2520	2520	0	0.0
			.heap	922944	922768	-176	-0.0
			.text	1259344	1259600	256	0.0
	lock-app	default	(read/write)	2213928	2214208	280	0.0
			.bss	95680	95856	176	0.2
			.data	2392	2392	0	0.0
			.heap	935272	935096	-176	-0.0
			.text	1172192	`1172472`	280	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490932	491688	756	0.2
			(read/write)	114140	114140	0	0.0
			.bss	50968	51088	120	0.2
			.data	1004	1004	0	0.0
			.text	485612	486368	756	0.2
	lock-app	qpg6100+debug	(read only)	467280	468012	732	0.2
			(read/write)	114144	114144	0	0.0
			.bss	49912	50032	120	0.2
			.data	960	960	0	0.0
			.text	461960	462692	732	0.2
	persistent-storage-app	qpg6100+debug	(read only)	153212	153212	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	18920	18920	0	0.0
			.data	356	356	0	0.0
			.text	147892	147892	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663086	664694	1608	0.2
			bss	69100	69276	176	0.3
			noinit	33216	33216	0	0.0
			text	458206	459440	1234	0.3

todo · 2021-11-09T08:31:05Z

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

connectedhomeip/src/app/AttributePathExpandIterator.cpp

Lines 34 to 44 in 1cfc55d

    
           // TODO: Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with 
        
           // dependencies on generated files, so we don't have to re-declare things here. 
        
           // Note: Some of the generated files that depended by af.h are gen_config.h and gen_tokens.h 
        
           typedef uint8_t EmberAfClusterMask; 
        
           extern uint16_t emberAfEndpointCount(void); 
        
           extern uint16_t emberAfIndexFromEndpoint(EndpointId endpoint); 
        
           extern uint8_t emberAfClusterCount(EndpointId endpoint, bool server); 
        
           extern uint16_t emberAfGetServerAttributeCount(chip::EndpointId endpoint, chip::ClusterId cluster); 
        
           extern uint16_t emberAfGetServerAttributeIndexByAttributeId(chip::EndpointId endpoint, chip::ClusterId cluster, 
        
                                                                       chip::AttributeId attributeId);

This comment was generated by todo based on a `TODO` comment in `1cfc55d` in #11304. cc @erjiaqing.

todo · 2021-11-09T08:31:08Z

The ClusterInfo may support a group id, the iterator should be able to call group data provider to expand the group id.

connectedhomeip/src/app/AttributePathExpandIterator.h

Lines 67 to 77 in 1cfc55d

    
            * TODO: The ClusterInfo may support a group id, the iterator should be able to call group data provider to expand the group id. 
        
            */ 
        
           class AttributePathExpandIterator 
        
           { 
        
           public: 
        
               AttributePathExpandIterator(ClusterInfo * aClusterInfo); 
        
               /** 
        
                * Proceed the iterator to the next attribute path in the given cluster info. 
        
                * 
        
                * Returns false if AttributePathExpandIterator has exhausted all paths in the given ClusterInfo list.

This comment was generated by todo based on a `TODO` comment in `1cfc55d` in #11304. cc @erjiaqing.

todo · 2021-11-09T08:31:11Z

Optimize this implementation by making the iterator only emit intersected paths.

connectedhomeip/src/app/reporting/Engine.cpp

Lines 111 to 121 in 1cfc55d

    
           // TODO: Optimize this implementation by making the iterator only emit intersected paths. 
        
           for (auto dirtyPath = mpGlobalDirtySet; dirtyPath != nullptr; dirtyPath = dirtyPath->mpNext) 
        
           { 
        
               if (dirtyPath->IsPathIncluded(path)) 
        
               { 
        
                   concretePathDirty = true; 
        
                   break; 
        
               } 
        
           } 
        
           if (!concretePathDirty)

This comment was generated by todo based on a `TODO` comment in `1cfc55d` in #11304. cc @erjiaqing.

todo · 2021-11-09T08:49:04Z

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

connectedhomeip/src/app/AttributePathExpandIterator.cpp

Lines 34 to 44 in 4aa62af

    
           // TODO: Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with 
        
           // dependencies on generated files, so we don't have to re-declare things here. 
        
           // Note: Some of the generated files that depended by af.h are gen_config.h and gen_tokens.h 
        
           typedef uint8_t EmberAfClusterMask; 
        
           extern uint16_t emberAfEndpointCount(void); 
        
           extern uint16_t emberAfIndexFromEndpoint(EndpointId endpoint); 
        
           extern uint8_t emberAfClusterCount(EndpointId endpoint, bool server); 
        
           extern uint16_t emberAfGetServerAttributeCount(chip::EndpointId endpoint, chip::ClusterId cluster); 
        
           extern uint16_t emberAfGetServerAttributeIndexByAttributeId(chip::EndpointId endpoint, chip::ClusterId cluster, 
        
                                                                       chip::AttributeId attributeId);

This comment was generated by todo based on a `TODO` comment in `4aa62af` in #11304. cc @erjiaqing.

github-actions · 2021-11-15T03:53:41Z

PR #11304: Size comparison from 507ba15 to afae79c

Increases above 0.2%:

platform	target	config	section	`507ba15`	afae79cc	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	57088	57232	144	0.3
		m5stack	.dram0.bss	62184	62328	144	0.2
linux	bridge-app	debug+rpc	(read only)	1312741	1316325	3584	0.3
			.bss	42896	43024	128	0.3
			.text	`1103909`	1107333	3424	0.3
	chip-tool	debug	.bss	41192	41320	128	0.3
	lighting-app	debug+rpc	.bss	48080	48208	128	0.3
			.text	1317746	1321170	3424	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271385	4048	0.3
			.bss	44512	44640	128	0.3
			.text	1057106	`1061026`	3920	0.4
	ota-requestor-app	debug	(read only)	`1352009`	`1356073`	4064	0.3
			.bss	46976	47104	128	0.3
			.text	1128402	`1132306`	3904	0.3

Increases (25 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`507ba15`	afae79cc	change	% change
efr32	lighting-app	BRD4161A	(read only)	750088	751064	976	0.1
			(read/write)	115940	116084	144	0.1
			.bss	114140	114284	144	0.1
			.text	750080	751056	976	0.1
		BRD4161A+rpc	(read only)	737636	738620	984	0.1
			(read/write)	132568	132712	144	0.1
			.bss	130644	130788	144	0.1
			.text	737628	738612	984	0.1
	lock-app	BRD4161A	(read only)	726752	727720	968	0.1
			(read/write)	113724	113868	144	0.1
			.bss	111964	112108	144	0.1
			.text	726744	727712	968	0.1
	window-app	BRD4161A	(read only)	727744	728712	968	0.1
			(read/write)	114044	114188	144	0.1
			.bss	112284	112428	144	0.1
			.text	727736	728704	968	0.1
esp32	all-clusters-app	c3devkit	(read only)	826956	828116	1160	0.1
			(read/write)	1224466	1224650	184	0.0
			.dram0.bss	57088	57232	144	0.3
			.flash.rodata	168040	168080	40	0.0
			.flash.text	826956	828116	1160	0.1
		m5stack	(read only)	897631	898635	1004	0.1
			(read/write)	422624	422808	184	0.0
			.dram0.bss	62184	62328	144	0.2
			.flash.rodata	195060	195100	40	0.0
			.flash.text	892247	893251	1004	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	702540	703512	972	0.1
			.bss	77508	77652	144	0.2
			.text	617324	618152	828	0.1
	lock-app	k32w061+debug	(read/write)	593548	594536	988	0.2
			.bss	68028	68172	144	0.2
			.text	517844	518688	844	0.2
	shell	k32w061+debug	(read/write)	659232	660208	976	0.1
			.bss	78820	78964	144	0.2
			.text	572768	573600	832	0.1
linux	all-clusters-app	debug	(read only)	1722337	1725921	3584	0.2
			(read/write)	126816	126944	128	0.1
			.bss	57776	57904	128	0.2
			.rodata	140277	140437	160	0.1
			.text	1447842	1451266	3424	0.2
	bridge-app	debug+rpc	(read only)	1312741	1316325	3584	0.3
			(read/write)	77424	77552	128	0.2
			.bss	42896	43024	128	0.3
			.rodata	111860	112020	160	0.1
			.text	`1103909`	1107333	3424	0.3
	chip-tool	debug	(read only)	4921493	4925525	4032	0.1
			(read/write)	167208	167336	128	0.1
			.bss	41192	41320	128	0.3
			.rodata	268242	268370	128	0.0
			.text	4343605	4347509	3904	0.1
	lighting-app	debug+rpc	(read only)	`1582281`	1585833	3552	0.2
			(read/write)	110192	110320	128	0.1
			.bss	48080	48208	128	0.3
			.rodata	129841	129969	128	0.1
			.text	1317746	1321170	3424	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271385	4048	0.3
			(read/write)	75176	75304	128	0.2
			.bss	44512	44640	128	0.3
			.rodata	113383	113511	128	0.1
			.text	1057106	`1061026`	3920	0.4
	ota-requestor-app	debug	(read only)	`1352009`	`1356073`	4064	0.3
			(read/write)	78944	79072	128	0.2
			.bss	46976	47104	128	0.3
			.rodata	124208	124368	160	0.1
			.text	1128402	`1132306`	3904	0.3
	shell	debug	(read only)	789081	789097	16	0.0
			.text	609282	609298	16	0.0
	tv-app	debug	(read only)	1858569	1862137	3568	0.2
			(read/write)	407896	408024	128	0.0
			.bss	339752	339880	128	0.0
			.rodata	157069	157197	128	0.1
			.text	1556418	1559858	3440	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2292200	2293472	1272	0.1
			.bss	179692	179836	144	0.1
			.text	1254800	`1256072`	1272	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2274688	2275896	1208	0.1
			.bss	172556	172700	144	0.1
			.text	`1237288`	1238496	1208	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2250128	2251336	1208	0.1
			.bss	171436	171580	144	0.1
			.text	1212728	`1213936`	1208	0.1
p6	all-clusters-app	default	(read/write)	2301232	2302208	976	0.0
			.bss	112680	112824	144	0.1
			.text	1259496	`1260472`	976	0.1
	lock-app	default	(read/write)	2214704	2215672	968	0.0
			.bss	101296	101440	144	0.1
			.text	1172968	1173936	968	0.1
qpg	lighting-app	qpg6100+debug	(read only)	494216	494928	712	0.1
			.bss	50640	50736	96	0.2
			.text	488896	489608	712	0.1
	lock-app	qpg6100+debug	(read only)	468752	469480	728	0.2
			.bss	49576	49672	96	0.2
			.text	463432	464160	728	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	667854	669198	1344	0.2
			bss	69320	69464	144	0.2
			text	462372	463522	1150	0.2

Decreases (5 builds for mbed, p6)

platform	target	config	section	`507ba15`	afae79cc	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851536	851392	-144	-0.0
	lighting-app	CY8CPROTO_062_4343W+release	.heap	858312	858168	-144	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.heap	859440	859296	-144	-0.0
p6	all-clusters-app	default	.heap	918144	918000	-144	-0.0
	lock-app	default	.heap	929648	929504	-144	-0.0

Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`507ba15`	afae79cc	change	% change
efr32	lighting-app	BRD4161A	(read only)	750088	751064	976	0.1
			(read/write)	115940	116084	144	0.1
			.bss	114140	114284	144	0.1
			.data	1800	1800	0	0.0
			.text	750080	751056	976	0.1
		BRD4161A+rpc	(read only)	737636	738620	984	0.1
			(read/write)	132568	132712	144	0.1
			.bss	130644	130788	144	0.1
			.data	1924	1924	0	0.0
			.text	737628	738612	984	0.1
	lock-app	BRD4161A	(read only)	726752	727720	968	0.1
			(read/write)	113724	113868	144	0.1
			.bss	111964	112108	144	0.1
			.data	1756	1756	0	0.0
			.text	726744	727712	968	0.1
	window-app	BRD4161A	(read only)	727744	728712	968	0.1
			(read/write)	114044	114188	144	0.1
			.bss	112284	112428	144	0.1
			.data	1760	1760	0	0.0
			.text	727736	728704	968	0.1
esp32	all-clusters-app	c3devkit	(read only)	826956	828116	1160	0.1
			(read/write)	1224466	1224650	184	0.0
			.dram0.bss	57088	57232	144	0.3
			.dram0.data	14092	14092	0	0.0
			.flash.rodata	168040	168080	40	0.0
			.flash.text	826956	828116	1160	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	897631	898635	1004	0.1
			(read/write)	422624	422808	184	0.0
			.dram0.bss	62184	62328	144	0.2
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	195060	195100	40	0.0
			.flash.text	892247	893251	1004	0.1
			.iram0.text	122987	122987	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	702540	703512	972	0.1
			.bss	77508	77652	144	0.2
			.data	1908	1908	0	0.0
			.text	617324	618152	828	0.1
	lock-app	k32w061+debug	(read/write)	593548	594536	988	0.2
			.bss	68028	68172	144	0.2
			.data	1876	1876	0	0.0
			.text	517844	518688	844	0.2
	shell	k32w061+debug	(read/write)	659232	660208	976	0.1
			.bss	78820	78964	144	0.2
			.data	1844	1844	0	0.0
			.text	572768	573600	832	0.1
linux	all-clusters-app	debug	(read only)	1722337	1725921	3584	0.2
			(read/write)	126816	126944	128	0.1
			.bss	57776	57904	128	0.2
			.data	1042	1042	0	0.0
			.data.rel.ro	62720	62720	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	140277	140437	160	0.1
			.text	1447842	1451266	3424	0.2
	bridge-app	debug+rpc	(read only)	1312741	1316325	3584	0.3
			(read/write)	77424	77552	128	0.2
			.bss	42896	43024	128	0.3
			.data	1568	1568	0	0.0
			.data.rel.ro	27960	27960	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111860	112020	160	0.1
			.text	`1103909`	1107333	3424	0.3
	chip-tool	debug	(read only)	4921493	4925525	4032	0.1
			(read/write)	167208	167336	128	0.1
			.bss	41192	41320	128	0.3
			.data	2272	2272	0	0.0
			.data.rel.ro	118256	118256	0	0.0
			.dynamic	592	592	0	0.0
			.got	4416	4416	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	268242	268370	128	0.0
			.text	4343605	4347509	3904	0.1
	lighting-app	debug+rpc	(read only)	`1582281`	1585833	3552	0.2
			(read/write)	110192	110320	128	0.1
			.bss	48080	48208	128	0.3
			.data	1234	1234	0	0.0
			.data.rel.ro	55552	55552	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	129841	129969	128	0.1
			.text	1317746	1321170	3424	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271385	4048	0.3
			(read/write)	75176	75304	128	0.2
			.bss	44512	44640	128	0.3
			.data	784	784	0	0.0
			.data.rel.ro	24776	24776	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113383	113511	128	0.1
			.text	1057106	`1061026`	3920	0.4
	ota-requestor-app	debug	(read only)	`1352009`	`1356073`	4064	0.3
			(read/write)	78944	79072	128	0.2
			.bss	46976	47104	128	0.3
			.data	848	848	0	0.0
			.data.rel.ro	26040	26040	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	124208	124368	160	0.1
			.text	1128402	`1132306`	3904	0.3
	shell	debug	(read only)	789081	789097	16	0.0
			(read/write)	65064	65064	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36928	36928	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	77903	77903	0	0.0
			.text	609282	609298	16	0.0
	tv-app	debug	(read only)	1858569	1862137	3568	0.2
			(read/write)	407896	408024	128	0.0
			.bss	339752	339880	128	0.0
			.data	2768	2768	0	0.0
			.data.rel.ro	59696	59696	0	0.0
			.dynamic	592	592	0	0.0
			.got	4432	4432	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	157069	157197	128	0.1
			.text	1556418	1559858	3440	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2292200	2293472	1272	0.1
			.bss	179692	179836	144	0.1
			.data	5216	5216	0	0.0
			.heap	851536	851392	-144	-0.0
			.text	1254800	`1256072`	1272	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2274688	2275896	1208	0.1
			.bss	172556	172700	144	0.1
			.data	5576	5576	0	0.0
			.heap	858312	858168	-144	-0.0
			.text	`1237288`	1238496	1208	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2250128	2251336	1208	0.1
			.bss	171436	171580	144	0.1
			.data	5568	5568	0	0.0
			.heap	859440	859296	-144	-0.0
			.text	1212728	`1213936`	1208	0.1
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048376	2048376	0	0.0
			.bss	155912	155912	0	0.0
			.data	4968	4968	0	0.0
			.heap	875568	875568	0	0.0
			.text	1010976	1010976	0	0.0
p6	all-clusters-app	default	(read/write)	2301232	2302208	976	0.0
			.bss	112680	112824	144	0.1
			.data	2520	2520	0	0.0
			.heap	918144	918000	-144	-0.0
			.text	1259496	`1260472`	976	0.1
	lock-app	default	(read/write)	2214704	2215672	968	0.0
			.bss	101296	101440	144	0.1
			.data	2400	2400	0	0.0
			.heap	929648	929504	-144	-0.0
			.text	1172968	1173936	968	0.1
qpg	lighting-app	qpg6100+debug	(read only)	494216	494928	712	0.1
			(read/write)	114144	114144	0	0.0
			.bss	50640	50736	96	0.2
			.data	1008	1008	0	0.0
			.text	488896	489608	712	0.1
	lock-app	qpg6100+debug	(read only)	468752	469480	728	0.2
			(read/write)	114140	114140	0	0.0
			.bss	49576	49672	96	0.2
			.data	964	964	0	0.0
			.text	463432	464160	728	0.2
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	667854	669198	1344	0.2
			bss	69320	69464	144	0.2
			noinit	33216	33216	0	0.0
			text	462372	463522	1150	0.2

github-actions · 2021-11-15T05:24:32Z

PR #11304: Size comparison from 5623978 to d419026

Increases above 0.2%:

platform	target	config	section	`5623978`	`d419026`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	57088	57232	144	0.3
		m5stack	.dram0.bss	62184	62328	144	0.2
linux	bridge-app	debug+rpc	(read only)	1312741	1316357	3616	0.3
			.bss	42896	43024	128	0.3
			.text	`1103909`	1107365	3456	0.3
	chip-tool	debug	.bss	41192	41320	128	0.3
	lighting-app	debug+rpc	.bss	48080	48208	128	0.3
			.text	1317746	1321202	3456	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271417	4080	0.3
			.bss	44512	44640	128	0.3
			.text	1057106	`1061058`	3952	0.4
	ota-requestor-app	debug	(read only)	`1352009`	1356105	4096	0.3
			.bss	46976	47104	128	0.3
			.text	1128402	`1132338`	3936	0.3
telink	lighting-app	tlsr9518adk80d	text	462372	463540	1168	0.3

Increases (25 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`5623978`	`d419026`	change	% change
efr32	lighting-app	BRD4161A	(read only)	750088	751080	992	0.1
			(read/write)	115940	116084	144	0.1
			.bss	114140	114284	144	0.1
			.text	750080	751072	992	0.1
		BRD4161A+rpc	(read only)	737636	738636	1000	0.1
			(read/write)	132568	132712	144	0.1
			.bss	130644	130788	144	0.1
			.text	737628	738628	1000	0.1
	lock-app	BRD4161A	(read only)	726752	727736	984	0.1
			(read/write)	113724	113868	144	0.1
			.bss	111964	112108	144	0.1
			.text	726744	727728	984	0.1
	window-app	BRD4161A	(read only)	727744	728728	984	0.1
			(read/write)	114044	114188	144	0.1
			.bss	112284	112428	144	0.1
			.text	727736	728720	984	0.1
esp32	all-clusters-app	c3devkit	(read only)	826956	828134	1178	0.1
			(read/write)	1224466	1224650	184	0.0
			.dram0.bss	57088	57232	144	0.3
			.flash.rodata	168040	168080	40	0.0
			.flash.text	826956	828134	1178	0.1
		m5stack	(read only)	897631	898651	1020	0.1
			(read/write)	422624	422808	184	0.0
			.dram0.bss	62184	62328	144	0.2
			.flash.rodata	195060	195100	40	0.0
			.flash.text	892247	893267	1020	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	702540	703528	988	0.1
			.bss	77508	77652	144	0.2
			.text	617324	618168	844	0.1
	lock-app	k32w061+debug	(read/write)	593548	594552	1004	0.2
			.bss	68028	68172	144	0.2
			.text	517844	518704	860	0.2
	shell	k32w061+debug	(read/write)	659232	660224	992	0.2
			.bss	78820	78964	144	0.2
			.text	572768	573616	848	0.1
linux	all-clusters-app	debug	(read only)	1722337	`1725953`	3616	0.2
			(read/write)	126816	126944	128	0.1
			.bss	57776	57904	128	0.2
			.rodata	140277	140437	160	0.1
			.text	1447842	1451298	3456	0.2
	bridge-app	debug+rpc	(read only)	1312741	1316357	3616	0.3
			(read/write)	77424	77552	128	0.2
			.bss	42896	43024	128	0.3
			.rodata	111860	112020	160	0.1
			.text	`1103909`	1107365	3456	0.3
	chip-tool	debug	(read only)	4921493	4925557	4064	0.1
			(read/write)	167208	167336	128	0.1
			.bss	41192	41320	128	0.3
			.rodata	268242	268370	128	0.0
			.text	4343605	4347541	3936	0.1
	lighting-app	debug+rpc	(read only)	`1582281`	1585865	3584	0.2
			(read/write)	110192	110320	128	0.1
			.bss	48080	48208	128	0.3
			.rodata	129841	129969	128	0.1
			.text	1317746	1321202	3456	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271417	4080	0.3
			(read/write)	75176	75304	128	0.2
			.bss	44512	44640	128	0.3
			.rodata	113383	113511	128	0.1
			.text	1057106	`1061058`	3952	0.4
	ota-requestor-app	debug	(read only)	`1352009`	1356105	4096	0.3
			(read/write)	78944	79072	128	0.2
			.bss	46976	47104	128	0.3
			.rodata	124208	124368	160	0.1
			.text	1128402	`1132338`	3936	0.3
	shell	debug	(read only)	789081	789097	16	0.0
			.text	609282	609298	16	0.0
	tv-app	debug	(read only)	1858569	1862153	3584	0.2
			(read/write)	407896	408024	128	0.0
			.bss	339752	339880	128	0.0
			.rodata	157069	157197	128	0.1
			.text	1556418	1559874	3456	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2292200	2293472	1272	0.1
			.bss	179692	179836	144	0.1
			.text	1254800	`1256072`	1272	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2274688	2275896	1208	0.1
			.bss	172556	172700	144	0.1
			.text	`1237288`	1238496	1208	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2250128	2251336	1208	0.1
			.bss	171436	171580	144	0.1
			.text	1212728	`1213936`	1208	0.1
p6	all-clusters-app	default	(read/write)	2301232	2302224	992	0.0
			.bss	112680	112824	144	0.1
			.text	1259496	1260488	992	0.1
	lock-app	default	(read/write)	2214704	`2215688`	984	0.0
			.bss	101296	101440	144	0.1
			.text	1172968	1173952	984	0.1
qpg	lighting-app	qpg6100+debug	(read only)	494216	494944	728	0.1
			.bss	50640	50736	96	0.2
			.text	488896	489624	728	0.1
	lock-app	qpg6100+debug	(read only)	468752	469496	744	0.2
			.bss	49576	49672	96	0.2
			.text	463432	464176	744	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	667854	669214	1360	0.2
			bss	69320	69464	144	0.2
			text	462372	463540	1168	0.3

Decreases (5 builds for mbed, p6)

platform	target	config	section	`5623978`	`d419026`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851536	851392	-144	-0.0
	lighting-app	CY8CPROTO_062_4343W+release	.heap	858312	858168	-144	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.heap	859440	859296	-144	-0.0
p6	all-clusters-app	default	.heap	918144	918000	-144	-0.0
	lock-app	default	.heap	929648	929504	-144	-0.0

Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`5623978`	`d419026`	change	% change
efr32	lighting-app	BRD4161A	(read only)	750088	751080	992	0.1
			(read/write)	115940	116084	144	0.1
			.bss	114140	114284	144	0.1
			.data	1800	1800	0	0.0
			.text	750080	751072	992	0.1
		BRD4161A+rpc	(read only)	737636	738636	1000	0.1
			(read/write)	132568	132712	144	0.1
			.bss	130644	130788	144	0.1
			.data	1924	1924	0	0.0
			.text	737628	738628	1000	0.1
	lock-app	BRD4161A	(read only)	726752	727736	984	0.1
			(read/write)	113724	113868	144	0.1
			.bss	111964	112108	144	0.1
			.data	1756	1756	0	0.0
			.text	726744	727728	984	0.1
	window-app	BRD4161A	(read only)	727744	728728	984	0.1
			(read/write)	114044	114188	144	0.1
			.bss	112284	112428	144	0.1
			.data	1760	1760	0	0.0
			.text	727736	728720	984	0.1
esp32	all-clusters-app	c3devkit	(read only)	826956	828134	1178	0.1
			(read/write)	1224466	1224650	184	0.0
			.dram0.bss	57088	57232	144	0.3
			.dram0.data	14092	14092	0	0.0
			.flash.rodata	168040	168080	40	0.0
			.flash.text	826956	828134	1178	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	897631	898651	1020	0.1
			(read/write)	422624	422808	184	0.0
			.dram0.bss	62184	62328	144	0.2
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	195060	195100	40	0.0
			.flash.text	892247	893267	1020	0.1
			.iram0.text	122987	122987	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	702540	703528	988	0.1
			.bss	77508	77652	144	0.2
			.data	1908	1908	0	0.0
			.text	617324	618168	844	0.1
	lock-app	k32w061+debug	(read/write)	593548	594552	1004	0.2
			.bss	68028	68172	144	0.2
			.data	1876	1876	0	0.0
			.text	517844	518704	860	0.2
	shell	k32w061+debug	(read/write)	659232	660224	992	0.2
			.bss	78820	78964	144	0.2
			.data	1844	1844	0	0.0
			.text	572768	573616	848	0.1
linux	all-clusters-app	debug	(read only)	1722337	`1725953`	3616	0.2
			(read/write)	126816	126944	128	0.1
			.bss	57776	57904	128	0.2
			.data	1042	1042	0	0.0
			.data.rel.ro	62720	62720	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	140277	140437	160	0.1
			.text	1447842	1451298	3456	0.2
	bridge-app	debug+rpc	(read only)	1312741	1316357	3616	0.3
			(read/write)	77424	77552	128	0.2
			.bss	42896	43024	128	0.3
			.data	1568	1568	0	0.0
			.data.rel.ro	27960	27960	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111860	112020	160	0.1
			.text	`1103909`	1107365	3456	0.3
	chip-tool	debug	(read only)	4921493	4925557	4064	0.1
			(read/write)	167208	167336	128	0.1
			.bss	41192	41320	128	0.3
			.data	2272	2272	0	0.0
			.data.rel.ro	118256	118256	0	0.0
			.dynamic	592	592	0	0.0
			.got	4416	4416	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	268242	268370	128	0.0
			.text	4343605	4347541	3936	0.1
	lighting-app	debug+rpc	(read only)	`1582281`	1585865	3584	0.2
			(read/write)	110192	110320	128	0.1
			.bss	48080	48208	128	0.3
			.data	1234	1234	0	0.0
			.data.rel.ro	55552	55552	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	129841	129969	128	0.1
			.text	1317746	1321202	3456	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271417	4080	0.3
			(read/write)	75176	75304	128	0.2
			.bss	44512	44640	128	0.3
			.data	784	784	0	0.0
			.data.rel.ro	24776	24776	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113383	113511	128	0.1
			.text	1057106	`1061058`	3952	0.4
	ota-requestor-app	debug	(read only)	`1352009`	1356105	4096	0.3
			(read/write)	78944	79072	128	0.2
			.bss	46976	47104	128	0.3
			.data	848	848	0	0.0
			.data.rel.ro	26040	26040	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	124208	124368	160	0.1
			.text	1128402	`1132338`	3936	0.3
	shell	debug	(read only)	789081	789097	16	0.0
			(read/write)	65064	65064	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36928	36928	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	77903	77903	0	0.0
			.text	609282	609298	16	0.0
	tv-app	debug	(read only)	1858569	1862153	3584	0.2
			(read/write)	407896	408024	128	0.0
			.bss	339752	339880	128	0.0
			.data	2768	2768	0	0.0
			.data.rel.ro	59696	59696	0	0.0
			.dynamic	592	592	0	0.0
			.got	4432	4432	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	157069	157197	128	0.1
			.text	1556418	1559874	3456	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2292200	2293472	1272	0.1
			.bss	179692	179836	144	0.1
			.data	5216	5216	0	0.0
			.heap	851536	851392	-144	-0.0
			.text	1254800	`1256072`	1272	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2274688	2275896	1208	0.1
			.bss	172556	172700	144	0.1
			.data	5576	5576	0	0.0
			.heap	858312	858168	-144	-0.0
			.text	`1237288`	1238496	1208	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2250128	2251336	1208	0.1
			.bss	171436	171580	144	0.1
			.data	5568	5568	0	0.0
			.heap	859440	859296	-144	-0.0
			.text	1212728	`1213936`	1208	0.1
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048376	2048376	0	0.0
			.bss	155912	155912	0	0.0
			.data	4968	4968	0	0.0
			.heap	875568	875568	0	0.0
			.text	1010976	1010976	0	0.0
p6	all-clusters-app	default	(read/write)	2301232	2302224	992	0.0
			.bss	112680	112824	144	0.1
			.data	2520	2520	0	0.0
			.heap	918144	918000	-144	-0.0
			.text	1259496	1260488	992	0.1
	lock-app	default	(read/write)	2214704	`2215688`	984	0.0
			.bss	101296	101440	144	0.1
			.data	2400	2400	0	0.0
			.heap	929648	929504	-144	-0.0
			.text	1172968	1173952	984	0.1
qpg	lighting-app	qpg6100+debug	(read only)	494216	494944	728	0.1
			(read/write)	114144	114144	0	0.0
			.bss	50640	50736	96	0.2
			.data	1008	1008	0	0.0
			.text	488896	489624	728	0.1
	lock-app	qpg6100+debug	(read only)	468752	469496	744	0.2
			(read/write)	114140	114140	0	0.0
			.bss	49576	49672	96	0.2
			.data	964	964	0	0.0
			.text	463432	464176	744	0.2
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	667854	669214	1360	0.2
			bss	69320	69464	144	0.2
			noinit	33216	33216	0	0.0
			text	462372	463540	1168	0.3

github-actions · 2021-11-15T08:33:44Z

PR #11304: Size comparison from 5623978 to 527cd7d

Increases above 0.2%:

platform	target	config	section	`5623978`	`527cd7d`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	57088	57232	144	0.3
		m5stack	.dram0.bss	62184	62328	144	0.2
linux	bridge-app	debug+rpc	(read only)	1312741	1316453	3712	0.3
			.bss	42896	43024	128	0.3
			.text	`1103909`	`1107461`	3552	0.3
	chip-tool	debug	.bss	41192	41320	128	0.3
	lighting-app	debug+rpc	.bss	48080	48208	128	0.3
			.text	1317746	`1321298`	3552	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271545	4208	0.3
			.bss	44512	44640	128	0.3
			.text	1057106	1061154	4048	0.4
	ota-requestor-app	debug	(read only)	`1352009`	1356201	4192	0.3
			.bss	46976	47104	128	0.3
			.text	1128402	1132434	4032	0.4
telink	lighting-app	tlsr9518adk80d	text	462372	463568	1196	0.3

Increases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`5623978`	`527cd7d`	change	% change
efr32	lighting-app	BRD4161A	(read only)	750088	751136	1048	0.1
			(read/write)	115940	116084	144	0.1
			.bss	114140	114284	144	0.1
			.text	750080	751128	1048	0.1
		BRD4161A+rpc	(read only)	737636	738692	1056	0.1
			(read/write)	132568	132712	144	0.1
			.bss	130644	130788	144	0.1
			.text	737628	738684	1056	0.1
	lock-app	BRD4161A	(read only)	726752	727792	1040	0.1
			(read/write)	113724	113868	144	0.1
			.bss	111964	112108	144	0.1
			.text	726744	727784	1040	0.1
	window-app	BRD4161A	(read only)	727744	728784	1040	0.1
			(read/write)	114044	114188	144	0.1
			.bss	112284	112428	144	0.1
			.text	727736	728776	1040	0.1
esp32	all-clusters-app	c3devkit	(read only)	826956	828164	1208	0.1
			(read/write)	1224466	1224674	208	0.0
			.dram0.bss	57088	57232	144	0.3
			.flash.rodata	168040	168104	64	0.0
			.flash.text	826956	828164	1208	0.1
		m5stack	(read only)	897631	898679	1048	0.1
			(read/write)	422624	422832	208	0.0
			.dram0.bss	62184	62328	144	0.2
			.flash.rodata	195060	195124	64	0.0
			.flash.text	892247	893295	1048	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	702540	703584	1044	0.1
			.bss	77508	77652	144	0.2
			.text	617324	618224	900	0.1
	lock-app	k32w061+debug	(read/write)	593548	594608	1060	0.2
			.bss	68028	68172	144	0.2
			.text	517844	518760	916	0.2
	shell	k32w061+debug	(read/write)	659232	660280	1048	0.2
			.bss	78820	78964	144	0.2
			.text	572768	573672	904	0.2
linux	all-clusters-app	debug	(read only)	1722337	1726081	3744	0.2
			(read/write)	126816	126944	128	0.1
			.bss	57776	57904	128	0.2
			.rodata	140277	140469	192	0.1
			.text	1447842	`1451394`	3552	0.2
	bridge-app	debug+rpc	(read only)	1312741	1316453	3712	0.3
			(read/write)	77424	77552	128	0.2
			.bss	42896	43024	128	0.3
			.rodata	111860	112020	160	0.1
			.text	`1103909`	`1107461`	3552	0.3
	chip-tool	debug	(read only)	4921493	4925685	4192	0.1
			(read/write)	167208	167336	128	0.1
			.bss	41192	41320	128	0.3
			.rodata	268242	268402	160	0.1
			.text	4343605	4347637	4032	0.1
	lighting-app	debug+rpc	(read only)	`1582281`	1585993	3712	0.2
			(read/write)	110192	110320	128	0.1
			.bss	48080	48208	128	0.3
			.rodata	129841	130001	160	0.1
			.text	1317746	`1321298`	3552	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271545	4208	0.3
			(read/write)	75176	75304	128	0.2
			.bss	44512	44640	128	0.3
			.rodata	113383	113543	160	0.1
			.text	1057106	1061154	4048	0.4
	ota-requestor-app	debug	(read only)	`1352009`	1356201	4192	0.3
			(read/write)	78944	79072	128	0.2
			.bss	46976	47104	128	0.3
			.rodata	124208	124368	160	0.1
			.text	1128402	1132434	4032	0.4
	shell	debug	(read only)	789081	789097	16	0.0
			.text	609282	609298	16	0.0
	tv-app	debug	(read only)	1858569	1862281	3712	0.2
			(read/write)	407896	408024	128	0.0
			.bss	339752	339880	128	0.0
			.rodata	157069	157229	160	0.1
			.text	1556418	`1559970`	3552	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2292200	`2293496`	1296	0.1
			.bss	179692	179836	144	0.1
			.text	1254800	1256096	1296	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2274688	2275984	1296	0.1
			.bss	172556	172700	144	0.1
			.text	`1237288`	1238584	1296	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2250128	2251424	1296	0.1
			.bss	171436	171580	144	0.1
			.text	1212728	1214024	1296	0.1
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	865175	866259	1084	0.1
			bss	110964	111108	144	0.1
			rodata	97080	97156	76	0.1
			text	581516	582364	848	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	827567	828643	1076	0.1
			bss	107320	107464	144	0.1
			rodata	88272	88340	68	0.1
			text	555688	556536	848	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	790234	791302	1068	0.1
			bss	112340	112484	144	0.1
			rodata	92340	92416	76	0.1
			text	510984	511828	844	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	840199	841255	1056	0.1
			bss	109988	110132	144	0.1
			rodata	93144	93224	80	0.1
			text	561616	562464	848	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	765514	766566	1052	0.1
			bss	111400	111544	144	0.1
			rodata	88452	88528	76	0.1
			text	491176	492024	848	0.2
	pump-app	nrf52840dk_nrf52840	(read/write)	846327	847379	1052	0.1
			bss	110128	110272	144	0.1
			rodata	94856	94932	76	0.1
			text	565800	566648	848	0.1
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	839903	840955	1052	0.1
			bss	110024	110168	144	0.1
			rodata	93104	93180	76	0.1
			text	561236	562084	848	0.2
	shell	nrf52840dk_nrf52840	text	520020	520024	4	0.0
		nrf5340dk_nrf5340_cpuapp	text	440628	440632	4	0.0
p6	all-clusters-app	default	(read/write)	2301232	2302280	1048	0.0
			.bss	112680	112824	144	0.1
			.text	1259496	`1260544`	1048	0.1
	lock-app	default	(read/write)	2214704	`2215744`	1040	0.0
			.bss	101296	101440	144	0.1
			.text	1172968	1174008	1040	0.1
qpg	lighting-app	qpg6100+debug	(read only)	494216	494976	760	0.2
			.bss	50640	50736	96	0.2
			.text	488896	489656	760	0.2
	lock-app	qpg6100+debug	(read only)	468752	469528	776	0.2
			.bss	49576	49672	96	0.2
			.text	463432	464208	776	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	667854	669262	1408	0.2
			bss	69320	69464	144	0.2
			text	462372	463568	1196	0.3

Decreases (5 builds for mbed, p6)

platform	target	config	section	`5623978`	`527cd7d`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851536	851392	-144	-0.0
	lighting-app	CY8CPROTO_062_4343W+release	.heap	858312	858168	-144	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.heap	859440	859296	-144	-0.0
p6	all-clusters-app	default	.heap	918144	918000	-144	-0.0
	lock-app	default	.heap	929648	929504	-144	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`5623978`	`527cd7d`	change	% change
efr32	lighting-app	BRD4161A	(read only)	750088	751136	1048	0.1
			(read/write)	115940	116084	144	0.1
			.bss	114140	114284	144	0.1
			.data	1800	1800	0	0.0
			.text	750080	751128	1048	0.1
		BRD4161A+rpc	(read only)	737636	738692	1056	0.1
			(read/write)	132568	132712	144	0.1
			.bss	130644	130788	144	0.1
			.data	1924	1924	0	0.0
			.text	737628	738684	1056	0.1
	lock-app	BRD4161A	(read only)	726752	727792	1040	0.1
			(read/write)	113724	113868	144	0.1
			.bss	111964	112108	144	0.1
			.data	1756	1756	0	0.0
			.text	726744	727784	1040	0.1
	window-app	BRD4161A	(read only)	727744	728784	1040	0.1
			(read/write)	114044	114188	144	0.1
			.bss	112284	112428	144	0.1
			.data	1760	1760	0	0.0
			.text	727736	728776	1040	0.1
esp32	all-clusters-app	c3devkit	(read only)	826956	828164	1208	0.1
			(read/write)	1224466	1224674	208	0.0
			.dram0.bss	57088	57232	144	0.3
			.dram0.data	14092	14092	0	0.0
			.flash.rodata	168040	168104	64	0.0
			.flash.text	826956	828164	1208	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	897631	898679	1048	0.1
			(read/write)	422624	422832	208	0.0
			.dram0.bss	62184	62328	144	0.2
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	195060	195124	64	0.0
			.flash.text	892247	893295	1048	0.1
			.iram0.text	122987	122987	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	702540	703584	1044	0.1
			.bss	77508	77652	144	0.2
			.data	1908	1908	0	0.0
			.text	617324	618224	900	0.1
	lock-app	k32w061+debug	(read/write)	593548	594608	1060	0.2
			.bss	68028	68172	144	0.2
			.data	1876	1876	0	0.0
			.text	517844	518760	916	0.2
	shell	k32w061+debug	(read/write)	659232	660280	1048	0.2
			.bss	78820	78964	144	0.2
			.data	1844	1844	0	0.0
			.text	572768	573672	904	0.2
linux	all-clusters-app	debug	(read only)	1722337	1726081	3744	0.2
			(read/write)	126816	126944	128	0.1
			.bss	57776	57904	128	0.2
			.data	1042	1042	0	0.0
			.data.rel.ro	62720	62720	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	140277	140469	192	0.1
			.text	1447842	`1451394`	3552	0.2
	bridge-app	debug+rpc	(read only)	1312741	1316453	3712	0.3
			(read/write)	77424	77552	128	0.2
			.bss	42896	43024	128	0.3
			.data	1568	1568	0	0.0
			.data.rel.ro	27960	27960	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111860	112020	160	0.1
			.text	`1103909`	`1107461`	3552	0.3
	chip-tool	debug	(read only)	4921493	4925685	4192	0.1
			(read/write)	167208	167336	128	0.1
			.bss	41192	41320	128	0.3
			.data	2272	2272	0	0.0
			.data.rel.ro	118256	118256	0	0.0
			.dynamic	592	592	0	0.0
			.got	4416	4416	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	268242	268402	160	0.1
			.text	4343605	4347637	4032	0.1
	lighting-app	debug+rpc	(read only)	`1582281`	1585993	3712	0.2
			(read/write)	110192	110320	128	0.1
			.bss	48080	48208	128	0.3
			.data	1234	1234	0	0.0
			.data.rel.ro	55552	55552	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	129841	130001	160	0.1
			.text	1317746	`1321298`	3552	0.3
	ota-provider-app	debug	(read only)	`1267337`	1271545	4208	0.3
			(read/write)	75176	75304	128	0.2
			.bss	44512	44640	128	0.3
			.data	784	784	0	0.0
			.data.rel.ro	24776	24776	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113383	113543	160	0.1
			.text	1057106	1061154	4048	0.4
	ota-requestor-app	debug	(read only)	`1352009`	1356201	4192	0.3
			(read/write)	78944	79072	128	0.2
			.bss	46976	47104	128	0.3
			.data	848	848	0	0.0
			.data.rel.ro	26040	26040	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	124208	124368	160	0.1
			.text	1128402	1132434	4032	0.4
	shell	debug	(read only)	789081	789097	16	0.0
			(read/write)	65064	65064	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36928	36928	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	77903	77903	0	0.0
			.text	609282	609298	16	0.0
	tv-app	debug	(read only)	1858569	1862281	3712	0.2
			(read/write)	407896	408024	128	0.0
			.bss	339752	339880	128	0.0
			.data	2768	2768	0	0.0
			.data.rel.ro	59696	59696	0	0.0
			.dynamic	592	592	0	0.0
			.got	4432	4432	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	157069	157229	160	0.1
			.text	1556418	`1559970`	3552	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2292200	`2293496`	1296	0.1
			.bss	179692	179836	144	0.1
			.data	5216	5216	0	0.0
			.heap	851536	851392	-144	-0.0
			.text	1254800	1256096	1296	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2274688	2275984	1296	0.1
			.bss	172556	172700	144	0.1
			.data	5576	5576	0	0.0
			.heap	858312	858168	-144	-0.0
			.text	`1237288`	1238584	1296	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2250128	2251424	1296	0.1
			.bss	171436	171580	144	0.1
			.data	5568	5568	0	0.0
			.heap	859440	859296	-144	-0.0
			.text	1212728	1214024	1296	0.1
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048376	2048376	0	0.0
			.bss	155912	155912	0	0.0
			.data	4968	4968	0	0.0
			.heap	875568	875568	0	0.0
			.text	1010976	1010976	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	865175	866259	1084	0.1
			bss	110964	111108	144	0.1
			rodata	97080	97156	76	0.1
			text	581516	582364	848	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	827567	828643	1076	0.1
			bss	107320	107464	144	0.1
			rodata	88272	88340	68	0.1
			text	555688	556536	848	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	790234	791302	1068	0.1
			bss	112340	112484	144	0.1
			rodata	92340	92416	76	0.1
			text	510984	511828	844	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	840199	841255	1056	0.1
			bss	109988	110132	144	0.1
			rodata	93144	93224	80	0.1
			text	561616	562464	848	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	765514	766566	1052	0.1
			bss	111400	111544	144	0.1
			rodata	88452	88528	76	0.1
			text	491176	492024	848	0.2
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	846327	847379	1052	0.1
			bss	110128	110272	144	0.1
			rodata	94856	94932	76	0.1
			text	565800	566648	848	0.1
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	839903	840955	1052	0.1
			bss	110024	110168	144	0.1
			rodata	93104	93180	76	0.1
			text	561236	562084	848	0.2
	shell	nrf52840dk_nrf52840	(read/write)	775499	775499	0	0.0
			bss	108736	108736	0	0.0
			rodata	72160	72160	0	0.0
			text	520020	520024	4	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	690554	690554	0	0.0
			bss	109720	109720	0	0.0
			rodata	66804	66804	0	0.0
			text	440628	440632	4	0.0
p6	all-clusters-app	default	(read/write)	2301232	2302280	1048	0.0
			.bss	112680	112824	144	0.1
			.data	2520	2520	0	0.0
			.heap	918144	918000	-144	-0.0
			.text	1259496	`1260544`	1048	0.1
	lock-app	default	(read/write)	2214704	`2215744`	1040	0.0
			.bss	101296	101440	144	0.1
			.data	2400	2400	0	0.0
			.heap	929648	929504	-144	-0.0
			.text	1172968	1174008	1040	0.1
qpg	lighting-app	qpg6100+debug	(read only)	494216	494976	760	0.2
			(read/write)	114144	114144	0	0.0
			.bss	50640	50736	96	0.2
			.data	1008	1008	0	0.0
			.text	488896	489656	760	0.2
	lock-app	qpg6100+debug	(read only)	468752	469528	776	0.2
			(read/write)	114140	114140	0	0.0
			.bss	49576	49672	96	0.2
			.data	964	964	0	0.0
			.text	463432	464208	776	0.2
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	667854	669262	1408	0.2
			bss	69320	69464	144	0.2
			noinit	33216	33216	0	0.0
			text	462372	463568	1196	0.3

erjiaqing · 2021-11-16T01:00:58Z

@bzbarsky-apple @mrjerryjohns ptal

src/app/ClusterInfo.h

src/app/ReadHandler.cpp

src/app/ReadHandler.h

src/app/reporting/Engine.cpp

src/app/tests/TestReadInteraction.cpp

github-actions · 2021-11-16T02:37:18Z

PR #11304: Size comparison from fcf4c33 to 6924534

Increases above 0.2%:

platform	target	config	section	`fcf4c33`	`6924534`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	56512	56656	144	0.3
		m5stack	.dram0.bss	61864	62008	144	0.2
linux	all-clusters-app	debug	.text	1441154	1444786	3632	0.3
	bridge-app	debug+rpc	(read only)	1305125	1308917	3792	0.3
			.bss	42224	42352	128	0.3
			.text	1097461	1101093	3632	0.3
	chip-tool	debug	.bss	40584	40712	128	0.3
	lighting-app	debug+rpc	.bss	47888	48016	128	0.3
			.text	1311314	1314946	3632	0.3
	ota-provider-app	debug	(read only)	1260553	1264889	4336	0.3
			.bss	44832	44960	128	0.3
			.text	1050402	1054578	4176	0.4
	ota-requestor-app	debug	(read only)	1343681	`1348017`	4336	0.3
			.bss	47296	47424	128	0.3
			.text	1120370	1124546	4176	0.4

Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`fcf4c33`	`6924534`	change	% change
efr32	lighting-app	BRD4161A	(read only)	746648	747776	1128	0.2
			(read/write)	115364	115508	144	0.1
			.bss	113564	113708	144	0.1
			.text	746640	747768	1128	0.2
		BRD4161A+rpc	(read only)	734188	735292	1104	0.2
			(read/write)	131992	132136	144	0.1
			.bss	130068	130212	144	0.1
			.text	734180	735284	1104	0.2
	lock-app	BRD4161A	(read only)	723712	724824	1112	0.2
			(read/write)	113148	113292	144	0.1
			.bss	111388	111532	144	0.1
			.text	723704	724816	1112	0.2
	window-app	BRD4161A	(read only)	724704	725816	1112	0.2
			(read/write)	113468	113612	144	0.1
			.bss	111708	111852	144	0.1
			.text	724696	725808	1112	0.2
esp32	all-clusters-app	c3devkit	(read only)	825820	827054	1234	0.1
			(read/write)	1220258	1220474	216	0.0
			.dram0.bss	56512	56656	144	0.3
			.flash.rodata	164408	164480	72	0.0
			.flash.text	825820	827054	1234	0.1
		m5stack	(read only)	896619	897711	1092	0.1
			(read/write)	419580	419780	200	0.0
			.dram0.bss	61864	62008	144	0.2
			.flash.rodata	192380	192436	56	0.0
			.flash.text	891235	892327	1092	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	705032	706124	1092	0.2
			.bss	76988	77132	144	0.2
			.text	620332	621280	948	0.2
	lock-app	k32w061+debug	(read/write)	596448	597540	1092	0.2
			.bss	67500	67644	144	0.2
			.text	521268	522216	948	0.2
	shell	k32w061+debug	(read/write)	661664	662760	1096	0.2
			.bss	78564	78708	144	0.2
			.text	575452	576404	952	0.2
linux	all-clusters-app	debug	(read only)	1709953	1713745	3792	0.2
			(read/write)	126624	126752	128	0.1
			.bss	57520	57648	128	0.2
			.rodata	135349	135509	160	0.1
			.text	1441154	1444786	3632	0.3
	bridge-app	debug+rpc	(read only)	1305125	1308917	3792	0.3
			(read/write)	76816	76944	128	0.2
			.bss	42224	42352	128	0.3
			.rodata	110764	110924	160	0.1
			.text	1097461	1101093	3632	0.3
	chip-tool	debug	(read only)	4900629	4904949	4320	0.1
			(read/write)	166280	166408	128	0.1
			.bss	40584	40712	128	0.3
			.rodata	265618	265778	160	0.1
			.text	4326037	4330197	4160	0.1
	lighting-app	debug+rpc	(read only)	1574153	`1577977`	3824	0.2
			(read/write)	110064	110192	128	0.1
			.bss	47888	48016	128	0.3
			.rodata	128337	128529	192	0.1
			.text	1311314	1314946	3632	0.3
	ota-provider-app	debug	(read only)	1260553	1264889	4336	0.3
			(read/write)	75560	75688	128	0.2
			.bss	44832	44960	128	0.3
			.rodata	113063	113223	160	0.1
			.text	1050402	1054578	4176	0.4
	ota-requestor-app	debug	(read only)	1343681	`1348017`	4336	0.3
			(read/write)	79264	79392	128	0.2
			.bss	47296	47424	128	0.3
			.rodata	123888	124048	160	0.1
			.text	1120370	1124546	4176	0.4
	shell	debug	(read only)	794665	794697	32	0.0
			.text	612674	612706	32	0.0
	tv-app	debug	(read only)	1846809	1850601	3792	0.2
			(read/write)	405016	405144	128	0.0
			.bss	336968	337096	128	0.0
			.rodata	155213	155373	160	0.1
			.text	1547330	`1550962`	3632	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2285472	2286832	1360	0.1
			.bss	179108	179252	144	0.1
			.text	1248072	`1249432`	1360	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2271408	2272768	1360	0.1
			.bss	171972	172116	144	0.1
			.text	1234008	1235368	1360	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2247312	2248608	1296	0.1
			.bss	170860	171004	144	0.1
			.text	1209912	`1211208`	1296	0.1
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861319	862407	1088	0.1
			bss	110384	110528	144	0.1
			rodata	95400	95480	80	0.1
			text	579904	580796	892	0.2
		nrf52840dk_nrf52840+rpc	(read/write)	823691	824815	1124	0.1
			bss	106740	106884	144	0.1
			rodata	86588	86656	68	0.1
			text	554076	554968	892	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	786362	787446	1084	0.1
			bss	111760	111904	144	0.1
			rodata	90660	90736	76	0.1
			text	509372	510260	888	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	836719	837835	1116	0.1
			bss	109408	109552	144	0.1
			rodata	91872	91948	76	0.1
			text	560004	560892	888	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	762038	763142	1104	0.1
			bss	110820	110964	144	0.1
			rodata	87176	87256	80	0.1
			text	489564	490452	888	0.2
	pump-app	nrf52840dk_nrf52840	(read/write)	842859	843947	1088	0.1
			bss	109548	109692	144	0.1
			rodata	93580	93660	80	0.1
			text	564184	565076	892	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	836451	837539	1088	0.1
			bss	109444	109588	144	0.1
			rodata	91828	91908	80	0.1
			text	559624	560512	888	0.2
p6	all-clusters-app	default	(read/write)	2294024	`2295128`	1104	0.0
			.bss	112096	112240	144	0.1
			.text	`1252288`	1253392	1104	0.1
	lock-app	default	(read/write)	2211448	2212536	1088	0.0
			.bss	100720	100864	144	0.1
			.text	1169712	1170800	1088	0.1
qpg	lighting-app	qpg6100+debug	(read only)	491108	491924	816	0.2
			.bss	50056	50152	96	0.2
			.text	485788	486604	816	0.2
	lock-app	qpg6100+debug	(read only)	466040	466856	816	0.2
			.bss	49000	49096	96	0.2
			.text	460720	461536	816	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	764266	765706	1440	0.2
			bss	78896	79040	144	0.2
			text	530138	531366	1228	0.2

Decreases (5 builds for mbed, p6)

platform	target	config	section	`fcf4c33`	`6924534`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	852120	851976	-144	-0.0
	lighting-app	CY8CPROTO_062_4343W+release	.heap	858896	858752	-144	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.heap	860016	859872	-144	-0.0
p6	all-clusters-app	default	.heap	918728	918584	-144	-0.0
	lock-app	default	.heap	930224	930080	-144	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`fcf4c33`	`6924534`	change	% change
efr32	lighting-app	BRD4161A	(read only)	746648	747776	1128	0.2
			(read/write)	115364	115508	144	0.1
			.bss	113564	113708	144	0.1
			.data	1800	1800	0	0.0
			.text	746640	747768	1128	0.2
		BRD4161A+rpc	(read only)	734188	735292	1104	0.2
			(read/write)	131992	132136	144	0.1
			.bss	130068	130212	144	0.1
			.data	1924	1924	0	0.0
			.text	734180	735284	1104	0.2
	lock-app	BRD4161A	(read only)	723712	724824	1112	0.2
			(read/write)	113148	113292	144	0.1
			.bss	111388	111532	144	0.1
			.data	1756	1756	0	0.0
			.text	723704	724816	1112	0.2
	window-app	BRD4161A	(read only)	724704	725816	1112	0.2
			(read/write)	113468	113612	144	0.1
			.bss	111708	111852	144	0.1
			.data	1760	1760	0	0.0
			.text	724696	725808	1112	0.2
esp32	all-clusters-app	c3devkit	(read only)	825820	827054	1234	0.1
			(read/write)	1220258	1220474	216	0.0
			.dram0.bss	56512	56656	144	0.3
			.dram0.data	14084	14084	0	0.0
			.flash.rodata	164408	164480	72	0.0
			.flash.text	825820	827054	1234	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	896619	897711	1092	0.1
			(read/write)	419580	419780	200	0.0
			.dram0.bss	61864	62008	144	0.2
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	192380	192436	56	0.0
			.flash.text	891235	892327	1092	0.1
			.iram0.text	122943	122943	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	705032	706124	1092	0.2
			.bss	76988	77132	144	0.2
			.data	1912	1912	0	0.0
			.text	620332	621280	948	0.2
	lock-app	k32w061+debug	(read/write)	596448	597540	1092	0.2
			.bss	67500	67644	144	0.2
			.data	1880	1880	0	0.0
			.text	521268	522216	948	0.2
	shell	k32w061+debug	(read/write)	661664	662760	1096	0.2
			.bss	78564	78708	144	0.2
			.data	1848	1848	0	0.0
			.text	575452	576404	952	0.2
linux	all-clusters-app	debug	(read only)	1709953	1713745	3792	0.2
			(read/write)	126624	126752	128	0.1
			.bss	57520	57648	128	0.2
			.data	1042	1042	0	0.0
			.data.rel.ro	62784	62784	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	135349	135509	160	0.1
			.text	1441154	1444786	3632	0.3
	bridge-app	debug+rpc	(read only)	1305125	1308917	3792	0.3
			(read/write)	76816	76944	128	0.2
			.bss	42224	42352	128	0.3
			.data	1568	1568	0	0.0
			.data.rel.ro	28024	28024	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	110764	110924	160	0.1
			.text	1097461	1101093	3632	0.3
	chip-tool	debug	(read only)	4900629	4904949	4320	0.1
			(read/write)	166280	166408	128	0.1
			.bss	40584	40712	128	0.3
			.data	2272	2272	0	0.0
			.data.rel.ro	117936	117936	0	0.0
			.dynamic	592	592	0	0.0
			.got	4416	4416	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	265618	265778	160	0.1
			.text	4326037	4330197	4160	0.1
	lighting-app	debug+rpc	(read only)	1574153	`1577977`	3824	0.2
			(read/write)	110064	110192	128	0.1
			.bss	47888	48016	128	0.3
			.data	1234	1234	0	0.0
			.data.rel.ro	55616	55616	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	128337	128529	192	0.1
			.text	1311314	1314946	3632	0.3
	ota-provider-app	debug	(read only)	1260553	1264889	4336	0.3
			(read/write)	75560	75688	128	0.2
			.bss	44832	44960	128	0.3
			.data	784	784	0	0.0
			.data.rel.ro	24840	24840	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113063	113223	160	0.1
			.text	1050402	1054578	4176	0.4
	ota-requestor-app	debug	(read only)	1343681	`1348017`	4336	0.3
			(read/write)	79264	79392	128	0.2
			.bss	47296	47424	128	0.3
			.data	848	848	0	0.0
			.data.rel.ro	26024	26024	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	123888	124048	160	0.1
			.text	1120370	1124546	4176	0.4
	shell	debug	(read only)	794665	794697	32	0.0
			(read/write)	66088	66088	0	0.0
			.bss	23816	23816	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	37520	37520	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	78479	78479	0	0.0
			.text	612674	612706	32	0.0
	tv-app	debug	(read only)	1846809	1850601	3792	0.2
			(read/write)	405016	405144	128	0.0
			.bss	336968	337096	128	0.0
			.data	2768	2768	0	0.0
			.data.rel.ro	59600	59600	0	0.0
			.dynamic	592	592	0	0.0
			.got	4432	4432	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	155213	155373	160	0.1
			.text	1547330	`1550962`	3632	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2285472	2286832	1360	0.1
			.bss	179108	179252	144	0.1
			.data	5216	5216	0	0.0
			.heap	852120	851976	-144	-0.0
			.text	1248072	`1249432`	1360	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2271408	2272768	1360	0.1
			.bss	171972	172116	144	0.1
			.data	5576	5576	0	0.0
			.heap	858896	858752	-144	-0.0
			.text	1234008	1235368	1360	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2247312	2248608	1296	0.1
			.bss	170860	171004	144	0.1
			.data	5568	5568	0	0.0
			.heap	860016	859872	-144	-0.0
			.text	1209912	`1211208`	1296	0.1
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2049520	2049520	0	0.0
			.bss	156160	156160	0	0.0
			.data	4968	4968	0	0.0
			.heap	875320	875320	0	0.0
			.text	1012120	1012120	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861319	862407	1088	0.1
			bss	110384	110528	144	0.1
			rodata	95400	95480	80	0.1
			text	579904	580796	892	0.2
		nrf52840dk_nrf52840+rpc	(read/write)	823691	824815	1124	0.1
			bss	106740	106884	144	0.1
			rodata	86588	86656	68	0.1
			text	554076	554968	892	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	786362	787446	1084	0.1
			bss	111760	111904	144	0.1
			rodata	90660	90736	76	0.1
			text	509372	510260	888	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	836719	837835	1116	0.1
			bss	109408	109552	144	0.1
			rodata	91872	91948	76	0.1
			text	560004	560892	888	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	762038	763142	1104	0.1
			bss	110820	110964	144	0.1
			rodata	87176	87256	80	0.1
			text	489564	490452	888	0.2
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	842859	843947	1088	0.1
			bss	109548	109692	144	0.1
			rodata	93580	93660	80	0.1
			text	564184	565076	892	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	836451	837539	1088	0.1
			bss	109444	109588	144	0.1
			rodata	91828	91908	80	0.1
			text	559624	560512	888	0.2
	shell	nrf52840dk_nrf52840	(read/write)	776239	776239	0	0.0
			bss	109004	109004	0	0.0
			rodata	72516	72516	0	0.0
			text	520124	520124	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691294	691294	0	0.0
			bss	109988	109988	0	0.0
			rodata	67160	67160	0	0.0
			text	440732	440732	0	0.0
p6	all-clusters-app	default	(read/write)	2294024	`2295128`	1104	0.0
			.bss	112096	112240	144	0.1
			.data	2520	2520	0	0.0
			.heap	918728	918584	-144	-0.0
			.text	`1252288`	1253392	1104	0.1
	lock-app	default	(read/write)	2211448	2212536	1088	0.0
			.bss	100720	100864	144	0.1
			.data	2400	2400	0	0.0
			.heap	930224	930080	-144	-0.0
			.text	1169712	1170800	1088	0.1
qpg	lighting-app	qpg6100+debug	(read only)	491108	491924	816	0.2
			(read/write)	114144	114144	0	0.0
			.bss	50056	50152	96	0.2
			.data	1008	1008	0	0.0
			.text	485788	486604	816	0.2
	lock-app	qpg6100+debug	(read only)	466040	466856	816	0.2
			(read/write)	114140	114140	0	0.0
			.bss	49000	49096	96	0.2
			.data	964	964	0	0.0
			.text	460720	461536	816	0.2
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	764266	765706	1440	0.2
			bss	78896	79040	144	0.2
			noinit	37160	37160	0	0.0
			text	530138	531366	1228	0.2

github-actions · 2021-11-16T15:40:22Z

PR #11304: Size comparison from e755a26 to 6cdcecc

Increases above 0.2%:

platform	target	config	section	`e755a26`	`6cdcecc`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	56512	56656	144	0.3
		m5stack	.dram0.bss	61864	62008	144	0.2

Increases (15 builds for esp32, mbed, nrfconnect, qpg, telink)

platform	target	config	section	`e755a26`	`6cdcecc`	change	% change
esp32	all-clusters-app	c3devkit	(read only)	824912	826146	1234	0.1
			(read/write)	`1219650`	1219866	216	0.0
			.dram0.bss	56512	56656	144	0.3
			.flash.rodata	163800	163872	72	0.0
			.flash.text	824912	826146	1234	0.1
		m5stack	(read only)	895819	896943	1124	0.1
			(read/write)	418980	419188	208	0.0
			.dram0.bss	61864	62008	144	0.2
			.flash.rodata	191780	191844	64	0.0
			.flash.text	890435	891559	1124	0.1
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2283728	2285088	1360	0.1
			.bss	179108	179252	144	0.1
			.text	1246328	`1247688`	1360	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2269720	2271080	1360	0.1
			.bss	171972	172116	144	0.1
			.text	1232320	1233680	1360	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	`2245560`	2246920	1360	0.1
			.bss	170860	171004	144	0.1
			.text	1208160	1209520	1360	0.1
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	860183	861267	1084	0.1
			bss	110384	110528	144	0.1
			rodata	95032	95108	76	0.1
			text	579140	580028	888	0.2
		nrf52840dk_nrf52840+rpc	(read/write)	822551	823675	1124	0.1
			bss	106740	106884	144	0.1
			rodata	86216	86284	68	0.1
			text	553312	554200	888	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	785222	786322	1100	0.1
			bss	111760	111904	144	0.1
			rodata	90288	90364	76	0.1
			text	508608	509496	888	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	835579	836699	1120	0.1
			bss	109408	109552	144	0.1
			rodata	91500	91580	80	0.1
			text	559236	560128	892	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	760902	762002	1100	0.1
			bss	110820	110964	144	0.1
			rodata	86808	86884	76	0.1
			text	488796	489684	888	0.2
	pump-app	nrf52840dk_nrf52840	(read/write)	841723	842807	1084	0.1
			bss	109548	109692	144	0.1
			rodata	93212	93288	76	0.1
			text	563420	564308	888	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	835315	836399	1084	0.1
			bss	109444	109588	144	0.1
			rodata	91460	91536	76	0.1
			text	558856	559748	892	0.2
qpg	lighting-app	qpg6100+debug	(read only)	489736	490544	808	0.2
			.bss	50056	50152	96	0.2
			.text	484416	485224	808	0.2
	lock-app	qpg6100+debug	(read only)	464692	465500	808	0.2
			.bss	49000	49096	96	0.2
			.text	459372	460180	808	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	763014	764454	1440	0.2
			bss	78896	79040	144	0.2
			text	529210	530438	1228	0.2

Decreases (3 builds for mbed)

platform	target	config	section	`e755a26`	`6cdcecc`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	852120	851976	-144	-0.0
	lighting-app	CY8CPROTO_062_4343W+release	.heap	858896	858752	-144	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.heap	860016	859872	-144	-0.0

Full report (21 builds for esp32, mbed, nrfconnect, qpg, telink)

platform	target	config	section	`e755a26`	`6cdcecc`	change	% change
esp32	all-clusters-app	c3devkit	(read only)	824912	826146	1234	0.1
			(read/write)	`1219650`	1219866	216	0.0
			.dram0.bss	56512	56656	144	0.3
			.dram0.data	14084	14084	0	0.0
			.flash.rodata	163800	163872	72	0.0
			.flash.text	824912	826146	1234	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	895819	896943	1124	0.1
			(read/write)	418980	419188	208	0.0
			.dram0.bss	61864	62008	144	0.2
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	191780	191844	64	0.0
			.flash.text	890435	891559	1124	0.1
			.iram0.text	122943	122943	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2283728	2285088	1360	0.1
			.bss	179108	179252	144	0.1
			.data	5216	5216	0	0.0
			.heap	852120	851976	-144	-0.0
			.text	1246328	`1247688`	1360	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2269720	2271080	1360	0.1
			.bss	171972	172116	144	0.1
			.data	5576	5576	0	0.0
			.heap	858896	858752	-144	-0.0
			.text	1232320	1233680	1360	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2245560`	2246920	1360	0.1
			.bss	170860	171004	144	0.1
			.data	5568	5568	0	0.0
			.heap	860016	859872	-144	-0.0
			.text	1208160	1209520	1360	0.1
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2049520	2049520	0	0.0
			.bss	156160	156160	0	0.0
			.data	4968	4968	0	0.0
			.heap	875320	875320	0	0.0
			.text	1012120	1012120	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	860183	861267	1084	0.1
			bss	110384	110528	144	0.1
			rodata	95032	95108	76	0.1
			text	579140	580028	888	0.2
		nrf52840dk_nrf52840+rpc	(read/write)	822551	823675	1124	0.1
			bss	106740	106884	144	0.1
			rodata	86216	86284	68	0.1
			text	553312	554200	888	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	785222	786322	1100	0.1
			bss	111760	111904	144	0.1
			rodata	90288	90364	76	0.1
			text	508608	509496	888	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	835579	836699	1120	0.1
			bss	109408	109552	144	0.1
			rodata	91500	91580	80	0.1
			text	559236	560128	892	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	760902	762002	1100	0.1
			bss	110820	110964	144	0.1
			rodata	86808	86884	76	0.1
			text	488796	489684	888	0.2
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	841723	842807	1084	0.1
			bss	109548	109692	144	0.1
			rodata	93212	93288	76	0.1
			text	563420	564308	888	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	835315	836399	1084	0.1
			bss	109444	109588	144	0.1
			rodata	91460	91536	76	0.1
			text	558856	559748	892	0.2
	shell	nrf52840dk_nrf52840	(read/write)	776239	776239	0	0.0
			bss	109004	109004	0	0.0
			rodata	72516	72516	0	0.0
			text	520124	520124	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691294	691294	0	0.0
			bss	109988	109988	0	0.0
			rodata	67160	67160	0	0.0
			text	440732	440732	0	0.0
qpg	lighting-app	qpg6100+debug	(read only)	489736	490544	808	0.2
			(read/write)	114144	114144	0	0.0
			.bss	50056	50152	96	0.2
			.data	1008	1008	0	0.0
			.text	484416	485224	808	0.2
	lock-app	qpg6100+debug	(read only)	464692	465500	808	0.2
			(read/write)	114140	114140	0	0.0
			.bss	49000	49096	96	0.2
			.data	964	964	0	0.0
			.text	459372	460180	808	0.2
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	763014	764454	1440	0.2
			bss	78896	79040	144	0.2
			noinit	37160	37160	0	0.0
			text	529210	530438	1228	0.2

src/app/ClusterInfo.h

src/app/ReadHandler.cpp

src/app/ReadHandler.h

src/app/tests/TestReadInteraction.cpp

todo · 2021-11-17T04:02:36Z

Wildcard cluster id with non-global attributes or wildcard attribute paths should be rejected.

connectedhomeip/src/app/ReadHandler.cpp

Lines 357 to 367 in 2c50c6c

    
           // TODO: Wildcard cluster id with non-global attributes or wildcard attribute paths should be rejected. 
        
           err = path.GetEndpoint(&(clusterInfo.mEndpointId)); 
        
           if (err == CHIP_NO_ERROR) 
        
           { 
        
               VerifyOrExit(!clusterInfo.HasWildcardEndpointId(), err = CHIP_ERROR_IM_MALFORMED_ATTRIBUTE_PATH); 
        
           } 
        
           else if (err == CHIP_END_OF_TLV) 
        
           { 
        
               err = CHIP_NO_ERROR; 
        
           } 
        
           SuccessOrExit(err);

This comment was generated by todo based on a `TODO` comment in `2c50c6c` in #11304. cc @erjiaqing.

github-actions · 2021-11-17T04:33:30Z

PR #11304: Size comparison from cbd3e95 to 9f86049

Increases above 0.2%:

platform	target	config	section	`cbd3e95`	`9f86049`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	56512	56656	144	0.3
		m5stack	.dram0.bss	61864	62008	144	0.2

Increases (17 builds for efr32, esp32, k32w, mbed, p6, qpg, telink)

platform	target	config	section	`cbd3e95`	`9f86049`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745448	746528	1080	0.1
			(read/write)	115364	115508	144	0.1
			.bss	113564	113708	144	0.1
			.text	745440	746520	1080	0.1
		BRD4161A+rpc	(read only)	732964	734044	1080	0.1
			(read/write)	131992	132136	144	0.1
			.bss	130068	130212	144	0.1
			.text	732956	734036	1080	0.1
	lock-app	BRD4161A	(read only)	722536	723600	1064	0.1
			(read/write)	113148	113292	144	0.1
			.bss	111388	111532	144	0.1
			.text	722528	723592	1064	0.1
	window-app	BRD4161A	(read only)	723496	724576	1080	0.1
			(read/write)	113468	113612	144	0.1
			.bss	111708	111852	144	0.1
			.text	723488	724568	1080	0.1
esp32	all-clusters-app	c3devkit	(read only)	825128	826358	1230	0.1
			(read/write)	1219762	1219946	184	0.0
			.dram0.bss	56512	56656	144	0.3
			.flash.rodata	163912	163952	40	0.0
			.flash.text	825128	826358	1230	0.1
		m5stack	(read only)	896127	897219	1092	0.1
			(read/write)	419084	419260	176	0.0
			.dram0.bss	61864	62008	144	0.2
			.flash.rodata	191884	191916	32	0.0
			.flash.text	890743	891835	1092	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	703856	704920	1064	0.2
			.bss	76988	77132	144	0.2
			.text	619156	620076	920	0.1
	lock-app	k32w061+debug	(read/write)	595300	596364	1064	0.2
			.bss	67500	67644	144	0.2
			.text	520120	521040	920	0.2
	shell	k32w061+debug	(read/write)	660532	661596	1064	0.2
			.bss	78564	78708	144	0.2
			.text	574320	575240	920	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	`2284296`	2285560	1264	0.1
			.bss	179108	179252	144	0.1
			.text	1246896	1248160	1264	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	`2270224`	2271560	1336	0.1
			.bss	171972	172116	144	0.1
			.text	`1232824`	1234160	1336	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2246128	`2247400`	1272	0.1
			.bss	170860	171004	144	0.1
			.text	1208728	1210000	1272	0.1
p6	all-clusters-app	default	(read/write)	2292832	`2293928`	1096	0.0
			.bss	112096	112240	144	0.1
			.text	1251096	1252192	1096	0.1
	lock-app	default	(read/write)	`2210320`	2211384	1064	0.0
			.bss	100720	100864	144	0.1
			.text	`1168584`	1169648	1064	0.1
qpg	lighting-app	qpg6100+debug	(read only)	490080	490880	800	0.2
			.bss	50056	50152	96	0.2
			.text	484760	485560	800	0.2
	lock-app	qpg6100+debug	(read only)	465044	465844	800	0.2
			.bss	49000	49096	96	0.2
			.text	459724	460524	800	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	763250	764682	1432	0.2
			bss	78896	79040	144	0.2
			text	529344	530586	1242	0.2

Decreases (5 builds for mbed, p6)

platform	target	config	section	`cbd3e95`	`9f86049`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	852120	851976	-144	-0.0
	lighting-app	CY8CPROTO_062_4343W+release	.heap	858896	858752	-144	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.heap	860016	859872	-144	-0.0
p6	all-clusters-app	default	.heap	918728	918584	-144	-0.0
	lock-app	default	.heap	930224	930080	-144	-0.0

Full report (20 builds for efr32, esp32, k32w, mbed, p6, qpg, telink)

platform	target	config	section	`cbd3e95`	`9f86049`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745448	746528	1080	0.1
			(read/write)	115364	115508	144	0.1
			.bss	113564	113708	144	0.1
			.data	1800	1800	0	0.0
			.text	745440	746520	1080	0.1
		BRD4161A+rpc	(read only)	732964	734044	1080	0.1
			(read/write)	131992	132136	144	0.1
			.bss	130068	130212	144	0.1
			.data	1924	1924	0	0.0
			.text	732956	734036	1080	0.1
	lock-app	BRD4161A	(read only)	722536	723600	1064	0.1
			(read/write)	113148	113292	144	0.1
			.bss	111388	111532	144	0.1
			.data	1756	1756	0	0.0
			.text	722528	723592	1064	0.1
	window-app	BRD4161A	(read only)	723496	724576	1080	0.1
			(read/write)	113468	113612	144	0.1
			.bss	111708	111852	144	0.1
			.data	1760	1760	0	0.0
			.text	723488	724568	1080	0.1
esp32	all-clusters-app	c3devkit	(read only)	825128	826358	1230	0.1
			(read/write)	1219762	1219946	184	0.0
			.dram0.bss	56512	56656	144	0.3
			.dram0.data	14084	14084	0	0.0
			.flash.rodata	163912	163952	40	0.0
			.flash.text	825128	826358	1230	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	896127	897219	1092	0.1
			(read/write)	419084	419260	176	0.0
			.dram0.bss	61864	62008	144	0.2
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	191884	191916	32	0.0
			.flash.text	890743	891835	1092	0.1
			.iram0.text	122943	122943	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	703856	704920	1064	0.2
			.bss	76988	77132	144	0.2
			.data	1912	1912	0	0.0
			.text	619156	620076	920	0.1
	lock-app	k32w061+debug	(read/write)	595300	596364	1064	0.2
			.bss	67500	67644	144	0.2
			.data	1880	1880	0	0.0
			.text	520120	521040	920	0.2
	shell	k32w061+debug	(read/write)	660532	661596	1064	0.2
			.bss	78564	78708	144	0.2
			.data	1848	1848	0	0.0
			.text	574320	575240	920	0.2
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2284296`	2285560	1264	0.1
			.bss	179108	179252	144	0.1
			.data	5216	5216	0	0.0
			.heap	852120	851976	-144	-0.0
			.text	1246896	1248160	1264	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2270224`	2271560	1336	0.1
			.bss	171972	172116	144	0.1
			.data	5576	5576	0	0.0
			.heap	858896	858752	-144	-0.0
			.text	`1232824`	1234160	1336	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2246128	`2247400`	1272	0.1
			.bss	170860	171004	144	0.1
			.data	5568	5568	0	0.0
			.heap	860016	859872	-144	-0.0
			.text	1208728	1210000	1272	0.1
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2049520	2049520	0	0.0
			.bss	156160	156160	0	0.0
			.data	4968	4968	0	0.0
			.heap	875320	875320	0	0.0
			.text	1012120	1012120	0	0.0
p6	all-clusters-app	default	(read/write)	2292832	`2293928`	1096	0.0
			.bss	112096	112240	144	0.1
			.data	2520	2520	0	0.0
			.heap	918728	918584	-144	-0.0
			.text	1251096	1252192	1096	0.1
	lock-app	default	(read/write)	`2210320`	2211384	1064	0.0
			.bss	100720	100864	144	0.1
			.data	2400	2400	0	0.0
			.heap	930224	930080	-144	-0.0
			.text	`1168584`	1169648	1064	0.1
qpg	lighting-app	qpg6100+debug	(read only)	490080	490880	800	0.2
			(read/write)	114144	114144	0	0.0
			.bss	50056	50152	96	0.2
			.data	1008	1008	0	0.0
			.text	484760	485560	800	0.2
	lock-app	qpg6100+debug	(read only)	465044	465844	800	0.2
			(read/write)	114140	114140	0	0.0
			.bss	49000	49096	96	0.2
			.data	964	964	0	0.0
			.text	459724	460524	800	0.2
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	763250	764682	1432	0.2
			bss	78896	79040	144	0.2
			noinit	37160	37160	0	0.0
			text	529344	530586	1242	0.2

github-actions · 2021-11-17T06:18:09Z

PR #11304: Size comparison from cbd3e95 to 2627266

Increases above 0.2%:

platform	target	config	section	`cbd3e95`	`2627266`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	56512	56656	144	0.3
		m5stack	.dram0.bss	61864	62008	144	0.2
linux	all-clusters-app	debug	.text	1434050	1437986	3936	0.3
	bridge-app	debug+rpc	(read only)	`1298021`	`1302101`	4080	0.3
			.bss	42224	42352	128	0.3
			.text	1090357	1094309	3952	0.4
	chip-tool	debug	.bss	40584	40712	128	0.3
	lighting-app	debug+rpc	(read only)	`1567113`	1571193	4080	0.3
			.bss	47888	48016	128	0.3
			.text	`1304210`	1308162	3952	0.3
	ota-provider-app	debug	(read only)	1253449	`1258089`	4640	0.4
			.bss	44832	44960	128	0.3
			.text	`1043298`	1047778	4480	0.4
	ota-requestor-app	debug	(read only)	1337025	1341617	4592	0.3
			.bss	47296	47424	128	0.3
			.text	`1113490`	1117954	4464	0.4
	tv-app	debug	.text	`1544802`	`1548738`	3936	0.3

Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`cbd3e95`	`2627266`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745448	746528	1080	0.1
			(read/write)	115364	115508	144	0.1
			.bss	113564	113708	144	0.1
			.text	745440	746520	1080	0.1
		BRD4161A+rpc	(read only)	732964	734044	1080	0.1
			(read/write)	131992	132136	144	0.1
			.bss	130068	130212	144	0.1
			.text	732956	734036	1080	0.1
	lock-app	BRD4161A	(read only)	722536	723600	1064	0.1
			(read/write)	113148	113292	144	0.1
			.bss	111388	111532	144	0.1
			.text	722528	723592	1064	0.1
	window-app	BRD4161A	(read only)	723496	724576	1080	0.1
			(read/write)	113468	113612	144	0.1
			.bss	111708	111852	144	0.1
			.text	723488	724568	1080	0.1
esp32	all-clusters-app	c3devkit	(read only)	825128	826358	1230	0.1
			(read/write)	1219762	1219946	184	0.0
			.dram0.bss	56512	56656	144	0.3
			.flash.rodata	163912	163952	40	0.0
			.flash.text	825128	826358	1230	0.1
		m5stack	(read only)	896127	897219	1092	0.1
			(read/write)	419084	419260	176	0.0
			.dram0.bss	61864	62008	144	0.2
			.flash.rodata	191884	191916	32	0.0
			.flash.text	890743	891835	1092	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	703856	704920	1064	0.2
			.bss	76988	77132	144	0.2
			.text	619156	620076	920	0.1
	lock-app	k32w061+debug	(read/write)	595300	596364	1064	0.2
			.bss	67500	67644	144	0.2
			.text	520120	521040	920	0.2
	shell	k32w061+debug	(read/write)	660532	661596	1064	0.2
			.bss	78564	78708	144	0.2
			.text	574320	575240	920	0.2
linux	all-clusters-app	debug	(read only)	1702849	1706913	4064	0.2
			(read/write)	126624	126752	128	0.1
			.bss	57520	57648	128	0.2
			.rodata	135349	135477	128	0.1
			.text	1434050	1437986	3936	0.3
	bridge-app	debug+rpc	(read only)	`1298021`	`1302101`	4080	0.3
			(read/write)	76816	76944	128	0.2
			.bss	42224	42352	128	0.3
			.rodata	110764	110892	128	0.1
			.text	1090357	1094309	3952	0.4
	chip-tool	debug	(read only)	4957053	4961661	4608	0.1
			(read/write)	166504	166632	128	0.1
			.bss	40584	40712	128	0.3
			.rodata	267186	267314	128	0.0
			.text	4380437	4384917	4480	0.1
	lighting-app	debug+rpc	(read only)	`1567113`	1571193	4080	0.3
			(read/write)	110064	110192	128	0.1
			.bss	47888	48016	128	0.3
			.rodata	128401	128529	128	0.1
			.text	`1304210`	1308162	3952	0.3
	ota-provider-app	debug	(read only)	1253449	`1258089`	4640	0.4
			(read/write)	75560	75688	128	0.2
			.bss	44832	44960	128	0.3
			.rodata	113063	113223	160	0.1
			.text	`1043298`	1047778	4480	0.4
	ota-requestor-app	debug	(read only)	1337025	1341617	4592	0.3
			(read/write)	79264	79392	128	0.2
			.bss	47296	47424	128	0.3
			.rodata	124112	124240	128	0.1
			.text	`1113490`	1117954	4464	0.4
	shell	debug	(read only)	794665	794697	32	0.0
			.text	612674	612706	32	0.0
	tv-app	debug	(read only)	`1846009`	1850073	4064	0.2
			(read/write)	318136	318264	128	0.0
			.bss	249960	250088	128	0.1
			.rodata	156653	156781	128	0.1
			.text	`1544802`	`1548738`	3936	0.3
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	`2284296`	2285560	1264	0.1
			.bss	179108	179252	144	0.1
			.text	1246896	1248160	1264	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	`2270224`	2271560	1336	0.1
			.bss	171972	172116	144	0.1
			.text	`1232824`	1234160	1336	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2246128	`2247400`	1272	0.1
			.bss	170860	171004	144	0.1
			.text	1208728	1210000	1272	0.1
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	860463	861519	1056	0.1
			bss	110384	110528	144	0.1
			rodata	95136	95184	48	0.1
			text	579316	580200	884	0.2
		nrf52840dk_nrf52840+rpc	(read/write)	822831	823911	1080	0.1
			bss	106740	106884	144	0.1
			rodata	86320	86360	40	0.0
			text	553488	554372	884	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	785502	786558	1056	0.1
			bss	111760	111904	144	0.1
			rodata	90392	90440	48	0.1
			text	508788	509668	880	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	835859	836947	1088	0.1
			bss	109408	109552	144	0.1
			rodata	91604	91652	48	0.1
			text	559416	560296	880	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	761182	762238	1056	0.1
			bss	110820	110964	144	0.1
			rodata	86912	86960	48	0.1
			text	488976	489856	880	0.2
	pump-app	nrf52840dk_nrf52840	(read/write)	842003	843059	1056	0.1
			bss	109548	109692	144	0.1
			rodata	93316	93364	48	0.1
			text	563596	564480	884	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	835595	836651	1056	0.1
			bss	109444	109588	144	0.1
			rodata	91564	91612	48	0.1
			text	559036	559916	880	0.2
p6	all-clusters-app	default	(read/write)	2292832	`2293928`	1096	0.0
			.bss	112096	112240	144	0.1
			.text	1251096	1252192	1096	0.1
	lock-app	default	(read/write)	`2210320`	2211384	1064	0.0
			.bss	100720	100864	144	0.1
			.text	`1168584`	1169648	1064	0.1
qpg	lighting-app	qpg6100+debug	(read only)	490080	490880	800	0.2
			.bss	50056	50152	96	0.2
			.text	484760	485560	800	0.2
	lock-app	qpg6100+debug	(read only)	465044	465844	800	0.2
			.bss	49000	49096	96	0.2
			.text	459724	460524	800	0.2
telink	lighting-app	tlsr9518adk80d	(read/write)	763250	764682	1432	0.2
			bss	78896	79040	144	0.2
			text	529344	530586	1242	0.2

Decreases (5 builds for mbed, p6)

platform	target	config	section	`cbd3e95`	`2627266`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	852120	851976	-144	-0.0
	lighting-app	CY8CPROTO_062_4343W+release	.heap	858896	858752	-144	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.heap	860016	859872	-144	-0.0
p6	all-clusters-app	default	.heap	918728	918584	-144	-0.0
	lock-app	default	.heap	930224	930080	-144	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`cbd3e95`	`2627266`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745448	746528	1080	0.1
			(read/write)	115364	115508	144	0.1
			.bss	113564	113708	144	0.1
			.data	1800	1800	0	0.0
			.text	745440	746520	1080	0.1
		BRD4161A+rpc	(read only)	732964	734044	1080	0.1
			(read/write)	131992	132136	144	0.1
			.bss	130068	130212	144	0.1
			.data	1924	1924	0	0.0
			.text	732956	734036	1080	0.1
	lock-app	BRD4161A	(read only)	722536	723600	1064	0.1
			(read/write)	113148	113292	144	0.1
			.bss	111388	111532	144	0.1
			.data	1756	1756	0	0.0
			.text	722528	723592	1064	0.1
	window-app	BRD4161A	(read only)	723496	724576	1080	0.1
			(read/write)	113468	113612	144	0.1
			.bss	111708	111852	144	0.1
			.data	1760	1760	0	0.0
			.text	723488	724568	1080	0.1
esp32	all-clusters-app	c3devkit	(read only)	825128	826358	1230	0.1
			(read/write)	1219762	1219946	184	0.0
			.dram0.bss	56512	56656	144	0.3
			.dram0.data	14084	14084	0	0.0
			.flash.rodata	163912	163952	40	0.0
			.flash.text	825128	826358	1230	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	896127	897219	1092	0.1
			(read/write)	419084	419260	176	0.0
			.dram0.bss	61864	62008	144	0.2
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	191884	191916	32	0.0
			.flash.text	890743	891835	1092	0.1
			.iram0.text	122943	122943	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	703856	704920	1064	0.2
			.bss	76988	77132	144	0.2
			.data	1912	1912	0	0.0
			.text	619156	620076	920	0.1
	lock-app	k32w061+debug	(read/write)	595300	596364	1064	0.2
			.bss	67500	67644	144	0.2
			.data	1880	1880	0	0.0
			.text	520120	521040	920	0.2
	shell	k32w061+debug	(read/write)	660532	661596	1064	0.2
			.bss	78564	78708	144	0.2
			.data	1848	1848	0	0.0
			.text	574320	575240	920	0.2
linux	all-clusters-app	debug	(read only)	1702849	1706913	4064	0.2
			(read/write)	126624	126752	128	0.1
			.bss	57520	57648	128	0.2
			.data	1042	1042	0	0.0
			.data.rel.ro	62784	62784	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	135349	135477	128	0.1
			.text	1434050	1437986	3936	0.3
	bridge-app	debug+rpc	(read only)	`1298021`	`1302101`	4080	0.3
			(read/write)	76816	76944	128	0.2
			.bss	42224	42352	128	0.3
			.data	1568	1568	0	0.0
			.data.rel.ro	28024	28024	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	110764	110892	128	0.1
			.text	1090357	1094309	3952	0.4
	chip-tool	debug	(read only)	4957053	4961661	4608	0.1
			(read/write)	166504	166632	128	0.1
			.bss	40584	40712	128	0.3
			.data	2272	2272	0	0.0
			.data.rel.ro	118136	118136	0	0.0
			.dynamic	592	592	0	0.0
			.got	4416	4416	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	267186	267314	128	0.0
			.text	4380437	4384917	4480	0.1
	lighting-app	debug+rpc	(read only)	`1567113`	1571193	4080	0.3
			(read/write)	110064	110192	128	0.1
			.bss	47888	48016	128	0.3
			.data	1234	1234	0	0.0
			.data.rel.ro	55616	55616	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	128401	128529	128	0.1
			.text	`1304210`	1308162	3952	0.3
	ota-provider-app	debug	(read only)	1253449	`1258089`	4640	0.4
			(read/write)	75560	75688	128	0.2
			.bss	44832	44960	128	0.3
			.data	784	784	0	0.0
			.data.rel.ro	24840	24840	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113063	113223	160	0.1
			.text	`1043298`	1047778	4480	0.4
	ota-requestor-app	debug	(read only)	1337025	1341617	4592	0.3
			(read/write)	79264	79392	128	0.2
			.bss	47296	47424	128	0.3
			.data	848	848	0	0.0
			.data.rel.ro	26024	26024	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	124112	124240	128	0.1
			.text	`1113490`	1117954	4464	0.4
	shell	debug	(read only)	794665	794697	32	0.0
			(read/write)	66088	66088	0	0.0
			.bss	23816	23816	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	37520	37520	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	78479	78479	0	0.0
			.text	612674	612706	32	0.0
	tv-app	debug	(read only)	`1846009`	1850073	4064	0.2
			(read/write)	318136	318264	128	0.0
			.bss	249960	250088	128	0.1
			.data	2768	2768	0	0.0
			.data.rel.ro	59720	59720	0	0.0
			.dynamic	592	592	0	0.0
			.got	4432	4432	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	156653	156781	128	0.1
			.text	`1544802`	`1548738`	3936	0.3
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2284296`	2285560	1264	0.1
			.bss	179108	179252	144	0.1
			.data	5216	5216	0	0.0
			.heap	852120	851976	-144	-0.0
			.text	1246896	1248160	1264	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2270224`	2271560	1336	0.1
			.bss	171972	172116	144	0.1
			.data	5576	5576	0	0.0
			.heap	858896	858752	-144	-0.0
			.text	`1232824`	1234160	1336	0.1
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2246128	`2247400`	1272	0.1
			.bss	170860	171004	144	0.1
			.data	5568	5568	0	0.0
			.heap	860016	859872	-144	-0.0
			.text	1208728	1210000	1272	0.1
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2049520	2049520	0	0.0
			.bss	156160	156160	0	0.0
			.data	4968	4968	0	0.0
			.heap	875320	875320	0	0.0
			.text	1012120	1012120	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	860463	861519	1056	0.1
			bss	110384	110528	144	0.1
			rodata	95136	95184	48	0.1
			text	579316	580200	884	0.2
		nrf52840dk_nrf52840+rpc	(read/write)	822831	823911	1080	0.1
			bss	106740	106884	144	0.1
			rodata	86320	86360	40	0.0
			text	553488	554372	884	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	785502	786558	1056	0.1
			bss	111760	111904	144	0.1
			rodata	90392	90440	48	0.1
			text	508788	509668	880	0.2
	lock-app	nrf52840dk_nrf52840	(read/write)	835859	836947	1088	0.1
			bss	109408	109552	144	0.1
			rodata	91604	91652	48	0.1
			text	559416	560296	880	0.2
		nrf5340dk_nrf5340_cpuapp	(read/write)	761182	762238	1056	0.1
			bss	110820	110964	144	0.1
			rodata	86912	86960	48	0.1
			text	488976	489856	880	0.2
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	842003	843059	1056	0.1
			bss	109548	109692	144	0.1
			rodata	93316	93364	48	0.1
			text	563596	564480	884	0.2
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	835595	836651	1056	0.1
			bss	109444	109588	144	0.1
			rodata	91564	91612	48	0.1
			text	559036	559916	880	0.2
	shell	nrf52840dk_nrf52840	(read/write)	776239	776239	0	0.0
			bss	109004	109004	0	0.0
			rodata	72516	72516	0	0.0
			text	520124	520124	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691294	691294	0	0.0
			bss	109988	109988	0	0.0
			rodata	67160	67160	0	0.0
			text	440732	440732	0	0.0
p6	all-clusters-app	default	(read/write)	2292832	`2293928`	1096	0.0
			.bss	112096	112240	144	0.1
			.data	2520	2520	0	0.0
			.heap	918728	918584	-144	-0.0
			.text	1251096	1252192	1096	0.1
	lock-app	default	(read/write)	`2210320`	2211384	1064	0.0
			.bss	100720	100864	144	0.1
			.data	2400	2400	0	0.0
			.heap	930224	930080	-144	-0.0
			.text	`1168584`	1169648	1064	0.1
qpg	lighting-app	qpg6100+debug	(read only)	490080	490880	800	0.2
			(read/write)	114144	114144	0	0.0
			.bss	50056	50152	96	0.2
			.data	1008	1008	0	0.0
			.text	484760	485560	800	0.2
	lock-app	qpg6100+debug	(read only)	465044	465844	800	0.2
			(read/write)	114140	114140	0	0.0
			.bss	49000	49096	96	0.2
			.data	964	964	0	0.0
			.text	459724	460524	800	0.2
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	763250	764682	1432	0.2
			bss	78896	79040	144	0.2
			noinit	37160	37160	0	0.0
			text	529344	530586	1242	0.2

andy31415 · 2021-11-17T15:39:05Z

fast track: very old PR, created and reviewed by a domain owner.

bzbarsky-apple

Looks pretty reasonable, fwiw. Various typos in comments, but...

* [IM] Support chunking in report engine * Address comments * Support wildcard path in read / subscribe interaction

boring-cyborg bot added app examples labels Nov 2, 2021

erjiaqing force-pushed the im/read-chunking branch from 245bccb to 8ae4393 Compare November 2, 2021 11:59

mrjerryjohns reviewed Nov 3, 2021

View reviewed changes

mrjerryjohns reviewed Nov 4, 2021

View reviewed changes

erjiaqing force-pushed the im/read-chunking branch from 8ae4393 to fd26a3f Compare November 4, 2021 10:34

erjiaqing mentioned this pull request Nov 5, 2021

[IM] AttributePathExpandIterator for iterating over list of ClusterInfo-s with wildcard #11303

Merged

erjiaqing force-pushed the im/read-chunking branch from fd26a3f to 1cfc55d Compare November 9, 2021 08:31

boring-cyborg bot added controller lib labels Nov 9, 2021

erjiaqing force-pushed the im/read-chunking branch from 1cfc55d to 4aa62af Compare November 9, 2021 08:49

erjiaqing marked this pull request as ready for review November 9, 2021 08:55

pullapprove bot requested review from andy31415, anush-apple, balducci-apple, bzbarsky-apple, carol-apple, cecille, chrisdecenzo, chulspro, Damian-Nordic, electrocucaracha, emargolis, franck-apple and hawk248 November 9, 2021 08:55

erjiaqing force-pushed the im/read-chunking branch from 014b556 to afae79c Compare November 15, 2021 03:33

erjiaqing force-pushed the im/read-chunking branch from afae79c to d419026 Compare November 15, 2021 05:04

erjiaqing force-pushed the im/read-chunking branch 2 times, most recently from 448e6fc to 527cd7d Compare November 15, 2021 08:09

mrjerryjohns reviewed Nov 16, 2021

View reviewed changes

erjiaqing force-pushed the im/read-chunking branch from b31e904 to 6924534 Compare November 16, 2021 02:21

erjiaqing force-pushed the im/read-chunking branch 2 times, most recently from 93d5c99 to 6cdcecc Compare November 16, 2021 15:20

mrjerryjohns approved these changes Nov 17, 2021

View reviewed changes

erjiaqing added 2 commits November 17, 2021 12:07

[IM] Support chunking in report engine

0ef0d71

Address comments

3dff1cc

erjiaqing force-pushed the im/read-chunking branch from 2c50c6c to 9f86049 Compare November 17, 2021 04:15

Support wildcard path in read / subscribe interaction

2627266

erjiaqing force-pushed the im/read-chunking branch from 9f86049 to 2627266 Compare November 17, 2021 05:53

andy31415 added the fast track label Nov 17, 2021

andy31415 merged commit 4efa5de into project-chip:master Nov 17, 2021

This was referenced Nov 17, 2021

Wildcard cluster id with non-global attributes or wildcard attribute paths shoul... #11912

Closed

Optimize this implementation by making the iterator only emit intersected paths.... #11914

Closed

bzbarsky-apple reviewed Nov 17, 2021

View reviewed changes

kpschoedel pushed a commit to kpschoedel/connectedhomeip that referenced this pull request Nov 18, 2021

[IM] Wildcard read and chunking (project-chip#11304)

ac5c64b

* [IM] Support chunking in report engine * Address comments * Support wildcard path in read / subscribe interaction

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IM] Wildcard read and chunking #11304

[IM] Wildcard read and chunking #11304

erjiaqing commented Nov 2, 2021

github-actions bot commented Nov 4, 2021 •

edited

Loading

todo bot commented Nov 9, 2021

todo bot commented Nov 9, 2021

todo bot commented Nov 9, 2021

todo bot commented Nov 9, 2021

github-actions bot commented Nov 15, 2021 •

edited

Loading

github-actions bot commented Nov 15, 2021 •

edited

Loading

github-actions bot commented Nov 15, 2021 •

edited

Loading

erjiaqing commented Nov 16, 2021

github-actions bot commented Nov 16, 2021 •

edited

Loading

github-actions bot commented Nov 16, 2021 •

edited

Loading

todo bot commented Nov 17, 2021

github-actions bot commented Nov 17, 2021 •

edited

Loading

github-actions bot commented Nov 17, 2021 •

edited

Loading

andy31415 commented Nov 17, 2021

bzbarsky-apple left a comment

[IM] Wildcard read and chunking #11304

[IM] Wildcard read and chunking #11304

Conversation

erjiaqing commented Nov 2, 2021

Problem

Change overview

Testing

github-actions bot commented Nov 4, 2021 • edited Loading

todo bot commented Nov 9, 2021

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

This comment was generated by todo based on a TODO comment in 1cfc55d in #11304. cc @erjiaqing.

todo bot commented Nov 9, 2021

The ClusterInfo may support a group id, the iterator should be able to call group data provider to expand the group id.

This comment was generated by todo based on a TODO comment in 1cfc55d in #11304. cc @erjiaqing.

todo bot commented Nov 9, 2021

Optimize this implementation by making the iterator only emit intersected paths.

This comment was generated by todo based on a TODO comment in 1cfc55d in #11304. cc @erjiaqing.

todo bot commented Nov 9, 2021

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

This comment was generated by todo based on a TODO comment in 4aa62af in #11304. cc @erjiaqing.

github-actions bot commented Nov 15, 2021 • edited Loading

github-actions bot commented Nov 15, 2021 • edited Loading

github-actions bot commented Nov 15, 2021 • edited Loading

erjiaqing commented Nov 16, 2021

github-actions bot commented Nov 16, 2021 • edited Loading

github-actions bot commented Nov 16, 2021 • edited Loading

todo bot commented Nov 17, 2021

Wildcard cluster id with non-global attributes or wildcard attribute paths should be rejected.

This comment was generated by todo based on a TODO comment in 2c50c6c in #11304. cc @erjiaqing.

github-actions bot commented Nov 17, 2021 • edited Loading

github-actions bot commented Nov 17, 2021 • edited Loading

andy31415 commented Nov 17, 2021

bzbarsky-apple left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `1cfc55d` in #11304. cc @erjiaqing.

This comment was generated by todo based on a `TODO` comment in `1cfc55d` in #11304. cc @erjiaqing.

This comment was generated by todo based on a `TODO` comment in `1cfc55d` in #11304. cc @erjiaqing.

This comment was generated by todo based on a `TODO` comment in `4aa62af` in #11304. cc @erjiaqing.

github-actions bot commented Nov 15, 2021 •

edited

Loading

github-actions bot commented Nov 15, 2021 •

edited

Loading

github-actions bot commented Nov 15, 2021 •

edited

Loading

github-actions bot commented Nov 16, 2021 •

edited

Loading

github-actions bot commented Nov 16, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `2c50c6c` in #11304. cc @erjiaqing.

github-actions bot commented Nov 17, 2021 •

edited

Loading

github-actions bot commented Nov 17, 2021 •

edited

Loading