Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some alerts from the LGTM system #11143

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix some alerts from the LGTM system #11143

merged 1 commit into from
Nov 4, 2021

Conversation

tdrozdovsky
Copy link
Contributor

Signed-off-by: Taras Drozdovskyi [email protected]

Problem

Fix LGTM alerts

Change overview

Some LGTM alerts are fixed.

@restyled-io restyled-io bot mentioned this pull request Oct 28, 2021
Closed
@pullapprove pullapprove bot requested a review from yufengwangca October 28, 2021 18:11
@woody-apple
Copy link
Contributor

Thank you for looking at this!

@github-actions
Copy link

github-actions bot commented Oct 28, 2021 •
edited
Loading

PR #11143: Size comparison from 52db0e4 to 1888c00

Increases (1 build for esp32)
platform target config section 52db0e4 1888c00 change % change
esp32 all-clusters-app m5stack (read only) 907183 907271 88 0.0
.flash.text 907183 907271 88 0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 52db0e4 1888c00 change % change
efr32 lighting-app BRD4161A (read only) 737460 737460 0 0.0
(read/write) 115428 115428 0 0.0
.bss 113676 113676 0 0.0
.data 1752 1752 0 0.0
.text 737452 737452 0 0.0
BRD4161A+rpc (read only) 724900 724900 0 0.0
(read/write) 132032 132032 0 0.0
.bss 130180 130180 0 0.0
.data 1852 1852 0 0.0
.text 724892 724892 0 0.0
lock-app BRD4161A (read only) 716756 716756 0 0.0
(read/write) 113244 113244 0 0.0
.bss 111532 111532 0 0.0
.data 1712 1712 0 0.0
.text 716748 716748 0 0.0
window-app BRD4161A (read only) 717660 717660 0 0.0
(read/write) 113568 113568 0 0.0
.bss 111852 111852 0 0.0
.data 1716 1716 0 0.0
.text 717652 717652 0 0.0
esp32 all-clusters-app c3devkit (read only) 875926 875926 0 0.0
(read/write) 1308672 1308672 0 0.0
.dram0.bss 59248 59248 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 199744 199744 0 0.0
.flash.text 875926 875926 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907183 907271 88 0.0
(read/write) 428460 428460 0 0.0
.dram0.bss 61744 61744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208468 208468 0 0.0
.flash.text 907183 907271 88 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701024 701024 0 0.0
.bss 78688 78688 0 0.0
.data 1900 1900 0 0.0
.text 614636 614636 0 0.0
lock-app k32w061+debug (read/write) 592980 592980 0 0.0
.bss 69172 69172 0 0.0
.data 1864 1864 0 0.0
.text 516144 516144 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1653185 1653185 0 0.0
(read/write) 119104 119104 0 0.0
.bss 51376 51376 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 137749 137749 0 0.0
.text 1383170 1383170 0 0.0
bridge-app debug+rpc (read only) 1282125 1282125 0 0.0
(read/write) 85160 85160 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27336 27336 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110724 110724 0 0.0
.text 1076085 1076085 0 0.0
chip-tool debug (read only) 4262181 4262181 0 0.0
(read/write) 122176 122176 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 97504 97504 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 213968 213968 0 0.0
.text 3785413 3785413 0 0.0
lighting-app debug+rpc (read only) 1541097 1541097 0 0.0
(read/write) 102000 102000 0 0.0
.bss 41208 41208 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54416 54416 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128881 128881 0 0.0
.text 1279762 1279762 0 0.0
ota-provider-app debug (read only) 1238617 1238617 0 0.0
(read/write) 67872 67872 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24584 24584 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110888 110888 0 0.0
.text 1031554 1031554 0 0.0
ota-requestor-app debug (read only) 1300713 1300713 0 0.0
(read/write) 76616 76616 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25464 25464 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127584 127584 0 0.0
.text 1075314 1075314 0 0.0
shell debug (read only) 787089 787089 0 0.0
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77455 77455 0 0.0
.text 608098 608098 0 0.0
tv-app debug (read only) 1774209 1774209 0 0.0
(read/write) 289624 289624 0 0.0
.bss 223280 223280 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154680 154680 0 0.0
.text 1477266 1477266 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290656 2290656 0 0.0
.bss 180620 180620 0 0.0
.data 5192 5192 0 0.0
.heap 850632 850632 0 0.0
.text 1253256 1253256 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274992 2274992 0 0.0
.bss 172820 172820 0 0.0
.data 5568 5568 0 0.0
.heap 858056 858056 0 0.0
.text 1237592 1237592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252712 2252712 0 0.0
.bss 171724 171724 0 0.0
.data 5552 5552 0 0.0
.heap 859168 859168 0 0.0
.text 1215312 1215312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048976 2048976 0 0.0
.bss 156208 156208 0 0.0
.data 4968 4968 0 0.0
.heap 875272 875272 0 0.0
.text 1011576 1011576 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862911 862911 0 0.0
bss 112132 112132 0 0.0
rodata 97528 97528 0 0.0
text 577624 577624 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823735 823735 0 0.0
bss 108372 108372 0 0.0
rodata 88304 88304 0 0.0
text 550800 550800 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787902 787902 0 0.0
bss 113504 113504 0 0.0
rodata 92768 92768 0 0.0
text 507092 507092 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839583 839583 0 0.0
bss 111168 111168 0 0.0
rodata 93880 93880 0 0.0
text 559108 559108 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764882 764882 0 0.0
bss 112576 112576 0 0.0
rodata 89188 89188 0 0.0
text 488668 488668 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844287 844287 0 0.0
bss 111304 111304 0 0.0
rodata 95128 95128 0 0.0
text 562320 562320 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839575 839575 0 0.0
bss 111200 111200 0 0.0
rodata 93904 93904 0 0.0
text 558952 558952 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520236 520236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440848 440848 0 0.0
p6 lock-app default (read/write) 2169096 2169096 0 0.0
.bss 67168 67168 0 0.0
.data 2416 2416 0 0.0
.heap 963760 963760 0 0.0
.text 1127360 1127360 0 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491224 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51288 51288 0 0.0
.data 1000 1000 0 0.0
.text 485904 485904 0 0.0
lock-app qpg6100+debug (read only) 467556 467556 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50240 50240 0 0.0
.data 956 956 0 0.0
.text 462236 462236 0 0.0
persistent-storage-app qpg6100+debug (read only) 155236 155236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149916 149916 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664518 664518 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458070 458070 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given has had enough time for reviews.

@tdrozdovsky Can you please resolve this conflict?

@restyled-io restyled-io bot mentioned this pull request Nov 2, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11143: Size comparison from 8ae5b65 to 7b5ca1a

Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 8ae5b65 7b5ca1a change % change
efr32 lighting-app BRD4161A (read only) 736548 736548 0 0.0
(read/write) 114612 114612 0 0.0
.bss 112852 112852 0 0.0
.data 1760 1760 0 0.0
.text 736540 736540 0 0.0
BRD4161A+rpc (read only) 723988 723988 0 0.0
(read/write) 131216 131216 0 0.0
.bss 129356 129356 0 0.0
.data 1860 1860 0 0.0
.text 723980 723980 0 0.0
lock-app BRD4161A (read only) 715828 715828 0 0.0
(read/write) 112428 112428 0 0.0
.bss 110708 110708 0 0.0
.data 1720 1720 0 0.0
.text 715820 715820 0 0.0
window-app BRD4161A (read only) 716728 716728 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111028 111028 0 0.0
.data 1724 1724 0 0.0
.text 716720 716720 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699048 699048 0 0.0
.bss 77848 77848 0 0.0
.data 1908 1908 0 0.0
.text 613492 613492 0 0.0
lock-app k32w061+debug (read/write) 591356 591356 0 0.0
.bss 68364 68364 0 0.0
.data 1872 1872 0 0.0
.text 515320 515320 0 0.0
shell k32w061+debug (read/write) 424748 424748 0 0.0
.bss 63288 63288 0 0.0
.data 672 672 0 0.0
.text 359084 359084 0 0.0
linux all-clusters-app debug (read only) 1689169 1689169 0 0.0
(read/write) 119664 119664 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62240 62240 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139285 139285 0 0.0
.text 1416514 1416514 0 0.0
bridge-app debug+rpc (read only) 1282077 1282077 0 0.0
(read/write) 68488 68488 0 0.0
.bss 35024 35024 0 0.0
.data 992 992 0 0.0
.data.rel.ro 27496 27496 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110852 110852 0 0.0
.text 1075669 1075669 0 0.0
chip-tool debug (read only) 4324637 4324637 0 0.0
(read/write) 123936 123936 0 0.0
.bss 18192 18192 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98744 98744 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 218512 218512 0 0.0
.text 3840709 3840709 0 0.0
lighting-app debug+rpc (read only) 1541433 1541433 0 0.0
(read/write) 101680 101680 0 0.0
.bss 40696 40696 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1279762 1279762 0 0.0
ota-provider-app debug (read only) 1241929 1241929 0 0.0
(read/write) 67520 67520 0 0.0
.bss 37120 37120 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111784 111784 0 0.0
.text 1034066 1034066 0 0.0
ota-requestor-app debug (read only) 1309225 1309225 0 0.0
(read/write) 76840 76840 0 0.0
.bss 45376 45376 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 122752 122752 0 0.0
.text 1088754 1088754 0 0.0
shell debug (read only) 785809 785809 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77551 77551 0 0.0
.text 606770 606770 0 0.0
tv-app debug (read only) 1789321 1789321 0 0.0
(read/write) 289240 289240 0 0.0
.bss 222736 222736 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 58784 58784 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154584 154584 0 0.0
.text 1492546 1492546 0 0.0
p6 lock-app default (read/write) 2167688 2167688 0 0.0
.bss 66352 66352 0 0.0
.data 2424 2424 0 0.0
.heap 964568 964568 0 0.0
.text 1125952 1125952 0 0.0
qpg lighting-app qpg6100+debug (read only) 490328 490328 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50408 50408 0 0.0
.data 1008 1008 0 0.0
.text 485008 485008 0 0.0
lock-app qpg6100+debug (read only) 466668 466668 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49352 49352 0 0.0
.data 964 964 0 0.0
.text 461348 461348 0 0.0
persistent-storage-app qpg6100+debug (read only) 155796 155796 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27760 27760 0 0.0
.data 372 372 0 0.0
.text 150476 150476 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662382 662382 0 0.0
bss 69116 69116 0 0.0
noinit 33216 33216 0 0.0
text 457774 457774 0 0.0

@tdrozdovsky tdrozdovsky force-pushed the fix-lgtm-alerts-1 branch 2 times, most recently from 1888c00 to 38bf407 Compare November 2, 2021 18:01
@restyled-io restyled-io bot mentioned this pull request Nov 2, 2021
Closed
@tdrozdovsky
Copy link
Contributor Author

Fast tracking, given has had enough time for reviews.

@tdrozdovsky Can you please resolve this conflict?

Done!

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11143: Size comparison from e788c90 to ad868b6

Increases (1 build for esp32)
platform target config section e788c906 ad868b6 change % change
esp32 all-clusters-app m5stack (read only) 911495 911571 76 0.0
.flash.text 911495 911571 76 0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e788c906 ad868b6 change % change
efr32 lighting-app BRD4161A (read only) 736844 736844 0 0.0
(read/write) 114612 114612 0 0.0
.bss 112852 112852 0 0.0
.data 1760 1760 0 0.0
.text 736836 736836 0 0.0
BRD4161A+rpc (read only) 724268 724268 0 0.0
(read/write) 131216 131216 0 0.0
.bss 129356 129356 0 0.0
.data 1860 1860 0 0.0
.text 724260 724260 0 0.0
lock-app BRD4161A (read only) 716124 716124 0 0.0
(read/write) 112428 112428 0 0.0
.bss 110708 110708 0 0.0
.data 1720 1720 0 0.0
.text 716116 716116 0 0.0
window-app BRD4161A (read only) 717024 717024 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111028 111028 0 0.0
.data 1724 1724 0 0.0
.text 717016 717016 0 0.0
esp32 all-clusters-app c3devkit (read only) 880466 880466 0 0.0
(read/write) 1307824 1307824 0 0.0
.dram0.bss 58592 58592 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199536 199536 0 0.0
.flash.text 880466 880466 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911495 911571 76 0.0
(read/write) 427592 427592 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208240 208240 0 0.0
.flash.text 911495 911571 76 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699104 699104 0 0.0
.bss 77848 77848 0 0.0
.data 1908 1908 0 0.0
.text 613548 613548 0 0.0
lock-app k32w061+debug (read/write) 591412 591412 0 0.0
.bss 68364 68364 0 0.0
.data 1872 1872 0 0.0
.text 515376 515376 0 0.0
shell k32w061+debug (read/write) 424800 424800 0 0.0
.bss 63288 63288 0 0.0
.data 672 672 0 0.0
.text 359136 359136 0 0.0
linux all-clusters-app debug (read only) 1690385 1690385 0 0.0
(read/write) 119664 119664 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62240 62240 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139637 139637 0 0.0
.text 1417378 1417378 0 0.0
bridge-app debug+rpc (read only) 1283293 1283293 0 0.0
(read/write) 68488 68488 0 0.0
.bss 35024 35024 0 0.0
.data 992 992 0 0.0
.data.rel.ro 27496 27496 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111204 111204 0 0.0
.text 1076533 1076533 0 0.0
chip-tool debug (read only) 4325869 4325869 0 0.0
(read/write) 123936 123936 0 0.0
.bss 18192 18192 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98744 98744 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 218832 218832 0 0.0
.text 3841621 3841621 0 0.0
lighting-app debug+rpc (read only) 1542617 1542617 0 0.0
(read/write) 101680 101680 0 0.0
.bss 40696 40696 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129297 129297 0 0.0
.text 1280626 1280626 0 0.0
ota-provider-app debug (read only) 1243145 1243145 0 0.0
(read/write) 67520 67520 0 0.0
.bss 37120 37120 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112136 112136 0 0.0
.text 1034930 1034930 0 0.0
ota-requestor-app debug (read only) 1310441 1310441 0 0.0
(read/write) 76840 76840 0 0.0
.bss 45376 45376 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123104 123104 0 0.0
.text 1089618 1089618 0 0.0
shell debug (read only) 786529 786529 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607202 607202 0 0.0
tv-app debug (read only) 1790633 1790633 0 0.0
(read/write) 289240 289240 0 0.0
.bss 222736 222736 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 58784 58784 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155032 155032 0 0.0
.text 1493410 1493410 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292704 2292704 0 0.0
.bss 179956 179956 0 0.0
.data 5224 5224 0 0.0
.heap 851264 851264 0 0.0
.text 1255304 1255304 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271648 2271648 0 0.0
.bss 172004 172004 0 0.0
.data 5576 5576 0 0.0
.heap 858864 858864 0 0.0
.text 1234248 1234248 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249368 2249368 0 0.0
.bss 170900 170900 0 0.0
.data 5560 5560 0 0.0
.heap 859984 859984 0 0.0
.text 1211968 1211968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048432 2048432 0 0.0
.bss 156248 156248 0 0.0
.data 4968 4968 0 0.0
.heap 875232 875232 0 0.0
.text 1011032 1011032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861027 861027 0 0.0
bss 111312 111312 0 0.0
rodata 96548 96548 0 0.0
text 577548 577548 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 821851 821851 0 0.0
bss 107552 107552 0 0.0
rodata 87324 87324 0 0.0
text 550720 550720 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786050 786050 0 0.0
bss 112688 112688 0 0.0
rodata 91788 91788 0 0.0
text 507012 507012 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837731 837731 0 0.0
bss 110348 110348 0 0.0
rodata 92900 92900 0 0.0
text 559028 559028 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763030 763030 0 0.0
bss 111756 111756 0 0.0
rodata 88208 88208 0 0.0
text 488584 488584 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843843 843843 0 0.0
bss 110484 110484 0 0.0
rodata 94612 94612 0 0.0
text 563208 563208 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837587 837587 0 0.0
bss 110384 110384 0 0.0
rodata 92900 92900 0 0.0
text 558764 558764 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775911 775911 0 0.0
bss 109104 109104 0 0.0
rodata 72412 72412 0 0.0
text 519804 519804 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690962 0 0.0
bss 110084 110084 0 0.0
rodata 67052 67052 0 0.0
text 440404 440404 0 0.0
p6 lock-app default (read/write) 2167680 2167680 0 0.0
.bss 66352 66352 0 0.0
.data 2424 2424 0 0.0
.heap 964568 964568 0 0.0
.text 1125944 1125944 0 0.0
qpg lighting-app qpg6100+debug (read only) 490384 490384 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50408 50408 0 0.0
.data 1008 1008 0 0.0
.text 485064 485064 0 0.0
lock-app qpg6100+debug (read only) 466720 466720 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49352 49352 0 0.0
.data 964 964 0 0.0
.text 461400 461400 0 0.0
persistent-storage-app qpg6100+debug (read only) 155796 155796 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27760 27760 0 0.0
.data 372 372 0 0.0
.text 150476 150476 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662422 662422 0 0.0
bss 69116 69116 0 0.0
noinit 33216 33216 0 0.0
text 457800 457800 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11143: Size comparison from 38fe11e to a80b58e

Decreases (1 build for esp32)
platform target config section 38fe11e a80b58e change % change
esp32 all-clusters-app m5stack (read only) 911823 911747 -76 -0.0
.flash.text 911823 911747 -76 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 38fe11e a80b58e change % change
efr32 lighting-app BRD4161A (read only) 737168 737168 0 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737160 737160 0 0.0
BRD4161A+rpc (read only) 726364 726364 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726356 726356 0 0.0
lock-app BRD4161A (read only) 716432 716432 0 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716424 716424 0 0.0
window-app BRD4161A (read only) 717332 717332 0 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717324 717324 0 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880670 0 0.0
(read/write) 1308064 1308064 0 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199776 0 0.0
.flash.text 880670 880670 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911823 911747 -76 -0.0
(read/write) 427828 427828 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208476 0 0.0
.flash.text 911823 911747 -76 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699416 699416 0 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613888 613888 0 0.0
lock-app k32w061+debug (read/write) 591724 591724 0 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515716 0 0.0
shell k32w061+debug (read/write) 657656 657656 0 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571024 0 0.0
linux all-clusters-app debug (read only) 1691153 1691153 0 0.0
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139925 139925 0 0.0
.text 1417810 1417810 0 0.0
bridge-app debug+rpc (read only) 1287373 1287373 0 0.0
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1080021 1080021 0 0.0
chip-tool debug (read only) 4422981 4422981 0 0.0
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226384 226384 0 0.0
.text 3928277 3928277 0 0.0
lighting-app debug+rpc (read only) 1548401 1548401 0 0.0
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130129 0 0.0
.text 1284690 1284690 0 0.0
ota-provider-app debug (read only) 1243889 1243889 0 0.0
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112456 112456 0 0.0
.text 1035330 1035330 0 0.0
ota-requestor-app debug (read only) 1311169 1311169 0 0.0
(read/write) 76808 76808 0 0.0
.bss 45344 45344 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123344 123344 0 0.0
.text 1090034 1090034 0 0.0
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1810537 1810537 0 0.0
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155528 155528 0 0.0
.text 1512722 1512722 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293160 2293160 0 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255760 1255760 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272728 0 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235328 1235328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250448 2250448 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213048 1213048 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861379 0 0.0
bss 111288 111288 0 0.0
rodata 96772 96772 0 0.0
text 577712 577712 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 823755 0 0.0
bss 107640 107640 0 0.0
rodata 87948 87948 0 0.0
text 551896 551896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786418 0 0.0
bss 112664 112664 0 0.0
rodata 92028 92028 0 0.0
text 507168 507168 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838083 0 0.0
bss 110324 110324 0 0.0
rodata 93140 93140 0 0.0
text 559188 559188 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763382 0 0.0
bss 111732 111732 0 0.0
rodata 88448 88448 0 0.0
text 488736 488736 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844195 0 0.0
bss 110460 110460 0 0.0
rodata 94852 94852 0 0.0
text 563368 563368 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837955 0 0.0
bss 110360 110360 0 0.0
rodata 93140 93140 0 0.0
text 558924 558924 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2300656 2300656 0 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1258920 1258920 0 0.0
lock-app default (read/write) 2213648 2213648 0 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1171912 1171912 0 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485388 485388 0 0.0
lock-app qpg6100+debug (read only) 467048 467048 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461728 461728 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458058 458058 0 0.0

@andy31415 andy31415 merged commit 3504fc1 into project-chip:master Nov 4, 2021
@andy31415
Copy link
Contributor

This seems to have broken cirque - not a flake.

andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Nov 4, 2021
@andy31415
Revert "Fix some alerts from the LGTM system (project-chip#11143)"
e993254 
This reverts commit 3504fc1.

That commit seems to have broken cirque.
andy31415 added a commit that referenced this pull request Nov 4, 2021
@andy31415
Revert "Fix some alerts from the LGTM system (#11143)" (#11436)
d91ff7c 
This reverts commit 3504fc1.

That commit seems to have broken cirque.
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@tdrozdovsky
Fix some alerts from the LGTM system (project-chip#11143)
ada3a08 
Signed-off-by: Taras Drozdovskyi <[email protected]>
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@andy31415
Revert "Fix some alerts from the LGTM system (project-chip#11143)" (p…
4dadaef 
…roject-chip#11436)

This reverts commit 3504fc1.

That commit seems to have broken cirque.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@electrocucaracha electrocucaracha electrocucaracha approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller fast track review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tdrozdovsky @woody-apple @andy31415 @electrocucaracha @msandstedt