Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdministratorCommissioning cluster not implemented per spec #20882

Closed
bzbarsky-apple opened this issue Jul 18, 2022 · 2 comments · Fixed by #21442
Closed

AdministratorCommissioning cluster not implemented per spec #20882

bzbarsky-apple opened this issue Jul 18, 2022 · 2 comments · Fixed by #21442
Assignees
@bzbarsky-apple
Labels
commissioning Involves placing devices on the network, initial setup spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

Several problems:

  1. WindowStatus does not return WindowNotOpen during initial commissioning, as far as I can tell. It should.
  2. AdminFabricIndex and AdminVendorId don't return null when they should (i.e. any time status is WindowNotOpen).

Depending on how https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/5473 is resolved that could be an issue too.

Proposed Solution

Add tests, align with spec.
@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation commissioning Involves placing devices on the network, initial setup request cert blocker labels Jul 18, 2022
@tcarmelveilleux
Copy link
Contributor

https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5474 will fix the behavior in spec, but then will need to follow in SDK

@woody-apple
Copy link
Contributor

Cert Blocker Review: Removing cert blocker, given we don't know of any tests at this point that are failing.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 29, 2022
@bzbarsky-apple
Fix spec-compliance of Administrator Commissioning attributes.
0cc47aa 
* Move management of the AdminVendorId and AdminFabricIndex to the
  commissioning window opener.
* Fix the types of the attributes in the XML to be nullable.
* Implement the spec provisions about returning null for the fabric
  index when the fabric gets removed.
* Implement the spec provisions about returning "window not open" when
  it was opened via non-cluster means (e.g. boot time.

Fixes project-chip#20882
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 29, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 30, 2022
@bzbarsky-apple
Fix spec-compliance of Administrator Commissioning attributes.
67b40f4 
* Move management of the AdminVendorId and AdminFabricIndex to the
  commissioning window opener.
* Fix the types of the attributes in the XML to be nullable.
* Implement the spec provisions about returning null for the fabric
  index when the fabric gets removed.
* Implement the spec provisions about returning "window not open" when
  it was opened via non-cluster means (e.g. boot time.

Fixes project-chip#20882
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 31, 2022
@bzbarsky-apple
Fix spec-compliance of Administrator Commissioning attributes.
e6628f8 
* Move management of the AdminVendorId and AdminFabricIndex to the
  commissioning window opener.
* Fix the types of the attributes in the XML to be nullable.
* Implement the spec provisions about returning null for the fabric
  index when the fabric gets removed.
* Implement the spec provisions about returning "window not open" when
  it was opened via non-cluster means (e.g. boot time.

Fixes project-chip#20882
woody-apple pushed a commit that referenced this issue Jul 31, 2022
@bzbarsky-apple
Fix spec-compliance of Administrator Commissioning attributes. (#21442)
17c8da6 
* Move management of the AdminVendorId and AdminFabricIndex to the
  commissioning window opener.
* Fix the types of the attributes in the XML to be nullable.
* Implement the spec provisions about returning null for the fabric
  index when the fabric gets removed.
* Implement the spec provisions about returning "window not open" when
  it was opened via non-cluster means (e.g. boot time.

Fixes #20882
woody-apple pushed a commit that referenced this issue Aug 1, 2022
@bzbarsky-apple @woody-apple
Fix spec-compliance of Administrator Commissioning attributes. (#21442)
1eaef0f 
* Move management of the AdminVendorId and AdminFabricIndex to the
  commissioning window opener.
* Fix the types of the attributes in the XML to be nullable.
* Implement the spec provisions about returning null for the fabric
  index when the fabric gets removed.
* Implement the spec provisions about returning "window not open" when
  it was opened via non-cluster means (e.g. boot time.

Fixes #20882
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Fix spec-compliance of Administrator Commissioning attributes. (proje…
4412b6a 
…ct-chip#21442)

* Move management of the AdminVendorId and AdminFabricIndex to the
  commissioning window opener.
* Fix the types of the attributes in the XML to be nullable.
* Implement the spec provisions about returning null for the fabric
  index when the fabric gets removed.
* Implement the spec provisions about returning "window not open" when
  it was opened via non-cluster means (e.g. boot time.

Fixes project-chip#20882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
commissioning Involves placing devices on the network, initial setup spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spec-compliance of Administrator Commissioning attributes. bzbarsky-apple/connectedhomeip
3 participants
@tcarmelveilleux @woody-apple @bzbarsky-apple