Skip to content

Commit

Permalink
Spell judgement as judgment to make en-US spell checker happy without…
Browse files Browse the repository at this point in the history
… a wordlist (#37029)
  • Loading branch information
andy31415 authored Jan 10, 2025
1 parent c39088c commit d91fa6f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/.wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,6 @@ js
json
JTAG
Jupyter
judgement
jupyterlab
KA
kAdminister
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,13 @@ to open the pull request for details or open additional issue in GitHub)
Ensure that there is sufficient detail in issue summaries to make the content of
the PR clear:

- a `TLDR` of the change content. This is a judgement call on details,
- a `TLDR` of the change content. This is a judgment call on details,
generally you should include a what was changed and why. The change is
trivial/short, this can be very short (i.e. "fixed typos" is perfectly
acceptable, however if changing 100-1000s of line, the areas of changes
should be explained)
- If a crash/error is fixed, explain the root cause and if the fix is not
obvious (again, judgement call), explain why the given approach was taken.
obvious (again, judgment call), explain why the given approach was taken.
- Help the reviewer out with any notable information (specific platform
issues, extra thoughts or requests for feedback or gotchas on tricky code,
followup work or PR dependencies)
Expand All @@ -230,7 +230,7 @@ out of convenience.
updated to cover functionality" or "existing tests already cover this" (make
sure they do. Integration tests often only cover happy paths).

Add any notes on not covered things. It is a judgement call on how much can
Add any notes on not covered things. It is a judgment call on how much can
be covered as 100% sounds great however not always possible.

- Manual testing
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ TimeState TimeSynchronizationServer::UpdateDSTOffsetState()
int32_t previousOffset = dstList[activeDstIndex].offset;
dstList[activeDstIndex].offset = 0; // not using dst and last DST item in the list is not active yet
// TODO: This enum mixes state and transitions in a way that's very confusing. This should return either an active, an
// inactive or an invalid and the caller should make the judgement about whether that has changed OR this function should
// inactive or an invalid and the caller should make the judgment about whether that has changed OR this function should
// just return a bool indicating whether a change happened
return previousOffset == 0 ? TimeState::kStopped : TimeState::kChanged;
}
Expand Down

0 comments on commit d91fa6f

Please sign in to comment.