-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suffix usage slot to annotation key name #560
Merged
yujinkim-msft
merged 4 commits into
project-akri:main
from
johnsonshih:user/jshih/device-plugin-annotation
Apr 5, 2023
Merged
Suffix usage slot to annotation key name #560
yujinkim-msft
merged 4 commits into
project-akri:main
from
johnsonshih:user/jshih/device-plugin-annotation
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Johnson, I am unable to see any of the tests running for this PR. Were you able to see the tests run when you committed the changed? Can you also mark that |
Signed-off-by: Johnson Shih <[email protected]> This reverts commit d4b5338.
/add-same-version-label |
👋 Added [same version] label :)! |
👋 Added [same version] label :)! |
Signed-off-by: Johnson Shih <[email protected]>
adithyaj
approved these changes
Apr 4, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When allocate a device plugin, Agent adds the usage slot id to annotations to keep track of slot usage. Currently, when a container uses multiple device plugins, all device plugins will set their values to the same annotation key and only information of one slot is recorded. This PR suffix slot id to the annotation key name to keep all slot information.
The new format of annotation is:
akri.agent.slot-"slot id": "slot id"
In Agent, we parse the annotation keys use the format to avoid accidentally pulling in annotations with similar key name but are not set by Agent.
This PR is part of the fix for issue #492
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)