Update nodejs actions to node16

[jbpaux]

What this PR does / why we need it:
This PR updates nodejs actions used by the different workflows to node16 as node12 is deprecated.
It updates both embedded actions in the projects and dependent actions (except actions-rs actions, see below).
It closes #537

Special notes for your reviewer:
actions-rs actions (audit-check and toolchain) don't have node16 compatible versions available and the maintainer is gone. I would advise to switch to other actions. I found one for the toolchain: the dtolnay/rust-toolchain one but none for the audit-check. We can maybe tackle that in another PR.

If applicable:

• this PR has an associated PR with documentation in akri-docs
• this PR contains unit tests
• added code adheres to standard Rust formatting (cargo fmt)
• code builds properly (cargo build)
• code is free of common mistakes (cargo clippy)
• all Akri tests succeed (cargo test)
• inline documentation builds (cargo doc)
• all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

[jbpaux]

Not sure why the "add-label-missing-comment" job is failing. Apparently the GITHUB_TOKEN doesn't have enough permissions or we are talking about my permissions maybe.

[kate-goldenring]

@jbpaux that is weird that it isnt commenting to the PR as expected. I tried to rerun it and it doesn't work either

[kate-goldenring]

/add-build-dependency-containers-label

[github-actions]

👋 Added [build dependency containers] label :)!

[github-actions]

👋 Added [build dependency containers] label :)!

[kate-goldenring]

@vincepnguyen do you have a sense of why the build dependency containers action is not working (#426)

[jbpaux]

When I see the GITHUB_TOKEN permissions, I see it only has read access to issues and the error is a 403 on a POST request to add comment https://github.com/project-akri/akri/actions/runs/3837765961/jobs/6538055513 while when you launched it it had write permissions https://github.com/project-akri/akri/actions/runs/3839766025/jobs/6537971838

[jbpaux]

any idea on how to get this merged ? 😁

[kate-goldenring]

@adithyaj do you know if anyone can put eyes on this to get this merged soon?

[yujinkim-msft]

@jbpaux any chance you can kick off the checks for this PR again? we would love to have it merged for this next release!

[jbpaux]

I'd love to but I can't, only maintainers can

[yujinkim-msft]

@jbpaux are you able to kick off the checks in your local fork of your code?

[kate-goldenring]

I am not sure why i haven't been able to manually kick them off but we needed to add the same version flag anyways and that kicked off some

[yujinkim-msft]

@jbpaux looks like the build OpenCV check is failing? can you check to see if you can resolve this? then we can approve and merge

[kate-goldenring]

We haven't rebuilt the openCV container in a couple months. The container is failing to build and we likely need to update the Dockerfile which is a two part process, as changes to our intermediate containers must be made in a separate pr: https://github.com/project-akri/akri/blob/main/build/containers/intermediate/Dockerfile.opencvsharp-build#L8. Furthermore, this container takes notoriously long to build so the dev cycle is long on this one. @jbpaux you are welcome to take this on if interested; however, i'd recommend that we let the building of these intermediate containers fail and still merge it. Then we will continue to use the last built image (2 months ago) and can put up an issue to fix this separately.

[jbpaux]

Yes I think it's better to handle that in another PR as it's not related to the CI actions.
I also had a note in the review about the actions-rs actions that don't have node16 equivalent but like I said, maybe tackle that in another PR too.

[jbpaux]

I've rebased to the latest changes, should be good to merge then

[kate-goldenring]

@jbpaux good call out. Created an issue to track it here #579

[kate-goldenring]

created an issue to track fixing the opencv build #580