-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes Test Versions Update #513
Conversation
Signed-off-by: Adithya J <[email protected]>
7e6e547
to
cb60842
Compare
Updating here - Kubernetes 1.22 and 1.23 are failing to init on the test pipeline and at first glance it looks like it could be because of the changes to containerd defaults. I'm going to test locally with a clean image of ubuntu 18.04 to get a better idea of the failure. |
@Rishit-dagli do you know if containerd is a drop in replacement for dockershim? I see with #508 we replaced every reference to dockershim with the containerd path but is there any other diff we should expect? I think some of our testing still uses docker elsewhere |
Signed-off-by: Adithya Jayachandran <[email protected]>
Signed-off-by: Adithya Jayachandran <[email protected]>
Updating here - was able to get it to work up to k8s 1.23 🎉 v1.24 and v1.25 are next |
Signed-off-by: Adithya Jayachandran <[email protected]>
Signed-off-by: Adithya Jayachandran <[email protected]>
Signed-off-by: Adithya Jayachandran <[email protected]>
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Why aren't the end to end tests running in this PR? A bit strange. Hard to confirm the changes :( |
They ran before I did the version bumps, if you go to the last commit before the version bumps and click on the X next to the commit message you should see it all passing minus the version changes here. Not sure why they didn't show up though :( |
aha thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I know it probably took a fair bit of head-banging trial and error.
What this PR does / why we need it:
Fixes #509, the test matrix was using older EOL versions of Kubernetes. This PR updates K8s to use the most recently EOL'd version (1.21) and adds all currently released versions (1.22-1.25).
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)