Return okay if get 404 when trying to delete an Instance #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For shared devices, one Agent may try to delete an instance after it has already been deleted by another Agent on a different node. Due to a bug with this, Agents are sometime erroring out like in the following:
This is because
try_delete_instance
was improperly trying to parse the error returned bydelete_instance
. Also, nofind_instance
check is needed iftry_delete_instance
properly looks for a 404 error, signifying that the instance was already deleted.Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)