Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoupdate dependencies #291

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Autoupdate dependencies #291

merged 1 commit into from
Apr 7, 2021

Conversation

akri-bot
Copy link
Collaborator

@akri-bot akri-bot commented Apr 1, 2021

Auto-generated pull request.
This pull request is generated by GitHub action based on the provided update commands.

@romoh
Copy link
Contributor

romoh commented Apr 1, 2021

@kate-goldenring Looks like some tests are failing. The broker pods still exist after a device being offline. Is that a test timing issue? a bug?
I see the same failure in your latest PR

Writing to Agent pod akri-agent-daemonset-fpltp that device offline
...
Checking for broker pods ... expected 0
Checking number of pods [akri.sh/configuration] ... expected 0
Found 2 pods

@kate-goldenring
Copy link
Contributor

@kate-goldenring Looks like some tests are failing. The broker pods still exist after a device being offline. Is that a test timing issue? a bug?
I see the same failure in your latest PR

Writing to Agent pod akri-agent-daemonset-fpltp that device offline
...
Checking for broker pods ... expected 0
Checking number of pods [akri.sh/configuration] ... expected 0
Found 2 pods

@bfjelds and I have been noticing this occurring occasionally. It is always on MicroK8s, and we havent been able to deduce the cause.

@kate-goldenring
Copy link
Contributor

kate-goldenring commented Apr 1, 2021

@kate-goldenring Looks like some tests are failing. The broker pods still exist after a device being offline. Is that a test timing issue? a bug?

This made me realize that we are not setting debugEcho.configuration.shared=false anymore in our installation, so the delay we are seeing is because shared devices' instances are not removed for 5 minutes. I created a PR #292 to go back to using unshared. Still not sure why currently this is failing and why controller and agent log artifacts arent being created.

@akri-bot akri-bot force-pushed the automated-dependencies-update branch from 3732ada to d05850b Compare April 6, 2021 21:19
@romoh romoh merged commit 3850176 into main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants