Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akri Agent is not recreating instances upon configuration updates #705

Closed
kate-goldenring opened this issue Oct 22, 2024 · 0 comments · Fixed by #711
Closed

Akri Agent is not recreating instances upon configuration updates #705

kate-goldenring opened this issue Oct 22, 2024 · 0 comments · Fixed by #711
Labels
bug Something isn't working

Comments

@kate-goldenring
Copy link
Contributor

Describe the bug
The latest changes to the agent exhibit different behavior than the previous (released) agent. If i install the debugEcho DH and discover two devices, two instances are created. Then if i update the installation to add brokerProperties, the instances should be recreated or at least updated to have the brokerProperty added now, but the new configuration state is not resolved.

To Reproduce
Install Akri dev with debug Echo DH and config:

helm install akri akri-helm-charts/akri-dev --set agent.allowDebugEcho=true     --set debugEcho.discovery.enabled=true     --set debugEcho.configuration.enabled=true     --set debugEcho.configuration.brokerPod.image.repository=nginx     --set debugEcho.configuration.brokerPod.image.tag=stable-alpine     --set debugEcho.configuration.shared=false

Result:

$ k get po,akrii,akric
NAME                                              READY   STATUS    RESTARTS   AGE
pod/akri-agent-daemonset-f2kmw                    1/1     Running   0          15m
pod/akri-controller-deployment-6c7c86ffdd-vkp48   1/1     Running   0          15m
pod/akri-debug-echo-489660-pod                    1/1     Running   0          15m
pod/akri-debug-echo-93a7b0-pod                    1/1     Running   0          15m
pod/akri-debug-echo-discovery-daemonset-5qccr     1/1     Running   0          15m
pod/akri-webhook-configuration-8447999b55-2587b   1/1     Running   0          15m

NAME                                      CONFIG            SHARED   NODES                               AGE
instance.akri.sh/akri-debug-echo-489660   akri-debug-echo   false    ["kagold-thinkpad-x1-carbon-6th"]   15m
instance.akri.sh/akri-debug-echo-93a7b0   akri-debug-echo   false    ["kagold-thinkpad-x1-carbon-6th"]   15m

NAME                                    CAPACITY   AGE
configuration.akri.sh/akri-debug-echo   2          15m

Then upgrade installation with brokerProperty in config:

 helm upgrade --install akri akri-helm-charts/akri-dev --set agent.allowDebugEcho=true     --set debugEcho.discovery.enabled=true     --set debugEcho.configuration.enabled=true     --set debugEcho.configuration.brokerPod.image.repository=nginx     --set debugEcho.configuration.brokerPod.image.tag=stable-alpine     --set debugEcho.configuration.shared=false --set debugEcho.configuration.brokerProperties.random=value

The instances are not updated and broker pods not restarted:

$ k get akrii -o yaml | grep random
# no output
@kate-goldenring kate-goldenring added the bug Something isn't working label Oct 22, 2024
@github-project-automation github-project-automation bot moved this to Triage needed in Akri Roadmap Oct 22, 2024
diconico07 added a commit to diconico07/akri that referenced this issue Oct 29, 2024
Move the cdi::Kind abstraction so that updates to broker properties can
be reflected here.

On Configuration reconciliation if request already exists, update broker
properties

Fix project-akri#705

Signed-off-by: Nicolas Belouin <[email protected]>
@github-project-automation github-project-automation bot moved this from Triage needed to Done in Akri Roadmap Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant