Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable message notifications from active chatrooms #2021

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Bionicgitman
Copy link

@Bionicgitman Bionicgitman commented Mar 5, 2025

Currently Profanity sends notifications even if you are focused on the same chat window as the recipient message.
It should account for whenever profanity is the focused window or not.
See #1987 .

@Bionicgitman Bionicgitman changed the title feat/1987-DisableSelWinNotifs Disable message notifications from active chatrooms Mar 5, 2025
@Bionicgitman Bionicgitman marked this pull request as draft March 5, 2025 13:37
Copy link
Member

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jubalh
Copy link
Member

jubalh commented Mar 6, 2025

Thanks for this PR!
Any reason its just a draft yet?

@Bionicgitman
Copy link
Author

I have yet to include the AFK portion, I will submit it soon

@Bionicgitman Bionicgitman marked this pull request as ready for review March 6, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants