Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce .dockerignore for Docker projects #1351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enforce .dockerignore for Docker projects #1351

wants to merge 1 commit into from

Conversation

ab77
Copy link
Member

@ab77 ab77 commented Jan 29, 2025

Avoid future instances of leaking credentials in Git history.

change-type: patch

@ab77 ab77 requested a review from a team January 29, 2025 16:30
@ab77 ab77 requested a review from a team January 29, 2025 16:40
@flowzone-app flowzone-app
Copy link
Contributor

flowzone-app bot commented Jan 29, 2025

Website deployed to CF Pages, 👀 preview link https://0db3e78a.flowzone.pages.dev

@flowzone-app flowzone-app bot enabled auto-merge January 29, 2025 16:43
klutchell
klutchell requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@klutchell klutchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leverage the existing file_list job for stuff like this.

More importantly, how many of our projects will this break if it merges? Seems like a seriously breaking change and we should print an error or warning but not bail out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klutchell klutchell klutchell requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ab77 @klutchell