Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Failed Job #1325

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ticosax
Copy link
Contributor

@ticosax ticosax commented Feb 12, 2025

This is an action intended to be manually invoked that put the failed job's state back to todo, while keeping the events history.

Only integrated within django (for now)
It's an Early submission (draft) for the purpose of getting feedback the maintainers. I would like to get confirmation that's something they'd like to consider, assuming I'll push it through with tests and updated documentation.
only Tested manually on my machine as it is.

Closes N/A

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

ticosax and others added 2 commits February 12, 2025 19:12
This is an action manualy invoked that put the job's state back to todo but keep
the events history.

Only integrated within django (for now)
@github-actions github-actions bot added the PR type: feature ⭐️ Contains new features label Feb 12, 2025
@ewjoachim
Copy link
Member

Hello!

I like the idea and large parts of the work already done.
I'm not sure I think a retried status is the best though. We had issues when we introduced a aborting state, which we had to undo. I think a job can be both retried AND todo, or doing, or suceeded or failed. If we want to capture that, it would rather be, I think, an event in the events table (capturing the fact a same job might be retried multiple times).

I like the idea of Django admin actions. but this immediately bears the idea of also aborting a task through the admin, though that might be for a later PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: feature ⭐️ Contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants