Travis: Test against Erlang 21 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The adjusted test in |
|
The issue has been reported as https://bugs.erlang.org/browse/ERL-633 but as correctly noted there, one should not rely on the exact return value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR instructs Travis CI also to build against Erlang/OTP 21.
So far I've not done any further testing, but only a small change was required to get it to run tests without issues. The same compiler warnings as already reported in #312 popped up, but beside this, it seems to be fine.
PS: I changed the versions to strings in
.travis.yml. This way it is unmistakable as a version, and not as a number (e.g.1.0.0will be interpreted as1.0). This was not an issue, I just wanted to make it more robust.