Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed background transparency with Images #5683

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

yashlamba
Copy link
Contributor

Co-authored-by: TwoTicks [email protected]

Resolves #5175
Continues #5225

@two-ticks suggested the globalAlpha implementation in #5225, this PR implements it.

Changes:

Example
Replicated the example from #5225, to demonstrate consistency with the other solution.

  • Setting alpha in background now works with images.
  • Alpha parameter range is consistent with the docs (0-255), wanted to point this out since globalAlpha uses 0-1 range.

Screenshots of the change:

PR Checklist

image

image

@welcome
Copy link

welcome bot commented May 28, 2022

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@yashlamba
Copy link
Contributor Author

@two-ticks, added you as a co-author, I hope you don't mind. In case you want me undo that, please let me know :)

@Qianqianye Qianqianye requested a review from limzykenneth June 24, 2022 23:11
@Qianqianye Qianqianye added this to the 1.4.2 milestone Jul 12, 2022
@limzykenneth limzykenneth merged commit 778b691 into processing:main Jul 15, 2022
@limzykenneth
Copy link
Member

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background image with alpha not working as expected
3 participants