-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in curveVertex doc #5566
Fix typo in curveVertex doc #5566
Conversation
Hi @beaumu, thanks for the changes here. Just one note, we usually use a bot to handle adding people to the contributors list, adding it manually as the case in this PR may cause the list to not be updated on the README file until it is updated again. Can you remove that addition in this PR and we'll add you to the contributors list via the bot command? |
Not sure why but there are now a lot of unrelated commits here. Can you reset git back to de7de4c then make just the typo fix, commit it and force push to your branch? Let me know if you are not sure how to do that. |
9e5a9bc
to
decd721
Compare
Thanks for the heads up! |
That's perfect, thanks. There's no need to worry about additional changes in the repo when you submit a PR, git will take care of it in most cases and in the case of conflicts we'll resolve it before merging without necessarily needing additional work from you.
You can checkout the contributors docs at the root of this repo to see if they answer any questions you have. If you have more specific questions, feel free to open an issue. |
@all-contributors please add @beaumu for docs |
I've put up a pull request to add @beaumu! 🎉 |
Resolves #5564
Changes:
Edited
vertex.js
:PR Checklist
npm run lint
passes