Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in curveVertex doc #5566

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

beaumu
Copy link

@beaumu beaumu commented Jan 17, 2022

Resolves #5564

Changes:
Edited vertex.js:

PR Checklist

@limzykenneth
Copy link
Member

Hi @beaumu, thanks for the changes here. Just one note, we usually use a bot to handle adding people to the contributors list, adding it manually as the case in this PR may cause the list to not be updated on the README file until it is updated again. Can you remove that addition in this PR and we'll add you to the contributors list via the bot command?

@limzykenneth
Copy link
Member

Not sure why but there are now a lot of unrelated commits here. Can you reset git back to de7de4c then make just the typo fix, commit it and force push to your branch?

Let me know if you are not sure how to do that.

@beaumu beaumu force-pushed the Doc--Fix-curveVertex-typo branch from 9e5a9bc to decd721 Compare January 19, 2022 18:58
@beaumu
Copy link
Author

beaumu commented Jan 19, 2022

Thanks for the heads up!
Was following the contributions page to try to not mess up, guess I failed 😅
Also, if I have a question about the best practices here and what's the best way of testing and/or trying out the code that has been written. To who can I ask those? 😄

@limzykenneth limzykenneth merged commit f26b0d9 into processing:main Jan 19, 2022
@limzykenneth
Copy link
Member

That's perfect, thanks. There's no need to worry about additional changes in the repo when you submit a PR, git will take care of it in most cases and in the case of conflicts we'll resolve it before merging without necessarily needing additional work from you.

Also, if I have a question about the best practices here and what's the best way of testing and/or trying out the code that has been written. To who can I ask those?

You can checkout the contributors docs at the root of this repo to see if they answer any questions you have. If you have more specific questions, feel free to open an issue.

@limzykenneth
Copy link
Member

@all-contributors please add @beaumu for docs

@allcontributors
Copy link
Contributor

@limzykenneth

I've put up a pull request to add @beaumu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary word in docs
3 participants