Removes invalid website inconsolata reference #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I tested, it seems the text size is also a bit too big, can that be adjusted here as well? |
outofambit
reviewed
Nov 16, 2021
|
i went ahead and made that change @limzykenneth . thank you @guilhermesilveira ! |
This was referenced Feb 3, 2022
Open
This was referenced Mar 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5380
Changes:
To show nf and nfs working there is no need of an extra font. Instead of relying on the deployment of a folder with extra files to the webserver I simply removed the need for the inconsolata font file.
The documentation string for both methods were also updated with double returns to better readability.
Screenshots of the change:
PR Checklist