Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: noLights() #3945

Closed
2 tasks done
sanketsingh24 opened this issue Aug 15, 2019 · 1 comment · Fixed by #3955
Closed
2 tasks done

New Feature: noLights() #3945

sanketsingh24 opened this issue Aug 15, 2019 · 1 comment · Fixed by #3955

Comments

@sanketsingh24
Copy link
Contributor

Nature of issue?

  • New feature request

Most appropriate sub-area of p5.js?

  • WebGL

New feature details:

As a part of the Summer of Code, I will be implementing noLights() along with @aferriss in src/webgl/light.js. The function will be-
noLights().

This function will remove all the lights from the sketch for the subsequent buffers. It will affect all the methods called after this method is called.

Suggestions-
  1. I and @aferriss had decided upon noLights() as the name for the function. Other suggestions were removeLights(), resetLights(). But we are open for better names and suggestions.
@stalgiag
Copy link
Contributor

I like noLights(). It fits the fill and noFill, etc style.

Thank you for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants