Feature implementation: noLights() #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferriss
reviewed
Aug 20, 2019
aferriss
reviewed
Aug 20, 2019
aferriss
reviewed
Aug 20, 2019
aferriss
reviewed
Aug 20, 2019
| @@ -832,4 +832,64 @@ p5.prototype.spotLight = function( | |||
| return this; | |||
| }; | |||
|
|
|||
| /** | |||
| * This function will remove all the lights from the sketch for the | |||
| * subsequent materials rendered. It affects all the subsequent methods. | |||
There was a problem hiding this comment.
Can we put a note in here about how to re-enable lights?
There was a problem hiding this comment.
Something like this: To Re-enable lights, you need to call the lighting methods again?
There was a problem hiding this comment.
How about "Calls to lighting methods made after noLights() will re-enable lights in the sketch."
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3945
Work done-
noLights()in /src/webgl/light.js/webgl/lights/noLights/To do-