Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Teach" link to sidebar #1045

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Add "Teach" link to sidebar #1045

merged 3 commits into from
Jun 17, 2021

Conversation

outofambit
Copy link
Contributor

@outofambit outofambit commented Jun 17, 2021

https://p5js.org/teach exists and i had no idea! let's link to it from the sidebar

cc @yinhwa ❤️

@outofambit outofambit marked this pull request as ready for review June 17, 2021 00:43
@outofambit outofambit merged commit db207c6 into main Jun 17, 2021
@outofambit outofambit deleted the teaching-sidebar branch June 17, 2021 00:48
@yinhwa
Copy link
Contributor

yinhwa commented Jun 18, 2021

thank you @outofambit for mentioning this!🙌🙌 but i wonder if its ok to add a teach menu to the sidebar, cuz when i first planned for this project with @Qianqianye i hoped not to overload the current menu with the teach page😅 so i wished to instead add like <<Learn "& Teach">> to the current "Learn" heading of Learn page (not the menu itself), but it got me some troubles with dealing with the learn.EJS file 😥

@yinhwa
Copy link
Contributor

yinhwa commented Jun 18, 2021

also, i've been meaning to update /teach page in this PR since there have been some new submissions for sharing teaching materials ! I've been away from finishing up the PR but will try so in next couple weeks :)

@outofambit
Copy link
Contributor Author

but i wonder if its ok to add a teach menu to the sidebar, cuz when i first planned for this project with @Qianqianye i hoped not to overload the current menu with the teach page

@yinhwa @Qianqianye mentioned this to me and I'm game for revisiting our sidebar and page structure, but for now the page exists and there's no way to get to it. i'd rather have a long sidebar and have your work be findable until we spend more time figuring out the rest! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants