Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monospace font for editing code Added to edit-area #1036

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

SanjaySinghRajpoot
Copy link
Contributor

Fixes #1018

Changes:
I have edited the code in .edit-area class. By adding the font-family property to the edit-area class the example code got the same font style. When the user click edit button the font remains the same.

Screenshots of the change:
Screenshot from 2021-05-28 09-54-30

Thanks

@limzykenneth
Copy link
Member

I'm trying to find some time to properly review this so sorry that it will take awhile before I can have a proper look at this PR.

@limzykenneth
Copy link
Member

Just had a look through it. The changes isn't quite right yet, notably the edit area size does not match the code block size, see screenshots below.

Current on website
Screenshot-20210612183913-737x378

From this PR at b4c8e99
Screenshot-20210612183929-747x358

Can you see if this can be fixed?

@SanjaySinghRajpoot
Copy link
Contributor Author

SanjaySinghRajpoot commented Jun 14, 2021

On my browser, it is working fine. I am using Firefox's latest version version 89 on ubuntu 20.08. @limzykenneth I think the size of the edit area can be changed by the user (with a small arrow at the bottom right) once the size is changed it will set as the default size for the edit area tab. Try to change the size of the edit area tab then press run and then press edit again, the size of the edit area should be the same as changed before.

if you find anything else then let me know I will fix it. Thanks 😊

@limzykenneth
Copy link
Member

It is not the size that is the only problem (which I think should be fix to match original design still), but also the position, you can see that in the second screenshot towards the top of the edit area it overlaps with the dashed lines and it's left position is also closer to the canvas.

@SanjaySinghRajpoot
Copy link
Contributor Author

SanjaySinghRajpoot commented Jun 15, 2021

On my localhost I am not facing this problem, edit area is working fine, I have attached some screenshots below.
On localhost
Screenshot from 2021-06-15 12-27-46

When the edit button is clicked (on the localhost)
Screenshot from 2021-06-15 12-27-30

code for main.css
Screenshot from 2021-06-15 13-49-49

I am using Firefox's latest version 89 on ubuntu 20.08. I am unable to understand why you are facing this problem. I think you should try removing the padding part, on your code. On my machine, these changes are working fine.

@limzykenneth
Copy link
Member

For some reason it seems to be working for me now. Might be a local cache issue. In any case I'll merge this now. Thanks!

@limzykenneth limzykenneth merged commit fd0a4f4 into processing:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monospace font for editing code / reference page
3 participants