-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monospace font for editing code Added to edit-area #1036
Conversation
I'm trying to find some time to properly review this so sorry that it will take awhile before I can have a proper look at this PR. |
Just had a look through it. The changes isn't quite right yet, notably the edit area size does not match the code block size, see screenshots below. From this PR at b4c8e99 Can you see if this can be fixed? |
On my browser, it is working fine. I am using Firefox's latest version if you find anything else then let me know I will fix it. Thanks 😊 |
It is not the size that is the only problem (which I think should be fix to match original design still), but also the position, you can see that in the second screenshot towards the top of the edit area it overlaps with the dashed lines and it's left position is also closer to the canvas. |
For some reason it seems to be working for me now. Might be a local cache issue. In any case I'll merge this now. Thanks! |
Fixes #1018
Changes:
I have edited the code in
.edit-area
class. By adding the font-family property to theedit-area
class the example code got the same font style. When the user click edit button the font remains the same.Screenshots of the change:

Thanks