Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap async function with threaded_callback #258

Merged
merged 8 commits into from
Feb 22, 2022
Merged

Do not wrap async function with threaded_callback #258

merged 8 commits into from
Feb 22, 2022

Conversation

prkumar
Copy link
Owner

@prkumar prkumar commented Feb 20, 2022

Async callbacks are being wrapped by ThreadedCoroutine when they shouldn't be. For some context, the purpose of ThreadedCoroutine is to allow sync callbacks with aiohttp client. When the callback is an async function, this condition should skip this behavior.

Fixes #256

@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #258 (c86044a) into master (d9aa5b2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2464      2471    +7     
  Branches       358       358           
=========================================
+ Hits          2464      2471    +7     
Impacted Files Coverage Δ
uplink/builder.py 100.00% <100.00%> (ø)
uplink/clients/aiohttp_.py 100.00% <100.00%> (ø)
uplink/compat.py 100.00% <100.00%> (ø)
uplink/hooks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9aa5b2...c86044a. Read the comment docs.

@prkumar prkumar changed the title Do no wrap async function with threaded_callback Do not wrap async function with threaded_callback Feb 20, 2022
@prkumar prkumar merged commit 5a17ccd into master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of async response_handler callback
1 participant