Skip to content

Commit

Permalink
Merge pull request #189 from privatenumber/develop
Browse files Browse the repository at this point in the history
  • Loading branch information
privatenumber authored Aug 5, 2021
2 parents 62de47d + 8a3442e commit a56110d
Show file tree
Hide file tree
Showing 11 changed files with 890 additions and 539 deletions.
39 changes: 0 additions & 39 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md

This file was deleted.

82 changes: 82 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
name: Bug report
description: File a bug report
labels: [bug, pending triage]
body:
- type: markdown
attributes:
value: |
Thank you for taking the time to file this bug report.
- type: textarea
attributes:
label: Bug description
description: A clear and concise description of the bug.
placeholder: |
<!--
What did you do? (Provide reproduction code in next section)
What did you expect to happen?
What happened instead?
Do you have an error stack-trace?
-->
validations:
required: true
- type: textarea
attributes:
label: Reproduction
description: |
How can we reproduce the issue? When an issue is immediately reproducible, others can start debugging instead of following-up with questions.
placeholder: |
<!--
Provide one of the following:
1. A code-snippet that reproduces the issue
2. A reproduction repository that reproduces the issue
3. A pull request with a failing test-case
Please remove as much irrelevant code to make it easier for others to read and debug.
-->
validations:
required: true
- type: dropdown
attributes:
label: Node.js package manager
description: Which package manager are you using? [npm](https://docs.npmjs.com/cli/v7/commands/npm), [yarn](https://yarnpkg.com/), or [pnpm](https://pnpm.io/)
options:
- npm
- yarn
- pnpm
validations:
required: true
- type: textarea
attributes:
label: Environment
description: |
Describe the environment the issue is happening in. This information is used to for reproduction and debugging.
placeholder: |
<!--
Run and paste the output of:
```
npx envinfo --system --npmPackages webpack,esbuild-loader --binaries
```
-->
System:
OS:
CPU:
Shell:
Binaries:
Node:
npm:
npmPackages:
webpack:
esbuild-loader:
render: shell
validations:
required: true
- type: checkboxes
attributes:
label: Can you contribute a fix?
description: We would love it if you can open a pull request to fix this bug!
options:
- label: I’m interested in opening a pull request for this issue.
33 changes: 0 additions & 33 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md

This file was deleted.

43 changes: 43 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Feature request
description: Suggest an idea for this project
labels: [feature request, pending triage]
body:
- type: markdown
attributes:
value: |
Thank you for taking the time to file this feature request.
- type: textarea
attributes:
label: Feature request
description: A description of the feature you would like.
validations:
required: true
- type: textarea
attributes:
label: Why?
description: |
Describe the problem you’re tackling with this feature request.
placeholder: |
<!--
What’s the motivation behind this issue?
eg. “I’m frustrated when...”
-->
validations:
required: true
- type: textarea
attributes:
label: Alternatives
description: |
Have you considered alternative solutions? Is there a workaround?
placeholder: |
<!--
Do you have alternative proposals?
Do you have a workaround?
-->
- type: textarea
attributes:
label: Additional context
description: |
Anything else to share? Screenshots? Links?
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@ Using any JS bundler introduces a bottleneck that makes reaching those speeds im
### Will there be type-checking support?
According to the [esbuild FAQ](https://esbuild.github.io/faq/#:~:text=typescript%20type%20checking%20(just%20run%20tsc%20separately)), it will not be supported.

However, IDEs like [VSCode](https://code.visualstudio.com/docs/languages/typescript) or [WebStorm](https://www.jetbrains.com/help/webstorm/typescript-support.html) have type-chekcing built in. And you can also run `tsc --noEmit` to type check.
Consider these type-checking alternatives:
- Using an IDEs like [VSCode](https://code.visualstudio.com/docs/languages/typescript) or [WebStorm](https://www.jetbrains.com/help/webstorm/typescript-support.html) that has live type-checking built in
- Running `tsc --noEmit` to type check
- Integrating type-checking to your Webpack build as a separate process using [`fork-ts-checker-webpack-plugin`](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin)

## 🌱 Other Webpack plugins

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"webpack": "^4.40.0 || ^5.0.0"
},
"dependencies": {
"esbuild": "^0.11.19",
"esbuild": "^0.12.17",
"joycon": "^3.0.1",
"json5": "^2.2.0",
"loader-utils": "^2.0.0",
Expand Down
14 changes: 7 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a56110d

Please sign in to comment.