Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Replace broken link #651

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Replace broken link #651

merged 1 commit into from
Feb 28, 2019

Conversation

Booteille
Copy link
Contributor

Replace broken link for Block Cloudflare MITM Attack Addon

Description

Resolves: #442

@ghost ghost requested a review from Vincevrp December 8, 2018 00:21
ghost
ghost previously approved these changes Dec 8, 2018
@Vincevrp
Copy link
Contributor

Vincevrp commented Dec 8, 2018

Can someone confirm that this is still the same extension? I can't seem to find the source.

@ghost ghost added the feedback wanted label Dec 8, 2018
@ghost
Copy link

ghost commented Dec 8, 2018

I was thinking the same, hence the review request.

Copy link
Contributor

@Vincevrp Vincevrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a link to the source?

@ghost
Copy link

ghost commented Feb 23, 2019

Sorry, I saw the email but didn't have time to read it and I forgot about it. I'm busy with personal projects lately.

@Vincevrp do you have time to look into it?

@Vincevrp
Copy link
Contributor

There's no reference to the source code from the link provided in the PR, nor vise versa. The addon only has some Russian text on the page, which makes it a bit sketchy.

Sorry, I saw the email but didn't have time to read it and I forgot about it. I'm busy with personal projects lately.

@Vincevrp do you have time to look into it?

Same, sorry.

@Vincevrp Vincevrp force-pushed the patch-2 branch 2 times, most recently from b735860 to 52fc1aa Compare February 28, 2019 22:25
Replace broken link for Block Cloudflare MITM Attack Addon
@Vincevrp
Copy link
Contributor

So I received another email about this. I've changed the link to the project instead of the AMO page because:

Quote from the email:

Our collaborator who have access to AMO gone AWOL

Also

P.S Say hi to @Booteille for us as we cannot deal with GitHub.

@Vincevrp Vincevrp merged commit 22f32c1 into privacytools:master Feb 28, 2019
@Booteille
Copy link
Contributor Author

Thanks for your investigation, all of you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudflare Add-on is removed from AMO - pull request needed
2 participants