On Premise Connection Configuration #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorreece
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Thanks @robertmaloney ! Could you please bump packages/spectral/package.json version to 8.0.4 and run yarn from the base directory to bump the spectral package version?
ryanwersal
force-pushed
the
rm/sc-18076/onprem-connections
branch
from
ba72807 to
c099bad
Compare
|
This has been updated with the reworked on-premise available/controlled implementation we discussed. It also addresses @taylorreece 's request for bumping the version and relocking. |
taylorreece
approved these changes
Feb 28, 2024
|
Can't formally approve but LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
onPremiseConfigoptional metadata to enable on prem variants of connections. One shortcoming of the currently implementation is that thereplacesInputstype doesn't have enough type inference to restrict it's array members to the keys of theinputsfield. An attempt to address that exists on branchrm/sc-18076/onprem-connections-genericsbut it has tradeoffs.