Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qe): use mimalloc instead of the system allocator #5007

Closed
wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Sep 26, 2024

Experiment with mimalloc to see if it solves our memory fragmenation troubles with JSON and doesn't break napi.

Ref: prisma/prisma#21471

Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #5007 will not alter performance

Comparing integration/mimalloc (e348b85) with main (b43a787)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.708MiB 2.708MiB 0.000B
Postgres (gzip) 1.036MiB 1.036MiB 2.000B
Mysql 2.035MiB 2.035MiB 0.000B
Mysql (gzip) 812.542KiB 812.541KiB 1.000B
Sqlite 1.928MiB 1.928MiB 0.000B
Sqlite (gzip) 770.434KiB 770.435KiB -1.000B

aqrln added a commit that referenced this pull request Nov 30, 2024
@aqrln aqrln closed this Nov 30, 2024
@aqrln aqrln deleted the integration/mimalloc branch November 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant