Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Resolve relations with lateral joins #4498

Closed
wants to merge 27 commits into from
Closed

[WIP] Resolve relations with lateral joins #4498

wants to merge 27 commits into from

Conversation

Weakky
Copy link
Contributor

@Weakky Weakky commented Nov 27, 2023 •
edited
Loading

⚠️ Closed in favor of #4509 which is based on an integration branch to test joins against the Prisma Client's.

@Weakky Weakky changed the title wip: lateral joins [WIP] Resolve relations with lateral joins Nov 27, 2023
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 27, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #4498 will degrade performances by 9.11%

Comparing perf/join-exp (c0f2c4c) with main (01aad9b)

Summary

❌ 2 regressions
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main perf/join-exp Change
❌ large_read 7.2 ms 7.9 ms -9.11%
❌ medium_read 1.3 ms 1.4 ms -8.88%

@Weakky Weakky added this to the 5.7.0 milestone Nov 29, 2023
Weakky
Weakky commented Nov 30, 2023
View reviewed changes
query-engine/connectors/sql-query-connector/src/database/operations/coerce.rs Outdated
Comment on lines 81 to 82
TypeIdentifier::Float => todo!(),
TypeIdentifier::Decimal => todo!(),
Copy link
Contributor Author

@Weakky Weakky Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add tests for floats and decimals (and generally all scalar types through relations)

Weakky
Weakky commented Nov 30, 2023
View reviewed changes
query-engine/connectors/sql-query-connector/src/database/operations/coerce.rs Outdated
Comment on lines 93 to 94
serde_json::Value::Array(_) => todo!(),
serde_json::Value::Object(_) => todo!(),
Copy link
Contributor Author

@Weakky Weakky Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unreachable? what about json?

@Weakky Weakky closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Weakky