Skip to content

Commit

Permalink
chore: update comments, remove PlanetScale exclusion for "using_bigin…
Browse files Browse the repository at this point in the history
…t_field" test
  • Loading branch information
jkomyno committed Jan 18, 2024
1 parent 0676bd9 commit 57c5acb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ mod bigint {
}

// "Using a BigInt field" should "work"
// TODO: https://github.com/prisma/team-orm/issues/836
#[connector_test(exclude(Vitess("planetscale.js.wasm")))]
#[connector_test()]
async fn using_bigint_field(runner: Runner) -> TestResult<()> {
insta::assert_snapshot!(
run_query!(&runner, r#"mutation {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// This is a temporary workaround for `bigint` serialization issues in the Planetscale driver,
// which will be fixed upstream once https://github.com/planetscale/database-js/pull/159 is merged.
// which will be fixed upstream once https://github.com/planetscale/database-js/pull/159 is published.
// This only impacts Rust tests concerning `driver-adapters`.

type Stringable = { toString: () => string }
Expand Down
2 changes: 1 addition & 1 deletion query-engine/driver-adapters/executor/src/testd.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ async function planetscaleAdapter(url: string): Promise<DriverAdapter> {
url: copyPathName(url, proxyUrl),
fetch,

// TODO: remove once https://github.com/planetscale/database-js/pull/159 is merged.
// TODO: remove once https://github.com/planetscale/database-js/pull/159 is published upstream.
format: formatPlanetScaleQuery,
})

Expand Down

0 comments on commit 57c5acb

Please sign in to comment.