-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(format): remove dot and colon characters from escape function #70
Conversation
…avoid generating markdown with dot and colon characters escaped (princjef#68)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change and updating the tests!
@dbarria thanks for the PR! Out of curiosity, what tool(s) do you work with that have trouble with the backslash escaping? |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 67.82% 67.82%
=======================================
Files 17 17
Lines 1557 1557
=======================================
Hits 1056 1056
Misses 415 415
Partials 86 86
Continue to review full report at Codecov.
|
When a paragraph contains the dot or colon characters, the generated markdown escapes those characters breaking the markdown visualization in other tools than Github.
This commit removes those characters from the escape function and apparently doesn't affect the other escape logic.