-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(format): expose formatting utils in new formatcore package #43
Conversation
This allows to use them when defining a custom formatter outside of the `format` package.
As I look at this, I'm wondering if it makes more sense to put the base functions in a subpackage to separate it out from the individual formatters. I'm thinking something like What do you think? |
Looks like the linter failed. Can you take a look into the failures ( |
Yes I agree, now that those functions are available outside it seems legit they get their own package. I'll do the move. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the one comment about moving the file. Thanks for taking the time to put this together!
Updated imports and added README.md in format/formatcore.
base.go
This allows to use them when defining a custom formatter outside of the
format
package.This should fix #38.