Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature-flag and extra @aat #5638

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Remove feature-flag and extra @aat #5638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75c0250
Remove feature-flag and extra @aat
kendallgassner Jan 31, 2025
f855458
add skip
kendallgassner Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions e2e/components/Axe.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const SKIPPED_TESTS = [
'components-treeview-features--contain-intrinsic-size',
'components-flash-features--with-icon-action-dismiss', // TODO: Remove once color-contrast issues have been resolved
'components-flash-features--with-icon-and-action', // TODO: Remove once color-contrast issues have been resolved
'components-filteredactionlist--default',
]

type Component = {
Expand All @@ -21,7 +22,7 @@ type Component = {

const {entries} = componentsConfig

test.describe('@aat', () => {
test.describe('Axe tests', () => {
for (const [id, entry] of Object.entries(entries as Record<string, Component>)) {
if (SKIPPED_TESTS.includes(id)) {
continue
Expand All @@ -35,7 +36,7 @@ test.describe('@aat', () => {
test.describe(id, () => {
for (const theme of themes) {
test.describe(theme, () => {
test(`${cleanedName} @aat`, async ({page}) => {
test(`@aat ${cleanedName}`, async ({page}) => {
await visit(page, {
id,
globals: {
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions packages/react/src/FilteredActionList/FilteredActionList.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {ThemeProvider} from '..'
import {FilteredActionList} from '../FilteredActionList'
import BaseStyles from '../BaseStyles'
import Box from '../Box'
import {FeatureFlags} from '../FeatureFlags'

const meta: Meta = {
title: 'Components/FilteredActionList',
Expand Down Expand Up @@ -58,7 +57,7 @@ export function Default(): JSX.Element {
const filteredItems = items.filter(item => item.text.toLowerCase().startsWith(filter.toLowerCase()))

return (
<FeatureFlags flags={{primer_react_select_panel_with_modern_action_list: true}}>
<>
<h1>Filtered Action List</h1>
<div>Please select labels that describe your issue:</div>
<FilteredActionList
Expand All @@ -67,6 +66,6 @@ export function Default(): JSX.Element {
onFilterChange={setFilter}
sx={{border: '1px solid', padding: '8px'}}
/>
</FeatureFlags>
</>
)
}
Loading