Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove reference to pre.json #5154

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: remove reference to pre.json #5154

merged 1 commit into from
Oct 21, 2024

Conversation

joshblack
Copy link
Member

Revert changes that we made for premode to go back to our classic mode 👀

Changelog

New

Changed

  • Revert pre.json specific changes that we needed for CI

Removed

@joshblack joshblack requested a review from a team as a code owner October 18, 2024 15:19
@joshblack joshblack requested a review from keithamus October 18, 2024 15:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 3621883

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Name Type
@primer/react Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 18, 2024
@github-actions github-actions bot added the staff Author is a staff member label Oct 18, 2024
@joshblack joshblack requested a review from jonrohan October 18, 2024 15:20
@joshblack joshblack enabled auto-merge October 18, 2024 15:21
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.09 KB (0%)
packages/react/dist/browser.umd.js 97.48 KB (0%)

@joshblack joshblack added this pull request to the merge queue Oct 18, 2024
@joshblack joshblack removed this pull request from the merge queue due to a manual request Oct 18, 2024
@joshblack joshblack added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 6d8a185 Oct 21, 2024
49 of 50 checks passed
@joshblack joshblack deleted the chore/update-release-steps branch October 21, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@keithamus keithamus Awaiting requested review from keithamus keithamus is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @jonrohan