Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPanel: Fix font weight from active styles for modern ActionList (behind feature flag) #5033

Merged
merged 4 commits into from
Sep 30, 2024
Merged

SelectPanel: Fix font weight from active styles for modern ActionList (behind feature flag) #5033

merged 4 commits into from
Sep 30, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Sep 26, 2024 •
edited
Loading

Accidentally added bold styles for description on hover and focus, fixed now

Before After
description has bold font weight description has normal font weight

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 107c27f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 26, 2024
@siddharthkp siddharthkp changed the title remove font weight from active styles SelectPanel: remove font weight from active styles Sep 26, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5033 September 26, 2024 13:32 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.12 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 98.45 KB (+0.12% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5033 September 27, 2024 09:44 Inactive
@siddharthkp siddharthkp changed the title SelectPanel: remove font weight from active styles SelectPanel: Fix font weight from active styles for modern ActionList (behind feature flag) Sep 27, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@siddharthkp siddharthkp self-assigned this Sep 27, 2024
@siddharthkp siddharthkp marked this pull request as ready for review September 27, 2024 10:00
@siddharthkp siddharthkp requested review from a team as code owners September 27, 2024 10:00
@siddharthkp siddharthkp added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 0b83fe9 Sep 30, 2024
32 checks passed
@siddharthkp siddharthkp deleted the selectpanel-fix-bold-description branch September 30, 2024 11:22
@primer primer bot mentioned this pull request Sep 27, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@camertron camertron camertron approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

Assignees

@siddharthkp siddharthkp

Labels
component: SelectPanel staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddharthkp @camertron @broccolinisoup