Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): add title to visually hidden stories #4998

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(docs): add title to visually hidden stories #4998

merged 2 commits into from
Sep 20, 2024

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Sep 20, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3462, Closes https://github.com/github/primer/issues/3464

Adds Title to visually hidden Select and TextInput stories for better demonstration of use case and accessibility remediation. This addresses a potential accessibility issue where the current example would fail 3.3.2 Labels or Instructions.

Changelog

Changed

  • Adds "title" (heading) to TextInput's "Visually Hidden Label" story
  • Adds "title" (heading) to Select's "Visually Hidden Label" story

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Docs only update

Testing & Reviewing

N/A

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ceaa6d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added staff Author is a staff member skip changeset This change does not need a changelog labels Sep 20, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4998 September 20, 2024 14:43 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.37 KB (0%)
packages/react/dist/browser.umd.js 97.79 KB (0%)

@francinelucca francinelucca marked this pull request as ready for review September 20, 2024 15:54
@francinelucca francinelucca requested review from a team as code owners September 20, 2024 15:54
@francinelucca francinelucca added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 928bfd2 Sep 20, 2024
35 checks passed
@francinelucca francinelucca deleted the francinelucca/docs/visually-hidden-stories-a11y-improvements branch September 20, 2024 16:29
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
@francinelucca @TylerJDev
fix(docs): add title to visually hidden stories (#4998)
a21674f 
* fix(docs): add title to visually hidden stories

* test(vrt): update snapshots

---------

Co-authored-by: francinelucca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tbenning tbenning Awaiting requested review from tbenning tbenning is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member status: review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francinelucca @joshblack