Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Grid component #485

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Create Grid component #485

merged 1 commit into from
Jun 27, 2019

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Jun 27, 2019

Added a Grid component to expose grid system props from styled-system: https://github.com/styled-system/styled-system/blob/master/docs/table.md#grid-layout

This component is similar to the existing Flex component.

Example usage:

<Grid gridTemplateColumns="repeat(2, auto)" gridGap={3}>
    <Box p={3} bg="blue.2">1</Box>
    <Box p={3} bg="yellow.2">2</Box>
</Grid>

Closes #483

Merge checklist

  • Changed base branch to release branch
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@colebemis colebemis requested a review from emplums June 27, 2019 20:13
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for doing this. Would you mind drafting a Release 13.1.1 Release PR + branch and changing the base branch to that branch?

@colebemis
Copy link
Contributor Author

Sure! Wouldn't this be 13.2.0 since adding a component probably falls under "new functionality?"

@colebemis colebemis mentioned this pull request Jun 27, 2019
8 tasks
@colebemis colebemis changed the base branch from master to release-13.2.0 June 27, 2019 20:36
@colebemis colebemis merged commit 48df93d into release-13.2.0 Jun 27, 2019
@colebemis colebemis deleted the grid branch June 27, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants