Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TextInput.TrailingAction hover state #4831

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Aug 8, 2024

Changelog

  1. Styles: Remove icon button background, change icon color on hover
  2. Stories: In storybook example for "Clear input", hide button when the text input is already empty

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: c59922d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 8, 2024
@siddharthkp siddharthkp changed the title Textinput action hover design Fix TextInput action hover state Aug 8, 2024
@siddharthkp siddharthkp self-assigned this Aug 8, 2024
@siddharthkp siddharthkp marked this pull request as ready for review August 8, 2024 13:41
@siddharthkp siddharthkp requested a review from a team as a code owner August 8, 2024 13:41
@siddharthkp siddharthkp requested a review from camertron August 8, 2024 13:41
@siddharthkp siddharthkp changed the title Fix TextInput action hover state Update TextInput.TrailingAction hover state Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.01 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 96.34 KB (+0.04% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4831 August 8, 2024 13:44 Inactive
@siddharthkp siddharthkp requested review from mperrotti and removed request for camertron August 9, 2024 09:45
@siddharthkp siddharthkp requested review from maximedegreve and removed request for langermank August 16, 2024 08:42
@siddharthkp siddharthkp requested a review from joshblack August 16, 2024 08:49
@siddharthkp siddharthkp added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 0d7a02a Aug 20, 2024
30 checks passed
@siddharthkp siddharthkp deleted the textinput-action-hover-design branch August 20, 2024 10:32
@primer primer bot mentioned this pull request Aug 20, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInput action hover state is incorrect
3 participants