Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octicon remediation: aria-label #4811

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Octicon remediation: aria-label #4811

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5a7678d
correct aria-label
siddharthkp Aug 2, 2024
81dd29e
fix playground for Octicon and CircleOcticon
siddharthkp Aug 2, 2024
3432a9b
CicleOcticon: move aria-label to the icon, not the container
siddharthkp Aug 2, 2024
6a9cbd4
clean up aria-label in playground
siddharthkp Aug 2, 2024
43067f7
clean up meta for CircleBadge
siddharthkp Aug 2, 2024
eb8b644
CircleBadge.Icon story: add aria-label in playground
siddharthkp Aug 2, 2024
98b6fed
Create cool-lobsters-nail.md
siddharthkp Aug 2, 2024
ce8073b
add aria-label to circle badge default story
siddharthkp Aug 14, 2024
a395b0f
add aria-label to CircleOcticon default story
siddharthkp Aug 14, 2024
83fce5d
Merge branch 'main' into octicon-remediation-1
siddharthkp Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
correct aria-label
  • Loading branch information
@siddharthkp
siddharthkp committed Aug 2, 2024
commit 5a7678d8fd31ff7385bbb5565adcafdf1268dc50
4 changes: 2 additions & 2 deletions packages/react/src/Octicon/Octicon.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ export default {
component: Octicon,
} as Meta<typeof Octicon>

export const Default = () => <Octicon icon={HeartFillIcon} size={32} />
export const Default = () => <Octicon icon={HeartFillIcon} aria-label="Like" size={32} />

export const Playground: StoryFn<typeof Octicon> = args => <Octicon icon={HeartFillIcon} {...args} />

Playground.args = {
ariaLabel: 'Heart',
'aria-label': 'Heart',
size: 32,
}

Expand Down