Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Button component #4807

Merged
merged 15 commits into from
Sep 26, 2024
Merged
Prev Previous commit
Next Next commit
fix
  • Loading branch information
langermank committed Sep 25, 2024
commit 50f94bdf8512e9cdcb01ec79c485166f20a1f151
2 changes: 1 addition & 1 deletion packages/react/src/__tests__/AnchoredOverlay.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {AnchoredOverlay} from '../AnchoredOverlay'
import {behavesAsComponent, checkExports} from '../utils/testing'
import {render as HTMLRender, fireEvent} from '@testing-library/react'
import axe from 'axe-core'
import {Button} from '../deprecated'
import {Button} from '../Button'
import theme from '../theme'
import BaseStyles from '../BaseStyles'
import {ThemeProvider} from '../ThemeProvider'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,10 @@ import {ThemeProvider} from '../..'
import type {LinkProps} from '../../Link'
import Link from '../../Link'
import type {ActionMenuProps} from '../../deprecated'
import {ActionMenu, ActionList, Button} from '../../deprecated'
import {ActionMenu, ActionList} from '../../deprecated'
import type {ItemProps} from '../../deprecated/ActionList'
import BaseStyles from '../../BaseStyles'
// We can remove the as as DropdownButton, after updating the deprecated Button usages
import {Button as DropdownButton} from '../../Button'
import {Button} from '../../Button'

const meta: Meta = {
title: 'Deprecated/Components/ActionMenu',
Expand Down Expand Up @@ -301,9 +300,9 @@ const DoubleClickableAnchor: Exclude<ActionMenuProps['renderAnchor'], null | und
[callback],
)
return (
<DropdownButton trailingAction={TriangleDownIcon} onClick={onClick} {...rest}>
<Button trailingAction={TriangleDownIcon} onClick={onClick} {...rest}>
{children}
</DropdownButton>
</Button>
)
}
export function ActionMenuWithDoubleClickStory(): JSX.Element {
Expand Down
Loading