-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds UnderlinePanels to drafts/
#4550
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
4a27922
adds UnderlinePanels components and stories
mperrotti 393afbb
Merge branch 'main' of github.com:primer/react into mp/underline-panels
mperrotti e9ac50c
adds tests, minor stylistic updates
mperrotti c05ac21
adds component docs
mperrotti 5eef15a
adds changeset
mperrotti 7c00947
corrects changeset
mperrotti 0a87590
fixes circ dep, tests, misc bugs
mperrotti 9eda952
more test fixes
mperrotti 8b9c328
appease the linter
mperrotti f6a2067
updates snaps, fixes tiny visual regression
mperrotti 8197cc0
test(vrt): update snapshots
mperrotti 81b478c
cleanup
mperrotti b600b34
upgrades @github/tab-container-element
mperrotti b2f6daa
Merge branch 'main' into mp/underline-panels
mperrotti fa3f238
fixes createComponent import
mperrotti 711fed0
updates jest snapshots
mperrotti 1f2e1a9
Apply suggestion from @broccolinisoup
mperrotti 047bfad
addresses PR feedback
mperrotti a2f0995
Merge branch 'main' of github.com:primer/react into mp/underline-panels
mperrotti f728a01
Merge branch 'main' into mp/underline-panels
mperrotti 7091c99
fix broken import
mperrotti ec55b9f
Merge branch 'main' of github.com:primer/react into mp/underline-panels
mperrotti 38e98ed
addresses more PR feedback
mperrotti 426f8c0
Merge branch 'main' into mp/underline-panels
mperrotti 0f0b58c
test(vrt): update snapshots
mperrotti 86d5ef9
Merge branch 'main' of github.com:primer/react into mp/underline-panels
mperrotti 4dac206
Merge branch 'mp/underline-panels' of github.com:primer/react into mp…
mperrotti 9d7e5d7
Merge branch 'main' into mp/underline-panels
mperrotti 66e1ada
test(vrt): update snapshots
mperrotti efa5386
Merge branch 'main' of github.com:primer/react into mp/underline-panels
mperrotti c601277
Merge branch 'mp/underline-panels' of github.com:primer/react into mp…
mperrotti 13ad02a
Merge branch 'main' into mp/underline-panels
mperrotti 43bb92e
adds fallbacks to CSS vars
mperrotti 6db2049
Merge branch 'main' of github.com:primer/react into mp/underline-panels
mperrotti c55b637
fixes CSS typo
mperrotti 744eb62
fixes more typos
mperrotti 1cbc162
Merge branch 'main' into mp/underline-panels
mperrotti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
adds component docs
- Loading branch information
commit c05ac214d1d322f1c13f4752b120ac7b77ce7ed5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
packages/react/src/drafts/UnderlinePanels/UnderlinePanels.docs.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
{ | ||
"id": "underline_panels", | ||
"name": "UnderlinePanels", | ||
"status": "draft", | ||
"a11yReviewed": false, | ||
"stories": [ | ||
broccolinisoup marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
"id": "drafts-components-underlinepanels--default" | ||
}, | ||
{ | ||
"id": "'drafts-components-underlinepanels-features--labelled-by-external-element" | ||
}, | ||
{ | ||
"id": "drafts-components-underlinepanels-features--selected-tab" | ||
}, | ||
{ | ||
"id": "drafts-components-underlinepanels-features--with-counters" | ||
}, | ||
{ | ||
"id": "drafts-components-underlinepanels-features--with-counters-in-loading-state" | ||
}, | ||
{ | ||
"id": "drafts-components-underlinepanels-features--with-icons" | ||
}, | ||
{ | ||
"id": "drafts-components-underlinepanels-features--with-icons-hidden-on-narrow-screen" | ||
} | ||
], | ||
"importPath": "@primer/react", | ||
mperrotti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"props": [ | ||
{ | ||
"name": "aria-label", | ||
"type": "string", | ||
"defaultValue": "", | ||
"description": "Accessible name for the tab list" | ||
}, | ||
{ | ||
"name": "aria-labelledby", | ||
"type": "string", | ||
"defaultValue": "", | ||
"description": "ID of the element containing the name for the tab list" | ||
}, | ||
{ | ||
"name": "children", | ||
"type": "Array<UnderlinePanels.Tab | UnderlinePanels.Panel>", | ||
"defaultValue": "", | ||
"required": true, | ||
"description": "Tabs (UnderlinePanels.Tab) and panels (UnderlinePanels.Panel) to render" | ||
}, | ||
{ | ||
"name": "id", | ||
"type": "string", | ||
"defaultValue": "", | ||
"description": "Custom string to use when generating the IDs of tabs and `aria-labelledby` for the panels" | ||
}, | ||
{ | ||
"name": "loadingCounters", | ||
"type": "boolean", | ||
"defaultValue": "false", | ||
"description": "Loading state for all counters. It displays loading animation for individual counters until all are resolved. It is needed to prevent multiple layout shift." | ||
}, | ||
{ | ||
"name": "sx", | ||
"type": "SystemStyleObject" | ||
} | ||
], | ||
"subcomponents": [ | ||
{ | ||
"name": "UnderlinePanels.Tab", | ||
"props": [ | ||
{ | ||
"name": "aria-selected", | ||
"type": "| boolean | 'true' | 'false'", | ||
"defaultValue": "false", | ||
"description": "Whether this is the selected tab. For more information about `aria-current`, see [MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected)." | ||
}, | ||
{ | ||
"name": "counter", | ||
"type": "number | string", | ||
"defaultValue": "", | ||
"description": "Content of CounterLabel rendered after tab text label" | ||
}, | ||
{ | ||
"name": "icon", | ||
"type": "Component", | ||
"defaultValue": "", | ||
"description": "Icon rendered before the tab text label" | ||
}, | ||
{ | ||
"name": "sx", | ||
"type": "SystemStyleObject" | ||
} | ||
] | ||
}, | ||
{ | ||
"name": "UnderlinePanels.Tab", | ||
"props": [], | ||
"passthrough": { | ||
"element": "div", | ||
"url": "https://developer.mozilla.org/en-US/docs/Web/HTML/Element/div#Attributes" | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh must have forgotten to update this, thank you!