tests: add missing snapshot and axe coverage for ActionMenu #4538
Conversation
|
size-limit report 📦
|
khiga8
force-pushed
the
kh-increase-axe-coverage-to-states
branch
from
fdf4f7d to
08e63e1
Compare
| @@ -36,30 +37,29 @@ test.describe('ActionMenu', () => { | |||
| test.describe(theme, () => { | |||
There was a problem hiding this comment.
I noticed that this test is under Inactive items but it's visiting the wrong ID, -links-and-actions which is actually a duplicate of another test. Updated!
khiga8
changed the title
khiga8
force-pushed
the
kh-increase-axe-coverage-to-states
branch
from
c5cda68 to
65e5b1e
Compare
There was a problem hiding this comment.
The snapshots changed for ActionList bcuz Jonathan's profile picture changed 😅
|
I'm assuming the failing tests are expected because the snapshots changed, and will need to be merged in for it to pass. |
|
@khiga8 that's a great point about the CI failing, ideally with |
| @@ -46,7 +46,9 @@ test.describe('ActionMenu', () => { | |||
| // Open state | |||
| await page.locator('button', {hasText: 'Open menu'}).waitFor() | |||
| await page.getByRole('button', {name: 'Open menu'}).click() | |||
| expect(await page.screenshot()).toMatchSnapshot(`ActionMenu.Inactive Items.${theme}.png`) | |||
| expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot( | |||
There was a problem hiding this comment.
Aha! Thank you @joshblack! 🌟
|
bump @mperrotti when you have a sec to review 👀 |
khiga8
force-pushed
the
kh-increase-axe-coverage-to-states
branch
from
4931bfa to
c15d0f9
Compare
* tests: add missing axe coverage for open ActionMenu * Update test * test(vrt): update snapshots * test(vrt): update snapshots * test(vrt): update snapshots * test(ActionMenu): disable animations for snapshot test --------- Co-authored-by: khiga8 <[email protected]> Co-authored-by: Josh Black <[email protected]>
Fixes: #4530
Changelog
I noticed that most of the snapshots test and axe scan coverage for ActionMenu are for the default closed state, which is just a button.
This PR adds an action to open the ActionMenu to ensure we're getting adequate visual regression and axe testing coverage, and regenerates the snapshots.
Rollout strategy
Testing & Reviewing
Merge checklist