Update CounterLabel to use Styled System & Emotion #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 7, 2018 13:07
emplums
commented
Aug 7, 2018
| export default function CounterLabel({theme, children, ...rest}) { | ||
| const {className} = mapWhitespaceProps(rest) | ||
| return <span className={classnames(className, 'Counter', theme && `Counter--${theme}`)}>{children}</span> | ||
| function CounterLabel({scheme, children, className}) { |
There was a problem hiding this comment.
theme needed to be changed to scheme to get it to work, must be conflicting with emotion 🤷♀️
There was a problem hiding this comment.
Yep, works for me! We should start a draft of the release notes and add this to the breaking changes.
|
This looks good, @emplums. Are there any instances of |
36 tasks
|
@shawnbot nice catch, just updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CounterLabel to use Styled System + Emotion ✨