Merge 12dcb89 into abeef0b

primer · Apr 29, 2024 · de858d9 · de858d9
2 parents abeef0b + 12dcb89
commit de858d9
Show file tree

Hide file tree

Showing 82 changed files with 32 additions and 23 deletions.
diff --git a/...onList.test.ts-snapshots/ActionList-Block-Description-dark-colorblind-linux.png b/...onList.test.ts-snapshots/ActionList-Block-Description-dark-colorblind-linux.png
diff --git a/...ActionList.test.ts-snapshots/ActionList-Block-Description-dark-dimmed-linux.png b/...ActionList.test.ts-snapshots/ActionList-Block-Description-dark-dimmed-linux.png
diff --git a/...ist.test.ts-snapshots/ActionList-Block-Description-dark-high-contrast-linux.png b/...ist.test.ts-snapshots/ActionList-Block-Description-dark-high-contrast-linux.png
diff --git a/...onents/ActionList.test.ts-snapshots/ActionList-Block-Description-dark-linux.png b/...onents/ActionList.test.ts-snapshots/ActionList-Block-Description-dark-linux.png
diff --git a/...onList.test.ts-snapshots/ActionList-Block-Description-dark-tritanopia-linux.png b/...onList.test.ts-snapshots/ActionList-Block-Description-dark-tritanopia-linux.png
diff --git a/...nList.test.ts-snapshots/ActionList-Block-Description-light-colorblind-linux.png b/...nList.test.ts-snapshots/ActionList-Block-Description-light-colorblind-linux.png
diff --git a/...st.test.ts-snapshots/ActionList-Block-Description-light-high-contrast-linux.png b/...st.test.ts-snapshots/ActionList-Block-Description-light-high-contrast-linux.png
diff --git a/...nents/ActionList.test.ts-snapshots/ActionList-Block-Description-light-linux.png b/...nents/ActionList.test.ts-snapshots/ActionList-Block-Description-light-linux.png
diff --git a/...nList.test.ts-snapshots/ActionList-Block-Description-light-tritanopia-linux.png b/...nList.test.ts-snapshots/ActionList-Block-Description-light-tritanopia-linux.png
diff --git a/...nList.test.ts-snapshots/ActionList-Inline-Description-dark-colorblind-linux.png b/...nList.test.ts-snapshots/ActionList-Inline-Description-dark-colorblind-linux.png
diff --git a/...ctionList.test.ts-snapshots/ActionList-Inline-Description-dark-dimmed-linux.png b/...ctionList.test.ts-snapshots/ActionList-Inline-Description-dark-dimmed-linux.png
diff --git a/...st.test.ts-snapshots/ActionList-Inline-Description-dark-high-contrast-linux.png b/...st.test.ts-snapshots/ActionList-Inline-Description-dark-high-contrast-linux.png
diff --git a/...nents/ActionList.test.ts-snapshots/ActionList-Inline-Description-dark-linux.png b/...nents/ActionList.test.ts-snapshots/ActionList-Inline-Description-dark-linux.png
diff --git a/...nList.test.ts-snapshots/ActionList-Inline-Description-dark-tritanopia-linux.png b/...nList.test.ts-snapshots/ActionList-Inline-Description-dark-tritanopia-linux.png
diff --git a/...List.test.ts-snapshots/ActionList-Inline-Description-light-colorblind-linux.png b/...List.test.ts-snapshots/ActionList-Inline-Description-light-colorblind-linux.png
diff --git a/...t.test.ts-snapshots/ActionList-Inline-Description-light-high-contrast-linux.png b/...t.test.ts-snapshots/ActionList-Inline-Description-light-high-contrast-linux.png
diff --git a/...ents/ActionList.test.ts-snapshots/ActionList-Inline-Description-light-linux.png b/...ents/ActionList.test.ts-snapshots/ActionList-Inline-Description-light-linux.png
diff --git a/...List.test.ts-snapshots/ActionList-Inline-Description-light-tritanopia-linux.png b/...List.test.ts-snapshots/ActionList-Inline-Description-light-tritanopia-linux.png
diff --git a/.../ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-colorblind-linux.png b/.../ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-colorblind-linux.png
diff --git a/...ents/ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-dimmed-linux.png b/...ents/ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-dimmed-linux.png
diff --git a/...tionList.test.ts-snapshots/ActionList-With-Avatars-dark-high-contrast-linux.png b/...tionList.test.ts-snapshots/ActionList-With-Avatars-dark-high-contrast-linux.png
diff --git a/.../components/ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-linux.png b/.../components/ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-linux.png
diff --git a/.../ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-tritanopia-linux.png b/.../ActionList.test.ts-snapshots/ActionList-With-Avatars-dark-tritanopia-linux.png
diff --git a/...ActionList.test.ts-snapshots/ActionList-With-Avatars-light-colorblind-linux.png b/...ActionList.test.ts-snapshots/ActionList-With-Avatars-light-colorblind-linux.png
diff --git a/...ionList.test.ts-snapshots/ActionList-With-Avatars-light-high-contrast-linux.png b/...ionList.test.ts-snapshots/ActionList-With-Avatars-light-high-contrast-linux.png
diff --git a/...components/ActionList.test.ts-snapshots/ActionList-With-Avatars-light-linux.png b/...components/ActionList.test.ts-snapshots/ActionList-With-Avatars-light-linux.png
diff --git a/...ActionList.test.ts-snapshots/ActionList-With-Avatars-light-tritanopia-linux.png b/...ActionList.test.ts-snapshots/ActionList-With-Avatars-light-tritanopia-linux.png
diff --git a/...tionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-colorblind-linux.png b/...tionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-colorblind-linux.png
diff --git a/...s/ActionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-dimmed-linux.png b/...s/ActionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-dimmed-linux.png
diff --git a/...nMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-high-contrast-linux.png b/...nMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-high-contrast-linux.png
diff --git a/...mponents/ActionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-linux.png b/...mponents/ActionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-linux.png
diff --git a/...tionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-tritanopia-linux.png b/...tionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-dark-tritanopia-linux.png
diff --git a/...ionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-colorblind-linux.png b/...ionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-colorblind-linux.png
diff --git a/...Menu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-high-contrast-linux.png b/...Menu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-high-contrast-linux.png
diff --git a/...ponents/ActionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-linux.png b/...ponents/ActionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-linux.png
diff --git a/...ionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-tritanopia-linux.png b/...ionMenu.test.ts-snapshots/ActionMenu-Controlled-Menu-light-tritanopia-linux.png
diff --git a/...nents/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-colorblind-linux.png b/...nents/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-colorblind-linux.png
diff --git a/...omponents/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-dimmed-linux.png b/...omponents/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-dimmed-linux.png
diff --git a/...ts/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-high-contrast-linux.png b/...ts/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-high-contrast-linux.png
diff --git a/...shots/components/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-linux.png b/...shots/components/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-linux.png
diff --git a/...nents/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-tritanopia-linux.png b/...nents/ActionMenu.test.ts-snapshots/ActionMenu-Default-dark-tritanopia-linux.png
diff --git a/...ents/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-colorblind-linux.png b/...ents/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-colorblind-linux.png
diff --git a/...s/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-high-contrast-linux.png b/...s/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-high-contrast-linux.png
diff --git a/...hots/components/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-linux.png b/...hots/components/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-linux.png
diff --git a/...ents/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-tritanopia-linux.png b/...ents/ActionMenu.test.ts-snapshots/ActionMenu-Default-light-tritanopia-linux.png
diff --git a/...ctionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-colorblind-linux.png b/...ctionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-colorblind-linux.png
diff --git a/...ts/ActionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-dimmed-linux.png b/...ts/ActionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-dimmed-linux.png
diff --git a/...onMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-high-contrast-linux.png b/...onMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-high-contrast-linux.png
diff --git a/...omponents/ActionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-linux.png b/...omponents/ActionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-linux.png
diff --git a/...ctionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-tritanopia-linux.png b/...ctionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-dark-tritanopia-linux.png
diff --git a/...tionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-colorblind-linux.png b/...tionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-colorblind-linux.png
diff --git a/...nMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-high-contrast-linux.png b/...nMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-high-contrast-linux.png
diff --git a/...mponents/ActionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-linux.png b/...mponents/ActionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-linux.png
diff --git a/...tionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-tritanopia-linux.png b/...tionMenu.test.ts-snapshots/ActionMenu-Inactive-Items-light-tritanopia-linux.png
diff --git a/...onMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-colorblind-linux.png b/...onMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-colorblind-linux.png
diff --git a/...ActionMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-dimmed-linux.png b/...ActionMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-dimmed-linux.png
diff --git a/...enu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-high-contrast-linux.png b/...enu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-high-contrast-linux.png
diff --git a/...onents/ActionMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-linux.png b/...onents/ActionMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-linux.png
diff --git a/...onMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-tritanopia-linux.png b/...onMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-dark-tritanopia-linux.png
diff --git a/...nMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-colorblind-linux.png b/...nMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-colorblind-linux.png
diff --git a/...nu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-high-contrast-linux.png b/...nu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-high-contrast-linux.png
diff --git a/...nents/ActionMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-linux.png b/...nents/ActionMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-linux.png
diff --git a/...nMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-tritanopia-linux.png b/...nMenu.test.ts-snapshots/ActionMenu-Links-And-Actions-light-tritanopia-linux.png
diff --git a/.../ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-colorblind-linux.png b/.../ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-colorblind-linux.png
diff --git a/...ents/ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-dimmed-linux.png b/...ents/ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-dimmed-linux.png
diff --git a/...tionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-high-contrast-linux.png b/...tionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-high-contrast-linux.png
diff --git a/.../components/ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-linux.png b/.../components/ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-linux.png
diff --git a/.../ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-tritanopia-linux.png b/.../ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-dark-tritanopia-linux.png
diff --git a/...ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-colorblind-linux.png b/...ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-colorblind-linux.png
diff --git a/...ionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-high-contrast-linux.png b/...ionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-high-contrast-linux.png
diff --git a/...components/ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-linux.png b/...components/ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-linux.png
diff --git a/...ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-tritanopia-linux.png b/...ActionMenu.test.ts-snapshots/ActionMenu-Multi-Select-light-tritanopia-linux.png
diff --git a/...ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-colorblind-linux.png b/...ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-colorblind-linux.png
diff --git a/...nts/ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-dimmed-linux.png b/...nts/ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-dimmed-linux.png
diff --git a/...ionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-high-contrast-linux.png b/...ionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-high-contrast-linux.png
diff --git a/...components/ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-linux.png b/...components/ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-linux.png
diff --git a/...ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-tritanopia-linux.png b/...ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-dark-tritanopia-linux.png
diff --git a/...ctionMenu.test.ts-snapshots/ActionMenu-Single-Select-light-colorblind-linux.png b/...ctionMenu.test.ts-snapshots/ActionMenu-Single-Select-light-colorblind-linux.png
diff --git a/...onMenu.test.ts-snapshots/ActionMenu-Single-Select-light-high-contrast-linux.png b/...onMenu.test.ts-snapshots/ActionMenu-Single-Select-light-high-contrast-linux.png
diff --git a/...omponents/ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-light-linux.png b/...omponents/ActionMenu.test.ts-snapshots/ActionMenu-Single-Select-light-linux.png
diff --git a/...ctionMenu.test.ts-snapshots/ActionMenu-Single-Select-light-tritanopia-linux.png b/...ctionMenu.test.ts-snapshots/ActionMenu-Single-Select-light-tritanopia-linux.png
diff --git a/e2e/components/ActionMenu.test.ts b/e2e/components/ActionMenu.test.ts
@@ -13,8 +13,8 @@ test.describe('ActionMenu', () => {
               colorScheme: theme,
             },
           })
-
-          // Default state
+          // Open state
+          await page.getByRole('button', {name: 'Open menu'}).click()
           expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(`ActionMenu.Default.${theme}.png`)
         })
 
@@ -25,6 +25,7 @@ test.describe('ActionMenu', () => {
               colorScheme: theme,
             },
           })
+          await page.getByRole('button', {name: 'Open menu'}).click()
           await expect(page).toHaveNoViolations()
         })
       })
@@ -36,30 +37,28 @@ test.describe('ActionMenu', () => {
       test.describe(theme, () => {
         test('default @vrt', async ({page}) => {
           await visit(page, {
-            id: 'components-actionmenu-features--links-and-actions',
+            id: 'components-actionmenu-features--inactive-items',
             globals: {
               colorScheme: theme,
             },
           })
 
-          // Default state
-          expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
-            `ActionMenu.Links And Actions.${theme}.png`,
-          )
-
-          // Open menu
+          // Open state
           await page.locator('button', {hasText: 'Open menu'}).waitFor()
           await page.getByRole('button', {name: 'Open menu'}).click()
-          expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot()
+          expect(await page.screenshot()).toMatchSnapshot(`ActionMenu.Inactive Items.${theme}.png`)
         })
 
         test('axe @aat', async ({page}) => {
           await visit(page, {
-            id: 'components-actionmenu-features--links-and-actions',
+            id: 'components-actionmenu-features--inactive-items',
             globals: {
               colorScheme: theme,
             },
           })
+          // Open menu
+          await page.locator('button', {hasText: 'Open menu'}).waitFor()
+          await page.getByRole('button', {name: 'Open menu'}).click()
           await expect(page).toHaveNoViolations()
         })
       })
@@ -77,7 +76,8 @@ test.describe('ActionMenu', () => {
             },
           })
 
-          // Default state
+          // Open state
+          await page.getByRole('button', {name: 'Open menu'}).click()
           expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
             `ActionMenu.Links And Actions.${theme}.png`,
           )
@@ -90,6 +90,8 @@ test.describe('ActionMenu', () => {
               colorScheme: theme,
             },
           })
+          // Open Menu
+          await page.getByRole('button', {name: 'Open menu'}).click()
           await expect(page).toHaveNoViolations()
         })
       })
@@ -107,7 +109,8 @@ test.describe('ActionMenu', () => {
             },
           })
 
-          // Default state
+          // Open state
+          await page.getByRole('button', {name: 'Display'}).click()
           expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
             `ActionMenu.Multi Select.${theme}.png`,
           )
@@ -120,6 +123,9 @@ test.describe('ActionMenu', () => {
               colorScheme: theme,
             },
           })
+
+          // Open state
+          await page.getByRole('button', {name: 'Display'}).click()
           await expect(page).toHaveNoViolations()
         })
       })
@@ -137,7 +143,8 @@ test.describe('ActionMenu', () => {
             },
           })
 
-          // Default state
+          // Open state
+          await page.getByRole('button', {name: 'Options: fast Forward'}).click()
           expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
             `ActionMenu.Single Select.${theme}.png`,
           )
@@ -150,6 +157,9 @@ test.describe('ActionMenu', () => {
               colorScheme: theme,
             },
           })
+
+          // Open state
+          await page.getByRole('button', {name: 'Options: fast Forward'}).click()
           await expect(page).toHaveNoViolations()
         })
       })
@@ -167,7 +177,7 @@ test.describe('ActionMenu', () => {
             },
           })
 
-          // Default state
+          await page.getByRole('button', {name: 'Open Menu'}).click()
           expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
             `ActionMenu.Controlled Menu.${theme}.png`,
           )
@@ -180,6 +190,9 @@ test.describe('ActionMenu', () => {
               colorScheme: theme,
             },
           })
+
+          // Open state
+          await page.getByRole('button', {name: 'Open Menu'}).click()
           await expect(page).toHaveNoViolations()
         })
       })
@@ -257,7 +270,7 @@ test.describe('ActionMenu', () => {
             },
           })
 
-          // Default state
+          // Open state
           expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
             `ActionMenu.Groups And Descriptions.${theme}.png`,
           )
@@ -270,13 +283,9 @@ test.describe('ActionMenu', () => {
               colorScheme: theme,
             },
           })
-          await expect(page).toHaveNoViolations({
-            rules: {
-              'aria-required-children': {
-                enabled: false,
-              },
-            },
-          })
+
+          // Open state
+          await expect(page).toHaveNoViolations()
         })
       })
     }