Skip to content

Commit

Permalink
Merge 96619cc into 21c3fce
Browse files Browse the repository at this point in the history
  • Loading branch information
langermank authored Sep 25, 2024
2 parents 21c3fce + 96619cc commit aadf564
Show file tree
Hide file tree
Showing 20 changed files with 20 additions and 611 deletions.
5 changes: 5 additions & 0 deletions .changeset/strong-tables-rest.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": major
---

Remove deprecated `Button` component
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import React, {useCallback, useRef, useState} from 'react'
import {ActionMenu} from '../deprecated/ActionMenu'
import BaseStyles from '../BaseStyles'
import Box from '../Box'
import Button from '../deprecated/Button/Button'
import {Button} from '../Button'
import {ConfirmationDialog, useConfirm} from './ConfirmationDialog'
import theme from '../theme'
import {ThemeProvider} from '../ThemeProvider'
Expand Down
7 changes: 3 additions & 4 deletions packages/react/src/Details/__tests__/Details.test.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import {render} from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import React from 'react'
import {Details, useDetails, Box} from '../..'
import {Button, ButtonPrimary} from '../../deprecated'
import type {ButtonProps} from '../../deprecated/Button/Button'
import {Details, useDetails, Box, Button} from '../..'
import type {ButtonProps} from '../../Button'
import {behavesAsComponent, checkExports} from '../../utils/testing'
import axe from 'axe-core'

Expand Down Expand Up @@ -90,7 +89,7 @@ describe('Details', () => {
{open ? 'Open' : 'Closed'}
</Button>
<Box>
<ButtonPrimary>test</ButtonPrimary>
<Button variant="primary">test</Button>
</Box>
</Details>
)
Expand Down
7 changes: 4 additions & 3 deletions packages/react/src/Overlay/Overlay.test.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, {useRef, useState} from 'react'
import {Overlay, Box, Text} from '..'
import {ButtonDanger, Button} from '../deprecated'
import {Overlay, Box, Text, Button} from '..'
import {render, waitFor, fireEvent} from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import axe from 'axe-core'
Expand Down Expand Up @@ -43,7 +42,9 @@ const TestComponent = ({initialFocus, callback}: TestComponentSettings) => {
>
<Box display="flex" flexDirection="column" p={2}>
<Text>Are you sure?</Text>
<ButtonDanger onClick={closeOverlay}>Cancel</ButtonDanger>
<Button variant="danger" onClick={closeOverlay}>
Cancel
</Button>
<Button onClick={closeOverlay} ref={confirmButtonRef}>
Confirm
</Button>
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/__tests__/AnchoredOverlay.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {AnchoredOverlay} from '../AnchoredOverlay'
import {behavesAsComponent, checkExports} from '../utils/testing'
import {render as HTMLRender, fireEvent} from '@testing-library/react'
import axe from 'axe-core'
import {Button} from '../deprecated'
import {Button} from '../Button'
import theme from '../theme'
import BaseStyles from '../BaseStyles'
import {ThemeProvider} from '../ThemeProvider'
Expand Down
126 changes: 0 additions & 126 deletions packages/react/src/__tests__/deprecated/Button.test.tsx

This file was deleted.

4 changes: 2 additions & 2 deletions packages/react/src/deprecated/ActionMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import {List} from './ActionList/List'
import type {ItemProps} from './ActionList/Item'
import {Item} from './ActionList/Item'
import {Divider} from './ActionList/Divider'
import type {ButtonProps} from './Button'
import Button from './Button'
import type {ButtonProps} from '../Button'
import {Button} from '../Button'
import React, {useCallback, useMemo} from 'react'
import {AnchoredOverlay} from '../AnchoredOverlay'
import {useProvidedStateOrCreate} from '../hooks/useProvidedStateOrCreate'
Expand Down
41 changes: 0 additions & 41 deletions packages/react/src/deprecated/Button/Button.tsx

This file was deleted.

39 changes: 0 additions & 39 deletions packages/react/src/deprecated/Button/ButtonBase.tsx

This file was deleted.

42 changes: 0 additions & 42 deletions packages/react/src/deprecated/Button/ButtonClose.tsx

This file was deleted.

44 changes: 0 additions & 44 deletions packages/react/src/deprecated/Button/ButtonDanger.tsx

This file was deleted.

Loading

0 comments on commit aadf564

Please sign in to comment.