Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carriage.return scope; generate content style #16

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Add carriage.return scope; generate content style #16

merged 1 commit into from
Dec 7, 2016

Conversation

vmg
Copy link

@vmg vmg commented Dec 7, 2016

This PR adds support for customizing how we render CR characters on the syntax themes.

cc @jonrohan @aroben

@jonrohan
Copy link
Member

jonrohan commented Dec 7, 2016

Yes, thank you @kivikakk & @vmg 👏 I'm gonna pull this down today and make sure it doesn't break anything else, but so far looks good.

@kivikakk
Copy link

kivikakk commented Dec 7, 2016

One thing I would change is carriage.return to carriage-return. I'm not at a computer now (:bed:), but if you like, please feel free to make that change to the PR!

@jonrohan jonrohan merged commit 4933891 into primer:master Dec 7, 2016
@kivikakk kivikakk deleted the kivikakk/cr-fun branch December 7, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants