Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove form-validation.scss #2402

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Remove form-validation.scss #2402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d570536
Move `.form-group label`
simurai Mar 23, 2023
6457480
Remove `form-validation.scss`
simurai Mar 23, 2023
e8f5ca6
Create .changeset/poor-hotels-roll.md
simurai Mar 23, 2023
bf8e99d
Lint
simurai Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-hotels-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": major
---

Remove `form-validation` styles
3 changes: 2 additions & 1 deletion src/forms/form-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
}

label {
position: relative;
// fix for chrome bug, see https://github.com/github/github/issues/53931
position: static;
}

&.flattened dt, // TODO: Deprecate
Expand Down
265 changes: 0 additions & 265 deletions src/forms/form-validation.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/forms/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
@import './form-control.scss';
@import './form-select.scss';
@import './form-group.scss';
@import './form-validation.scss';
@import './input-group.scss';
@import './radio-group.scss';
// new pvc components
Expand Down