fix: display today button for currentDate even when code executes wit… #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h slightly difference in time
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
@suhailk4 can you open a new issue to link to this ticket or is there a ticket already existing? |
Already did and linked that issue with this PR |
melloware
approved these changes
Jan 13, 2025
|
OK cool can you run |
|
Done. |
|
Thanks! Marked for next release |
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7598
Issue without this fix:
Today button is hidden when maxDate is passed as new Date().
Fix with the PR: Fixes the issue when maxDate is passed as new Date().
Since the code could executes at slightly different time intervals so currentDate in prime react component is always greater than new Date() passed from parent component hence condition executed for Today Button is true therefore Today Button is hidden
With this fix we will compare timeStamp upto minutes only (truncating seconds and milliseconds)
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue or mention it in the description using #<issue_id>.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.